Bleadperl v5.25.2-122-g3a69dad breaks ETHER/B-Hooks-Parser-0.16.tar.gz

[p5pRT]

Migrated from rt.perl.org#128621 (status was 'resolved')

Searchable as RT128621$

[p5pRT]

From @andk

bisect

---

commit 3a69dad
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Sun May 22 14​:35​:31 2016 -0700

  Remove PL_(lex_)encoding and all dependent code

diagnostics

---

cc -c -I/home/sand/src/perl/repoperls/installed-perls/perl/v5.25.2-122-g3a69dad/8942/lib/site_perl/5.25.3/x86_64-linux-ld/B/Hooks/OP/Check/Install -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -O2 -g -DVERSION=\"0.16\" -DXS_VERSION=\"0.16\" -fPIC "-I/home/sand/src/perl/repoperls/installed-perls/perl/v5.25.2-122-g3a69dad/8942/lib/5.25.3/x86_64-linux-ld/CORE" Parser.c
In file included from Parser.xs​:12​:0​:
stolen_chunk_of_toke.c​: In function ‘S_scan_word’​:
stolen_chunk_of_toke.c​:350​:6​: warning​: ‘Perl_is_utf8_mark’ is deprecated [-Wdeprecated-declarations]
  while (UTF8_IS_CONTINUED(*t) && is_utf8_mark((U8*)t))
  ^
In file included from /home/sand/src/perl/repoperls/installed-perls/perl/v5.25.2-122-g3a69dad/8942/lib/5.25.3/x86_64-linux-ld/CORE/perl.h​:5581​:0,
  from Parser.xs​:5​:
/home/sand/src/perl/repoperls/installed-perls/perl/v5.25.2-122-g3a69dad/8942/lib/5.25.3/x86_64-linux-ld/CORE/proto.h​:1560​:19​: note​: declared here
PERL_CALLCONV bool Perl_is_utf8_mark(pTHX_ const U8 *p)
  ^
In file included from Parser.xs​:12​:0​:
stolen_chunk_of_toke.c​: In function ‘S_scan_str’​:
stolen_chunk_of_toke.c​:546​:2​: warning​: ‘Perl_utf8_to_uvchr’ is deprecated [-Wdeprecated-declarations]
  termcode = utf8_to_uvchr((U8*)s, &termlen);
  ^
In file included from /home/sand/src/perl/repoperls/installed-perls/perl/v5.25.2-122-g3a69dad/8942/lib/5.25.3/x86_64-linux-ld/CORE/perl.h​:5581​:0,
  from Parser.xs​:5​:
/home/sand/src/perl/repoperls/installed-perls/perl/v5.25.2-122-g3a69dad/8942/lib/5.25.3/x86_64-linux-ld/CORE/proto.h​:3533​:5​: note​: declared here
PERL_CALLCONV UV Perl_utf8_to_uvchr(pTHX_ const U8 *s, STRLEN *retlen)
  ^
In file included from Parser.xs​:12​:0​:
stolen_chunk_of_toke.c​:574​:6​: error​: ‘PL_encoding’ undeclared (first use in this function)
  if (PL_encoding && !UTF) {
  ^
stolen_chunk_of_toke.c​:574​:6​: note​: each undeclared identifier is reported only once for each function it appears in
Makefile​:347​: recipe for target 'Parser.o' failed
make​: *** [Parser.o] Error 1

perl -V

---

Summary of my perl5 (revision 5 version 25 subversion 3) configuration​:
  Commit id​: 3a69dad
  Platform​:
  osname=linux
  osvers=4.3.0-1-amd64
  archname=x86_64-linux-ld
  uname='linux k83 4.3.0-1-amd64 #1 smp debian 4.3.3-7 (2016-01-19) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/perl/v5.25.2-122-g3a69dad/8942 -Dmyhostname=k83 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Dlibswanted=cl pthread socket inet nsl gdbm dbm malloc dl ld sun m crypt sec util c cposix posix ucb BSD gdbm_compat -Uuseithreads -Duselongdouble -DDEBUGGING=-g'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=undef
  usemultiplicity=undef
  use64bitint=define
  use64bitall=define
  uselongdouble=define
  usemymalloc=n
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
  optimize='-O2 -g'
  cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='5.3.1 20160121'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='long double'
  nvsize=16
  Off_t='off_t'
  lseeksize=8
  alignbytes=16
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/5/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lpthread -lnsl -lgdbm -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.21.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.21'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​:
  HAS_TIMES
  PERLIO_LAYERS
  PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD
  PERL_MALLOC_WRAP
  PERL_OP_PARENT
  PERL_PRESERVE_IVUV
  PERL_USE_DEVEL
  USE_64_BIT_ALL
  USE_64_BIT_INT
  USE_LARGE_FILES
  USE_LOCALE
  USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC
  USE_LOCALE_TIME
  USE_LONG_DOUBLE
  USE_PERLIO
  USE_PERL_ATOF
  Built under linux
  Compiled at Jul 15 2016 01​:00​:29
  @​INC​:
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.25.2-122-g3a69dad/8942/lib/site_perl/5.25.3/x86_64-linux-ld
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.25.2-122-g3a69dad/8942/lib/site_perl/5.25.3
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.25.2-122-g3a69dad/8942/lib/5.25.3/x86_64-linux-ld
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.25.2-122-g3a69dad/8942/lib/5.25.3
  .

--
andreas

[p5pRT]

From @andk

Also affected​: ETHER/Devel-Declare-0.006018.tar.gz
--
andreas

[p5pRT]

From @cpansprout

On Thu Jul 14 16​:37​:03 2016, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Also affected​: ETHER/Devel-Declare-0.006018.tar.gz

Both have the same stolen_chunk_of_toke.c.

Does the attached fix both dists?

--

Father Chrysostomos

[p5pRT]

From @cpansprout

Inline Patch

diff --git a/perl.h b/perl.h
index 1f19140..8f5713d 100644
--- a/perl.h
+++ b/perl.h
@@ -5285,6 +5285,7 @@ EXTCONST char *const PL_phase_names[];
 #  define PL_dirty cBOOL(PL_phase == PERL_PHASE_DESTRUCT)
 
 #  define PL_amagic_generation PL_na
+#  define PL_encoding (SV *)NULL
 #endif /* !PERL_CORE */
 
 #define PL_hints PL_compiling.cop_hints

[p5pRT]

The RT System itself - Status changed from 'new' to 'open'

[p5pRT]

From @andk

On Thu, 14 Jul 2016 18​:19​:09 -0700, "Father Chrysostomos via RT" <perlbug-followup@​perl.org> said​:

  > On Thu Jul 14 16​:37​:03 2016, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Also affected​: ETHER/Devel-Declare-0.006018.tar.gz

  > Both have the same stolen_chunk_of_toke.c.

  > Does the attached fix both dists?

Yes. (I unintentionally just sent out reports with my own commit
v5.25.2-139-g98289a7 which will arrive on cpantesters)

--
andreas

[p5pRT]

From @cpansprout

On Thu Jul 14 22​:47​:36 2016, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

On Thu, 14 Jul 2016 18​:19​:09 -0700, "Father Chrysostomos via RT"
<perlbug-followup@​perl.org> said​:

On Thu Jul 14 16​:37​:03 2016, andreas.koenig.7os6VVqR@​franz.ak.mind.de
wrote​:

Also affected​: ETHER/Devel-Declare-0.006018.tar.gz

Both have the same stolen_chunk_of_toke.c.

Does the attached fix both dists?

Yes. (I unintentionally just sent out reports with my own commit
v5.25.2-139-g98289a7 which will arrive on cpantesters)

I have applied a similar patch (with proper macro parentheses!) as 8bfa1b5. Thank you.

--

Father Chrysostomos

[p5pRT]

@cpansprout - Status changed from 'open' to 'resolved'