Repeated installs broken in blead #15466
Comments
From @dur-randirCreated by @dur-randirCommit 31b6f23 broke the following command sequence: cd /path/to/source Previously, both perls got installed. Now, first one is installed, but the second one is not and $? == 2 afterwards. Last lines from the build log are: chmod 755 ../../lib/auto/B/B.bundle chmod 755 ../../lib/auto/Compress/Raw/Bzip2/Bzip2.bundle Perl Info |
From @dcollinsnThe reported commit: commit 31b6f23 [perl #126710] only touch pm_to_blib if files are copied Add checks similar to what the Makefile would do: only copy the On Wed Jul 20 16:56:09 2016, randir wrote:
This does not show a failing command. Can you either scroll back to the first error, or repeat the test without -j3 on the command line? Thanks! -- |
|
The RT System itself - Status changed from 'new' to 'open' |
From @dur-randirOn Wed Jul 20 17:00:37 2016, dcollinsn@gmail.com wrote:
There're actually a lot of failures: Now you must run 'make'. If you compile perl5 on a different machine or from a different object echo @`sh cflags "optimize='-O3'" opmini.o` -DPERL_IS_MINIPERL -DPERL_EXTERNAL_GLOB opmini.c chmod 755 ../../lib/auto/B/B.bundle chmod 755 ../../lib/auto/Compress/Raw/Bzip2/Bzip2.bundle |
From @cpansproutOn Wed Jul 20 17:15:43 2016, randir wrote:
That’s probably it. My hunch is that ExtUtils::Miniperl needs to depend on something outside of dist/ExtUtils-Miniperl and that make_ext.pl is not handling it. Maybe we should stop make_ext.pl from trying to handle ExtUtils::Miniperl itself instead of using make. All it has caused is problems so far. -- Father Chrysostomos |
From @tonycozOn Wed, Jul 20, 2016 at 06:08:45PM -0700, Father Chrysostomos via RT wrote:
If it's not handling dependencies correctly for EU::Miniperl, it's I'll take a look this afternoon. That said, I don't really expect that recipe to work without a "make Tony |
From @dcollinsnThe fatal error occurs here: cc -o perl -mmacosx-version-min=10.9 -fstack-protector -L/usr/local/lib perlmain.o libperl.a `cat ext.libs` -lpthread -ldl -lm -lutil -lc This only occurs when going from a non-threaded to a threaded build, if both builds are the same, this does not happen. I tried this in a run. Configure finished for the second time at 9:20, and I ran make at 9:21. dcollins@nightshade64:~/toolchain/perldebug$ ls -la | grep "\.o" I snipped everything that was touched AT or AFTER 9:21. perlmain.o is the obvious suspect. So, something is issuing this command, it needs to depend on perlmain.o, and it is not. What is it? cc -c -D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-pr -- |
From @tonycozOn Wed Jul 20 18:25:57 2016, dcollinsn@gmail.com wrote:
Or, possibly, perlmain.o isn't depending on something it should. The make depend step done by Configure doesn't generate any dependencies An alternate attempt which I thought was equivalent failed with an unknown Tony |
From @tonycozOn Wed Jul 20 22:58:50 2016, tonyc wrote:
The attachment which I forgot, like usual. Tony |
From @tonycoz0001-perl-128685-generate-dependency-rules-for-perlmain-O.patchFrom d8939c5a4d195fc64a02c1fa2c98ee8dd37e1649 Mon Sep 17 00:00:00 2001
From: Tony Cook <tony@develop-help.com>
Date: Thu, 21 Jul 2016 15:53:04 +1000
Subject: (perl #128685) generate dependency rules for perlmain$(OBJ_EXT)
Without these rules changes to files like config.sh might not
result in perlmain.o being rebuilt.
Someone who knows sed should be able to improve this.
---
makedepend.SH | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/makedepend.SH b/makedepend.SH
index 4e203b6..12dffad 100755
--- a/makedepend.SH
+++ b/makedepend.SH
@@ -231,8 +231,9 @@ if $test -s .deptmp; then
$sed 's|\.incl\.c|.h|' .deptmp >.deptmp.vos
mv -f .deptmp.vos .deptmp
fi
- $sed 's|^\(.*\$(OBJ_EXT):\) *\(.*/.*\.c\) *$|\1 \2; '"$defrule \2|" .deptmp \
- >>$mf.new
+ $sed -n -e 's|^\(.*\$(OBJ_EXT):\) *\(.*/.*\.c\) *$|\1 \2; '"$defrule \2|" -e p \
+ -e '/^miniperlmain/{' -e 's/mini//' -e p -e '}' \
+ .deptmp >>$mf.new
else
$MAKE hlist || ($echo "Searching for .h files..."; \
$echo *.h | $tr ' ' $trnl | $egrep -v '\*' >.hlist)
--
2.1.4
|
From @dcollinsnShould we also warn in INSTALL that you ought not re-./Configure in a dirty On Fri, Jul 22, 2016 at 12:00 AM, Tony Cook via RT <
|
From @dur-randirOn Thu Jul 21 21:00:46 2016, tonyc wrote:
Works for me too. |
From @ap* Tony Cook via RT <perlbug-followup@perl.org> [2016-07-22 06:12]:
You can combine -e p -e '/^miniperlmain/{' -e 's/mini//' -e p -e '}' If you reverse order inside the block you can drop the `-n` switch and If it’s acceptable to reverse the order of lines for that case, then you In total: Regards, |
From @tonycozOn Fri Jul 22 16:00:05 2016, aristotle wrote:
Thanks, applied as d58d97f Tony |
|
@tonycoz - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release today of Perl 5.26.0, this and 210 other issues have been Perl 5.26.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
|
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#128685 (status was 'resolved')
Searchable as RT128685$
The text was updated successfully, but these errors were encountered: