perl5 segfaults (perl5 versions gentoo(5.20.0, 5.22.0), guix (5.22.1)) without message #15478
Comments
From ng0@we.make.ritual.n0.isHello, I am packaging the Net::PSYC application suite for Guix and On Guix you have to look at the perl-Curses and perl-net-psyc The source on CPAN (https://metacpan.org/pod/Net::PSYC) is Output below was captured on the Gentoo developing system, first The developer runs 5.22.0 of perl5 on Gentoo, I run 5.20.0 on My experience with perl5 is limited to packaging for Guix and As the Gentoo ebuild is not yet finished and we do not use the The main issue is with "torify psycion" with an defined URI of ng0@shikahr ~ $ gdb --silent --args perl /usr/bin/psycion This is perl 5, version 20, subversion 2 (v5.20.2) built for x86_64-linux-debug Copyright 1987-2015, Larry Wall Perl may be copied only under the terms of either the Artistic License or the Complete documentation for Perl, including FAQ lists, should be found on Summary of my perl5 (revision 5 version 20 subversion 2) configuration: Platform: Characteristics of this binary (from libperl): Upgraded to torsocks-2.2.0-rc1: (gdb) quit Inferior 1 [process 28129] will be killed. Quit anyway? (y or n) y thanks, |
From zefram@fysh.orgng0 wrote:
The code in the body of this function is prepared for the array argument The null arises from the h_aliases element of struct hostent. None of the I suggest that we should reinstate the "array &&" check on that line, Note for reporter: if it were not this straightforward, we would probably -zefram |
|
The RT System itself - Status changed from 'new' to 'open' |
From @cpansproutOn Tue Jul 26 07:05:30 2016, zefram@fysh.org wrote:
Please review the attached patch. I am not familiar with this sort of thing, so I would like to make sure the commit message makes sense. -- Father Chrysostomos |
From @cpansproutOn Sun Jul 31 19:25:50 2016, sprout wrote:
Now I’m doing it! Here is the attachment. -- Father Chrysostomos |
From @cpansproutFrom 65acdc7 Mon Sep 17 00:00:00 2001 [perl #128740] Check for null in pp_ghostent et al. Specifically in the S_space_join_names_mortal static function that Inline Patchdiff --git a/embed.fnc b/embed.fnc
index c0b7a3e..2021b3e 100644
--- a/embed.fnc
+++ b/embed.fnc
@@ -2132,7 +2132,7 @@ s |OP* |doform |NN CV *cv|NN GV *gv|NULLOK OP *retop
# if !defined(HAS_MKDIR) || !defined(HAS_RMDIR)
sR |int |dooneliner |NN const char *cmd|NN const char *filename
# endif
-s |SV * |space_join_names_mortal|NN char *const *array
+s |SV * |space_join_names_mortal|NULLOK char *const *array
#endif
p |OP * |tied_method|NN SV *methname|NN SV **sp \
|NN SV *const sv|NN const MAGIC *const mg \
diff --git a/pp_sys.c b/pp_sys.c
index 3bf2673..d16a0e5 100644
--- a/pp_sys.c
+++ b/pp_sys.c
@@ -4934,9 +4934,7 @@ S_space_join_names_mortal(pTHX_ char *const *array)
{
SV *target;
- PERL_ARGS_ASSERT_SPACE_JOIN_NAMES_MORTAL;
-
- if (*array) {
+ if (array && *array) {
target = newSVpvs_flags("", SVs_TEMP);
while (1) {
sv_catpv(target, *array);
diff --git a/proto.h b/proto.h
index a06b6d0..da11ced 100644
--- a/proto.h
+++ b/proto.h
@@ -4859,8 +4859,6 @@ STATIC OP* S_doform(pTHX_ CV *cv, GV *gv, OP *retop);
#define PERL_ARGS_ASSERT_DOFORM \
assert(cv); assert(gv)
STATIC SV * S_space_join_names_mortal(pTHX_ char *const *array);
-#define PERL_ARGS_ASSERT_SPACE_JOIN_NAMES_MORTAL \
- assert(array)
#endif
#if defined(PERL_IN_REGCOMP_C)
STATIC SV* S__make_exactf_invlist(pTHX_ RExC_state_t *pRExC_state, regnode *node) |
From @tonycozOn Tue Jul 26 07:05:30 2016, zefram@fysh.org wrote:
I suspect it's not a real libc, but torsocks: https://gitweb.torproject.org/torsocks.git/tree/src/lib/gethostbyname.c#n92 torify is a command that LD_PRELOADs libtorsocks, which replaces gethostbyname() etc. Tony |
From zefram@fysh.orgFather Chrysostomos via RT wrote:
Looks good to me. -zefram |
From zefram@fysh.orgTony Cook via RT wrote:
Ah, yes. Should probably be reported as a bug in torsocks, then. -zefram |
From @cpansproutOn Sun Jul 31 23:46:48 2016, zefram@fysh.org wrote:
Thank you. Now applied as d35c1b5. I propose we backport this to the maint branches, but probably not till after the imminent releases. -- Father Chrysostomos |
|
@cpansprout - Status changed from 'open' to 'pending release' |
From ng0@we.make.ritual.n0.isZefram via RT <perlbug-followup@perl.org> writes:
Thank you all for your work on fixing this bug. I will a get in contact with torsocks developers to address the bug on |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release today of Perl 5.26.0, this and 210 other issues have been Perl 5.26.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
|
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#128740 (status was 'resolved')
Searchable as RT128740$
The text was updated successfully, but these errors were encountered: