Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.27.2-30-gdf6b4bd565 breaks SYBER/Panda-Lib-1.3.2.tar.gz #16123

Closed
p5pRT opened this issue Aug 23, 2017 · 17 comments
Closed

Bleadperl v5.27.2-30-gdf6b4bd565 breaks SYBER/Panda-Lib-1.3.2.tar.gz #16123

p5pRT opened this issue Aug 23, 2017 · 17 comments
Labels
BBC

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Aug 23, 2017

Migrated from rt.perl.org#131953 (status was 'resolved')

Searchable as RT131953$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Aug 23, 2017

From @andk

Discovered by Slaven, hvala lijepa!

bisect


commit df6b4bd
Author​: David Mitchell <davem@​iabyn.com>
Date​: Fri Jul 7 14​:13​:32 2017 +0100

  give REGEXP SVs the POK flag again

cpantesters


http​://www.cpantesters.org/cpan/report/a0526a7e-74e4-11e7-b839-7de6a299d00c

perl -V


Summary of my perl5 (revision 5 version 27 subversion 3) configuration​:
  Commit id​: c1a6686
  Platform​:
  osname=linux
  osvers=4.9.0-2-amd64
  archname=x86_64-linux-ld
  uname='linux k93msid 4.9.0-2-amd64 #1 smp debian 4.9.18-1 (2017-03-30) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.2-75-gc1a6686e7b/ea6b -Dmyhostname=k93msid -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Dlibswanted=cl pthread socket inet nsl gdbm dbm malloc dl ld sun m crypt sec util c cposix posix ucb BSD gdbm_compat -Uuseithreads -Duselongdouble -DEBUGGING=none'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=undef
  usemultiplicity=undef
  use64bitint=define
  use64bitall=define
  uselongdouble=define
  usemymalloc=n
  default_inc_excludes_dot=define
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
  optimize='-O2'
  cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='6.3.0 20170406'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='long double'
  nvsize=16
  Off_t='off_t'
  lseeksize=8
  alignbytes=16
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/6/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.24.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.24'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​:
  HAS_TIMES
  PERLIO_LAYERS
  PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_MALLOC_WRAP
  PERL_OP_PARENT
  PERL_PRESERVE_IVUV
  PERL_USE_DEVEL
  USE_64_BIT_ALL
  USE_64_BIT_INT
  USE_LARGE_FILES
  USE_LOCALE
  USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC
  USE_LOCALE_TIME
  USE_LONG_DOUBLE
  USE_PERLIO
  USE_PERL_ATOF
  Built under linux
  Compiled at Jul 27 2017 11​:01​:34
  %ENV​:
  PERL5LIB="/tmp/loop_over_bdir-14536-3qSGQ1/FusionInventory-Agent-2.3.18-0/blib/arch​:/tmp/loop_over_bdir-14536-3qSGQ1/FusionInventory-Agent-2.3.18-0/blib/lib​:/tmp/loop_over_bdir-14536-3qSGQ1/FusionInventory-Agent-2.3.19-0/blib/arch​:/tmp/loop_over_bdir-14536-3qSGQ1/FusionInventory-Agent-2.3.19-0/blib/lib"
  PERL5OPT=""
  PERL5_CPANPLUS_IS_RUNNING="15984"
  PERL5_CPAN_IS_RUNNING="15984"
  PERL_CANARY_STABILITY_NOPROMPT="1"
  PERL_MM_USE_DEFAULT="1"
  PERL_USE_UNSAFE_INC="1"
  @​INC​:
  /tmp/loop_over_bdir-14536-3qSGQ1/FusionInventory-Agent-2.3.18-0/blib/arch
  /tmp/loop_over_bdir-14536-3qSGQ1/FusionInventory-Agent-2.3.18-0/blib/lib
  /tmp/loop_over_bdir-14536-3qSGQ1/FusionInventory-Agent-2.3.19-0/blib/arch
  /tmp/loop_over_bdir-14536-3qSGQ1/FusionInventory-Agent-2.3.19-0/blib/lib
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.2-75-gc1a6686e7b/ea6b/lib/site_perl/5.27.3/x86_64-linux-ld
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.2-75-gc1a6686e7b/ea6b/lib/site_perl/5.27.3
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.2-75-gc1a6686e7b/ea6b/lib/5.27.3/x86_64-linux-ld
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.2-75-gc1a6686e7b/ea6b/lib/5.27.3
  .

--
andreas

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Aug 24, 2017

From @jkeenan

On 08/23/2017 05​:50 PM, (Andreas J. Koenig) (via RT) wrote​:

# New Ticket Created by (Andreas J. Koenig)
# Please include the string​: [perl #131953]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=131953 >

Discovered by Slaven, hvala lijepa!

bisect
------
commit df6b4bd
Author​: David Mitchell <davem@​iabyn.com>
Date​: Fri Jul 7 14​:13​:32 2017 +0100

 give REGEXP SVs the POK flag again

cpantesters
-----------
http​://www.cpantesters.org/cpan/report/a0526a7e-74e4-11e7-b839-7de6a299d00c

In each case, the failing unit test is one that tests the
Panda​::Lib​::compare() function. That function is documented at
http​://search.cpan.org/dist/Panda-Lib/lib/Panda/Lib.pod#compare_($data1,_$data2).
  Given how complex that function is documented to be, I am not
surprised that a change in blead tickles something at the XS level which
causes previously passing tests to fail.

This will probably require consultation with the module author in order
to resolve.

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Aug 24, 2017

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Aug 24, 2017

From @jkeenan

On Thu, 24 Aug 2017 01​:04​:30 GMT, jkeenan@​pobox.com wrote​:

On 08/23/2017 05​:50 PM, (Andreas J. Koenig) (via RT) wrote​:

# New Ticket Created by (Andreas J. Koenig)
# Please include the string​: [perl #131953]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=131953 >

Discovered by Slaven, hvala lijepa!

bisect
------
commit df6b4bd
Author​: David Mitchell <davem@​iabyn.com>
Date​: Fri Jul 7 14​:13​:32 2017 +0100

give REGEXP SVs the POK flag again

cpantesters
-----------
http​://www.cpantesters.org/cpan/report/a0526a7e-74e4-11e7-b839-
7de6a299d00c

In each case, the failing unit test is one that tests the
Panda​::Lib​::compare() function. That function is documented at
http​://search.cpan.org/dist/Panda-
Lib/lib/Panda/Lib.pod#compare_($data1,_$data2).
Given how complex that function is documented to be, I am not
surprised that a change in blead tickles something at the XS level
which
causes previously passing tests to fail.

This will probably require consultation with the module author in
order
to resolve.

Compare the result of 'perl Makefile.PL && make' on perl-5.26.0 and blead, respectively​:

#####
$ perl -v | head -2 | tail -1
This is perl 5, version 26, subversion 0 (v5.26.0) built for x86_64-linux

$ ls -ltr | tail -2
-rw-rw-r-- 1 jkeenan jkeenan 12778 Aug 23 21​:32 Lib.c
-rw-rw-r-- 1 jkeenan jkeenan 12648 Aug 23 21​:32 Lib.o
#####
$ ~/testing/blead/bin/perl -v | head -2 | tail -1
This is perl 5, version 27, subversion 4 (v5.27.4 (v5.27.3-14-gd2dccc0)) built for x86_64-linux

$ ls -ltr | tail -2
-rw-rw-r-- 1 jkeenan jkeenan 12778 Aug 23 21​:31 Lib.c
-rw-rw-r-- 1 jkeenan jkeenan 30584 Aug 23 21​:31 Lib.o
#####

Much larger Lib.o file when built against blead.

Would the fact that blead has a newer version of ExtUtils​::ParseXS make any difference?

#####
$ diff -w ./Lib.c /home/jkeenan/.cpanm/work/1503534420.31523/Panda-Lib-1.3.2/Lib.c
2c2
< * This file was generated automatically by ExtUtils​::ParseXS version 3.34 from the


* This file was generated automatically by ExtUtils​::ParseXS version 3.35 from the
#####

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Aug 24, 2017

From @cpansprout

On Wed, 23 Aug 2017 18​:40​:01 -0700, jkeenan wrote​:

Compare the result of 'perl Makefile.PL && make' on perl-5.26.0 and
blead, respectively​:

Debugging, or non-debugging? That may explain the .o file size difference.

#####
$ perl -v | head -2 | tail -1
This is perl 5, version 26, subversion 0 (v5.26.0) built for x86_64-
linux

$ ls -ltr | tail -2
-rw-rw-r-- 1 jkeenan jkeenan 12778 Aug 23 21​:32 Lib.c
-rw-rw-r-- 1 jkeenan jkeenan 12648 Aug 23 21​:32 Lib.o
#####
$ ~/testing/blead/bin/perl -v | head -2 | tail -1
This is perl 5, version 27, subversion 4 (v5.27.4 (v5.27.3-14-
gd2dccc0)) built for x86_64-linux

$ ls -ltr | tail -2
-rw-rw-r-- 1 jkeenan jkeenan 12778 Aug 23 21​:31 Lib.c
-rw-rw-r-- 1 jkeenan jkeenan 30584 Aug 23 21​:31 Lib.o
#####

Much larger Lib.o file when built against blead.

Would the fact that blead has a newer version of ExtUtils​::ParseXS
make any difference?

#####
$ diff -w ./Lib.c /home/jkeenan/.cpanm/work/1503534420.31523/Panda-
Lib-1.3.2/Lib.c
2c2
< * This file was generated automatically by ExtUtils​::ParseXS
version 3.34 from the
---

* This file was generated automatically by ExtUtils​::ParseXS version
3.35 from the
#####

Thank you very much.

--

Father Chrysostomos

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Aug 24, 2017

From @iabyn

On Wed, Aug 23, 2017 at 09​:04​:14PM -0400, James E Keenan wrote​:

On 08/23/2017 05​:50 PM, (Andreas J. Koenig) (via RT) wrote​:

# New Ticket Created by (Andreas J. Koenig)
# Please include the string​: [perl #131953]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=131953 >

Discovered by Slaven, hvala lijepa!

bisect
------
commit df6b4bd
Author​: David Mitchell <davem@​iabyn.com>
Date​: Fri Jul 7 14​:13​:32 2017 +0100

 give REGEXP SVs the POK flag again

cpantesters
-----------
http​://www.cpantesters.org/cpan/report/a0526a7e-74e4-11e7-b839-7de6a299d00c

In each case, the failing unit test is one that tests the
Panda​::Lib​::compare() function. That function is documented at http​://search.cpan.org/dist/Panda-Lib/lib/Panda/Lib.pod#compare_($data1,_$data2).
Given how complex that function is documented to be, I am not surprised that
a change in blead tickles something at the XS level which causes previously
passing tests to fail.

This will probably require consultation with the module author in order to
resolve.

Its a bug in the author's code.

In _elem_cmp(), there is this​:

  if (SvOK(f) & SvOK(s)) { // both are not undefs

which is expecting that SvOK() returns a boolean (0/1) value. It's
actually documented to return a U32. There was a period when the
value returned by it happened to be actually 0 or 1, but my commit
to changed that as a side-effect of simplifying the SvOK() expression.

That code needs to be

  if (SvOK(f) && SvOK(s)) { // both are not undefs

and probably similar things done with ^, | and & in other places too.

--
"But Sidley Park is already a picture, and a most amiable picture too.
The slopes are green and gentle. The trees are companionably grouped at
intervals that show them to advantage. The rill is a serpentine ribbon
unwound from the lake peaceably contained by meadows on which the right
amount of sheep are tastefully arranged." -- Lady Croom, "Arcadia"

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Aug 24, 2017

From @jkeenan

On Thu, 24 Aug 2017 03​:15​:44 GMT, sprout wrote​:

On Wed, 23 Aug 2017 18​:40​:01 -0700, jkeenan wrote​:

Compare the result of 'perl Makefile.PL && make' on perl-5.26.0 and
blead, respectively​:

Debugging, or non-debugging? That may explain the .o file size difference.

Ah, yes. For the purpose of looking at *other* BBC tickets, my blead build was -DDEBUGGING. So the difference in object sizes is not relevant to this ticket. Thanks for the catch.

#####
$ perl -v | head -2 | tail -1
This is perl 5, version 26, subversion 0 (v5.26.0) built for x86_64-
linux

$ ls -ltr | tail -2
-rw-rw-r-- 1 jkeenan jkeenan 12778 Aug 23 21​:32 Lib.c
-rw-rw-r-- 1 jkeenan jkeenan 12648 Aug 23 21​:32 Lib.o
#####
$ ~/testing/blead/bin/perl -v | head -2 | tail -1
This is perl 5, version 27, subversion 4 (v5.27.4 (v5.27.3-14-
gd2dccc0)) built for x86_64-linux

$ ls -ltr | tail -2
-rw-rw-r-- 1 jkeenan jkeenan 12778 Aug 23 21​:31 Lib.c
-rw-rw-r-- 1 jkeenan jkeenan 30584 Aug 23 21​:31 Lib.o
#####

Much larger Lib.o file when built against blead.

Would the fact that blead has a newer version of ExtUtils​::ParseXS
make any difference?

#####
$ diff -w ./Lib.c /home/jkeenan/.cpanm/work/1503534420.31523/Panda-
Lib-1.3.2/Lib.c
2c2
< * This file was generated automatically by ExtUtils​::ParseXS
version 3.34 from the
---

* This file was generated automatically by ExtUtils​::ParseXS version
3.35 from the
#####

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 15, 2018

From @dur-randir

Fixed with 1.3.5

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 15, 2018

From @xsawyerx

On Mon, 15 Jan 2018 10​:38​:19 -0800, randir wrote​:

Fixed with 1.3.5

Can anyone confirm?

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 15, 2018

From @eserte

Dana Mon, 15 Jan 2018 12​:22​:32 -0800, xsawyerx@​cpan.org reče​:

On Mon, 15 Jan 2018 10​:38​:19 -0800, randir wrote​:

Fixed with 1.3.5

Can anyone confirm?

Fails to build on most platforms I tried (FreeBSD 10,11,12, CentOS6, Debian/jessie, Ubuntu 16.04), but probably due to other reasons (fails also with 5.26.x). But I had success with 5.27.7 on Debian/stretch.

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 15, 2018

From @dur-randir

On Mon, 15 Jan 2018 12​:41​:30 -0800, slaven@​rezic.de wrote​:

Fails to build on most platforms I tried (FreeBSD 10,11,12, CentOS6,
Debian/jessie, Ubuntu 16.04), but probably due to other reasons (fails
also with 5.26.x). But I had success with 5.27.7 on Debian/stretch.

Have you tried 1.3.4 or 1.3.5? 1.3.4 failed to build on threaded perls.

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 15, 2018

From @eserte

Dana Mon, 15 Jan 2018 12​:56​:05 -0800, randir reče​:

On Mon, 15 Jan 2018 12​:41​:30 -0800, slaven@​rezic.de wrote​:

Fails to build on most platforms I tried (FreeBSD 10,11,12, CentOS6,
Debian/jessie, Ubuntu 16.04), but probably due to other reasons (fails
also with 5.26.x). But I had success with 5.27.7 on Debian/stretch.

Have you tried 1.3.4 or 1.3.5? 1.3.4 failed to build on threaded perls.

I tried 1.3.5. The failures were all compilation failures in the dependencies.

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 15, 2018

From @dur-randir

On Mon, 15 Jan 2018 13​:02​:52 -0800, slaven@​rezic.de wrote​:

I tried 1.3.5. The failures were all compilation failures in the
dependencies.

Can you provide a full install log for any of the failing cases? Cpantesters shows no reports for 1.3.5 yet. What I can think of - one of this module's prerequisite, Panda​::XS, requires a c++14 compliant compiler as of version 2.1.8.

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 16, 2018

From @eserte

Dana Mon, 15 Jan 2018 13​:14​:10 -0800, randir reče​:

On Mon, 15 Jan 2018 13​:02​:52 -0800, slaven@​rezic.de wrote​:

I tried 1.3.5. The failures were all compilation failures in the
dependencies.

Can you provide a full install log for any of the failing cases?
Cpantesters shows no reports for 1.3.5 yet. What I can think of - one
of this module's prerequisite, Panda​::XS, requires a c++14 compliant
compiler as of version 2.1.8.

This is Panda-specific, so I put the log into a new ticket​:
https://rt.cpan.org/Ticket/Display.html?id=124103

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 16, 2018

From @dur-randir

On Tue, 16 Jan 2018 11​:01​:50 -0800, slaven@​rezic.de wrote​:

This is Panda-specific, so I put the log into a new ticket​:
https://rt.cpan.org/Ticket/Display.html?id=124103

Thanks, I'll look further into it.

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Apr 19, 2018

From @iabyn

On Tue, Jan 16, 2018 at 03​:23​:49PM -0800, Sergey Aleynikov via RT wrote​:

On Tue, 16 Jan 2018 11​:01​:50 -0800, slaven@​rezic.de wrote​:

This is Panda-specific, so I put the log into a new ticket​:
https://rt.cpan.org/Ticket/Display.html?id=124103

Thanks, I'll look further into it.

Closing this perl ticket, as it's no longer a perl issue.

--
This is a great day for France!
  -- Nixon at Charles De Gaulle's funeral

@p5pRT p5pRT closed this as completed Apr 20, 2018
@p5pRT
Copy link
Author

@p5pRT p5pRT commented Apr 20, 2018

@iabyn - Status changed from 'open' to 'resolved'

@p5pRT p5pRT added BBC Severity Low labels Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BBC
Projects
None yet
Development

No branches or pull requests

1 participant