Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.27.2-65-gea710183d4 breaks SARTAK/NetHack-Item-0.21.tar.gz #16167

Closed
p5pRT opened this issue Sep 23, 2017 · 12 comments
Closed

Bleadperl v5.27.2-65-gea710183d4 breaks SARTAK/NetHack-Item-0.21.tar.gz #16167

p5pRT opened this issue Sep 23, 2017 · 12 comments
Labels

Comments

@p5pRT
Copy link
Collaborator

@p5pRT p5pRT commented Sep 23, 2017

Migrated from rt.perl.org#132152 (status was 'resolved')

Searchable as RT132152$

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 23, 2017

From @andk

Slaven sent me yet another BBC.

bisect


commit ea71018
Author​: David Mitchell <davem@​iabyn.com>
Date​: Wed Jul 19 14​:04​:36 2017 +0100

  harmonise S_pushav() and pp_padav()

cpantesters


http​://www.cpantesters.org/cpan/report/26f4d550-7439-11e7-b7b1-f7132b4c90c2

perl -V


Summary of my perl5 (revision 5 version 27 subversion 3) configuration​:
  Commit id​: c1a6686
  Platform​:
  osname=linux
  osvers=4.9.0-2-amd64
  archname=x86_64-linux-ld
  uname='linux k93msid 4.9.0-2-amd64 #1 smp debian 4.9.18-1 (2017-03-30) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.2-75-gc1a6686e7b/ea6b -Dmyhostname=k93msid -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Dlibswanted=cl pthread socket inet nsl gdbm dbm malloc dl ld sun m crypt sec util c cposix posix ucb BSD gdbm_compat -Uuseithreads -Duselongdouble -DEBUGGING=none'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=undef
  usemultiplicity=undef
  use64bitint=define
  use64bitall=define
  uselongdouble=define
  usemymalloc=n
  default_inc_excludes_dot=define
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
  optimize='-O2'
  cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='6.3.0 20170406'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='long double'
  nvsize=16
  Off_t='off_t'
  lseeksize=8
  alignbytes=16
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/6/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.24.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.24'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​:
  HAS_TIMES
  PERLIO_LAYERS
  PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_MALLOC_WRAP
  PERL_OP_PARENT
  PERL_PRESERVE_IVUV
  PERL_USE_DEVEL
  USE_64_BIT_ALL
  USE_64_BIT_INT
  USE_LARGE_FILES
  USE_LOCALE
  USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC
  USE_LOCALE_TIME
  USE_LONG_DOUBLE
  USE_PERLIO
  USE_PERL_ATOF
  Built under linux
  Compiled at Jul 27 2017 11​:01​:34
  %ENV​:
  PERL5LIB="/tmp/loop_over_bdir-14536-rzPOcB/Net-DNS-1.11-0/blib/arch​:/tmp/loop_over_bdir-14536-rzPOcB/Net-DNS-1.11-0/blib/lib"
  PERL5OPT=""
  PERL5_CPANPLUS_IS_RUNNING="18365"
  PERL5_CPAN_IS_RUNNING="18365"
  PERL_CANARY_STABILITY_NOPROMPT="1"
  PERL_MM_USE_DEFAULT="1"
  PERL_USE_UNSAFE_INC="1"
  @​INC​:
  /tmp/loop_over_bdir-14536-rzPOcB/Net-DNS-1.11-0/blib/arch
  /tmp/loop_over_bdir-14536-rzPOcB/Net-DNS-1.11-0/blib/lib
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.2-75-gc1a6686e7b/ea6b/lib/site_perl/5.27.3/x86_64-linux-ld
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.2-75-gc1a6686e7b/ea6b/lib/site_perl/5.27.3
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.2-75-gc1a6686e7b/ea6b/lib/5.27.3/x86_64-linux-ld
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.2-75-gc1a6686e7b/ea6b/lib/5.27.3
  .

--
andreas

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 24, 2017

From @jkeenan

On Sat, 23 Sep 2017 20​:53​:58 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Slaven sent me yet another BBC.

bisect
------
commit ea71018
Author​: David Mitchell <davem@​iabyn.com>
Date​: Wed Jul 19 14​:04​:36 2017 +0100

harmonise S_pushav() and pp_padav()

cpantesters
-----------
http​://www.cpantesters.org/cpan/report/26f4d550-7439-11e7-b7b1-
f7132b4c90c2

Although this is a case where Blead did Break CPAN, the fix will not necessarily be just on blead's part. Even with perl-5.26.0 this module's test suite throws up 141 deprecation warnings, some of which were the subject of a bug ticket filed in November 2013. With 5.26.0 the test suite passes, but I suspect the code has not been touched by the author in all that time. So unless the commit in question starts breaking other CPAN distributions, I doubt that we should treat this as high-priority breakage until we hear from the author.

Here's what the actual breakage looks like​:

#####
# Failed test 'there are 21 randomized scrolls'
# at t/700-tracker.t line 8.
# got​: '0'
# expected​: '21'
Deep recursion on subroutine "Class​::MOP​::Class​::​:before" at /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.2-75-gc1a6686e7b/ea6b/lib/site_perl/5.27.3/x86_64-linux-ld/Class/MOP/Method/Wrapped.pm line 43.
Deep recursion on subroutine "NetHack​::Item​::identity" at /tmp/loop_over_bdir-14536-rzPOcB/NetHack-Item-0.21-0/blib/lib/NetHack/Item.pm line 653.
Deep recursion on subroutine "NetHack​::Item​::_wrapped_identity" at /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.2-75-gc1a6686e7b/ea6b/lib/site_perl/5.27.3/x86_64-linux-ld/Class/MOP/Method/Wrapped.pm line 95.
Out of memory!
Out of memory!
Out of memory!
Out of memory!
Out of memory!
Out of memory!
Out of memory!
Out of memory!
t/700-tracker.t ....................
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests
#####

Thank you very much.
--
James E Keenan (jkeenan@​cpan.org)

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 24, 2017

The RT System itself - Status changed from 'new' to 'open'

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 25, 2017

From @iabyn

On Sat, Sep 23, 2017 at 07​:09​:42PM -0700, James E Keenan via RT wrote​:

On Sat, 23 Sep 2017 20​:53​:58 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Slaven sent me yet another BBC.

bisect
------
commit ea71018
Author​: David Mitchell <davem@​iabyn.com>
Date​: Wed Jul 19 14​:04​:36 2017 +0100

harmonise S_pushav() and pp_padav()

cpantesters
-----------
http​://www.cpantesters.org/cpan/report/26f4d550-7439-11e7-b7b1-
f7132b4c90c2

Although this is a case where Blead did Break CPAN, the fix will not
necessarily be just on blead's part. Even with perl-5.26.0 this
module's test suite throws up 141 deprecation warnings, some of which
were the subject of a bug ticket filed in November 2013. With 5.26.0
the test suite passes, but I suspect the code has not been touched by
the author in all that time. So unless the commit in question starts
breaking other CPAN distributions, I doubt that we should treat this as
high-priority breakage until we hear from the author.

However, since this is a pure-perl module, we should always look closely
where any changes to blead which are not supposed to have user-visible
side effects, have user-visible side effects.

But in this particular case I can't get close to getting the test in
question to run under blead, let alone fail in the way you described. I
had to force install List​::MoreUtils​::XS and NetHack​::Monster​::Spoiler,
and after that I get a bunch of errors as shown below.

So I won't be spending any further time on this.

$ ~/perl5/git/bleed.out/bin/perl5.27.5 -Mblib t/700-tracker.t
Class​::MOP​::load_class is deprecated at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/x86_64-linux-thread-multi/Class/MOP.pm line 69.
  Class​::MOP​::load_class("NetHack​::Item​::Spoiler") called at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item.pm line 228
  NetHack​::Item​::spoiler_class(NetHack​::Item=HASH(0x40921c8)) called at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item.pm line 307
  NetHack​::Item​::extract_stats(NetHack​::Item=HASH(0x40921c8), "a scroll labeled KIRJE") called at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item.pm line 389
  NetHack​::Item​::parse_raw(NetHack​::Item=HASH(0x40921c8)) called at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item.pm line 205
  NetHack​::Item​::BUILD(NetHack​::Item=HASH(0x40921c8), HASH(0x1fc9240)) called at constructor NetHack​::Item​::new (defined at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item.pm line 743) line 221
  NetHack​::Item​::new("NetHack​::Item", "raw", "a scroll labeled KIRJE", "pool", NetHack​::ItemPool=HASH(0x1fa1f78)) called at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/ItemPool.pm line 62
  NetHack​::ItemPool​::_create_item("raw", "a scroll labeled KIRJE") called at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/ItemPool.pm line 68
  NetHack​::ItemPool​::new_item(NetHack​::ItemPool=HASH(0x1fa1f78), "a scroll labeled KIRJE") called at t/700-tracker.t line 6
Couldn't require NetHack​::Item​::Spoiler​::Food : You can only consume roles, MooseX​::Role​::Matcher is not a Moose role at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/x86_64-linux-thread-multi/Moose/Exporter.pm line 419
  Moose​::with('MooseX​::Role​::Matcher', 'HASH(0x4116660)') called at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/NetHack/Monster/Spoiler.pm line 3
  require NetHack/Monster/Spoiler.pm at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item/Spoiler/Food.pm line 8
  NetHack​::Item​::Spoiler​::Food​::BEGIN at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/NetHack/Monster/Spoiler.pm line 0
  eval {...} at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/NetHack/Monster/Spoiler.pm line 0
  require NetHack/Item/Spoiler/Food.pm at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/Module/Runtime.pm line 317
  Module​::Runtime​::require_module('NetHack​::Item​::Spoiler​::Food') called at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/Module/Pluggable/Object.pm line 297
  eval {...} at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/Module/Pluggable/Object.pm line 297
  Module​::Pluggable​::Object​::handle_finding_plugin('Module​::Pluggable​::Object=HASH(0x3a04030)', 'NetHack​::Item​::Spoiler​::Food', 'ARRAY(0x3ad1780)') called at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/Module/Pluggable/Object.pm line 254
  Module​::Pluggable​::Object​::search_paths('Module​::Pluggable​::Object=HASH(0x3a04030)', '/home/davem/tmp/x/NetHack-Item-0.21/blib/lib') called at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/Module/Pluggable/Object.pm line 178
  Module​::Pluggable​::Object​::search_directories('Module​::Pluggable​::Object=HASH(0x3a04030)', '/home/davem/tmp/x/NetHack-Item-0.21/blib/arch', '/home/davem/tmp/x/NetHack-Item-0.21/blib/lib') called at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/Module/Pluggable/Object.pm line 82
  Module​::Pluggable​::Object​::plugins('Module​::Pluggable​::Object=HASH(0x3a04030)') called at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/Module/Pluggable.pm line 32
  Module​::Pluggable​::__ANON__('NetHack​::Item​::Spoiler') called at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item/Spoiler.pm line 218
  NetHack​::Item​::Spoiler​::plural_of_list('NetHack​::Item​::Spoiler') called at /home/davem/perl5/git/bleed.out/lib/5.27.5/Memoize.pm line 249
  Memoize​::_memoizer('CODE(0x3b44548)', 'NetHack​::Item​::Spoiler') called at (eval 337) line 1
  Memoize​::__ANON__('NetHack​::Item​::Spoiler') called at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item/Spoiler.pm line 228
  NetHack​::Item​::Spoiler​::singular_of_list('NetHack​::Item​::Spoiler') called at /home/davem/perl5/git/bleed.out/lib/5.27.5/Memoize.pm line 249
  Memoize​::_memoizer('CODE(0x3b446e0)', 'NetHack​::Item​::Spoiler') called at (eval 338) line 1
  Memoize​::__ANON__('NetHack​::Item​::Spoiler') called at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item/Spoiler.pm line 242
  NetHack​::Item​::Spoiler​::singularize('NetHack​::Item​::Spoiler', 'scroll labeled KIRJE') called at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item.pm line 314
  NetHack​::Item​::extract_stats('NetHack​::Item=HASH(0x40921c8)', 'a scroll labeled KIRJE') called at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item.pm line 389
  NetHack​::Item​::parse_raw('NetHack​::Item=HASH(0x40921c8)') called at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item.pm line 205
  NetHack​::Item​::BUILD('NetHack​::Item=HASH(0x40921c8)', 'HASH(0x1fc9240)') called at constructor NetHack​::Item​::new (defined at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item.pm line 743) line 221
  NetHack​::Item​::new('NetHack​::Item', 'raw', 'a scroll labeled KIRJE', 'pool', 'NetHack​::ItemPool=HASH(0x1fa1f78)') called at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/ItemPool.pm line 62
  NetHack​::ItemPool​::_create_item('raw', 'a scroll labeled KIRJE') called at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/ItemPool.pm line 68
  NetHack​::ItemPool​::new_item('NetHack​::ItemPool=HASH(0x1fa1f78)', 'a scroll labeled KIRJE') called at t/700-tracker.t line 6
Compilation failed in require at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item/Spoiler/Food.pm line 8.
BEGIN failed--compilation aborted at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item/Spoiler/Food.pm line 8.
Compilation failed in require at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/Module/Runtime.pm line 317.
at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/Module/Pluggable.pm line 32.
Couldn't require NetHack​::Item​::Spoiler​::Tool : Attempt to reload NetHack/Monster/Spoiler.pm aborted.
Compilation failed in require at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item/Spoiler/Tool.pm line 8.
BEGIN failed--compilation aborted at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item/Spoiler/Tool.pm line 8.
Compilation failed in require at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/Module/Runtime.pm line 317.
at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/Module/Pluggable.pm line 32.
Couldn't require NetHack​::Item​::Spoiler​::Statue : Attempt to reload NetHack/Monster/Spoiler.pm aborted.
Compilation failed in require at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item/Spoiler/Statue.pm line 8.
BEGIN failed--compilation aborted at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item/Spoiler/Statue.pm line 8.
Compilation failed in require at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/Module/Runtime.pm line 317.
at /home/davem/perl5/git/bleed.out/lib/site_perl/5.27.5/Module/Pluggable.pm line 32.
Can't locate object method "_list" via package "NetHack​::Item​::Spoiler​::Food" at /home/davem/tmp/x/NetHack-Item-0.21/blib/lib/NetHack/Item/Spoiler.pm line 38.

--
"There's something wrong with our bloody ships today, Chatfield."
  -- Admiral Beatty at the Battle of Jutland, 31st May 1916.

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 25, 2017

From gmail@sartak.org

From looking at the stack trace I suspect this could affect other distributions that depend on Moose. I'll see if I can replicate the issue in a standalone test.

Thanks,
Shawn

iPhoneから送信

H29/09/23 22​:09、James E Keenan via RT <perlbug-followup@​perl.org>のメール​:

On Sat, 23 Sep 2017 20​:53​:58 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:
Slaven sent me yet another BBC.

bisect
------
commit ea71018
Author​: David Mitchell <davem@​iabyn.com>
Date​: Wed Jul 19 14​:04​:36 2017 +0100

harmonise S_pushav() and pp_padav()

cpantesters
-----------
http​://www.cpantesters.org/cpan/report/26f4d550-7439-11e7-b7b1-
f7132b4c90c2

Although this is a case where Blead did Break CPAN, the fix will not necessarily be just on blead's part. Even with perl-5.26.0 this module's test suite throws up 141 deprecation warnings, some of which were the subject of a bug ticket filed in November 2013. With 5.26.0 the test suite passes, but I suspect the code has not been touched by the author in all that time. So unless the commit in question starts breaking other CPAN distributions, I doubt that we should treat this as high-priority breakage until we hear from the author.

Here's what the actual breakage looks like​:

#####
# Failed test 'there are 21 randomized scrolls'
# at t/700-tracker.t line 8.
# got​: '0'
# expected​: '21'
Deep recursion on subroutine "Class​::MOP​::Class​::​:before" at /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.2-75-gc1a6686e7b/ea6b/lib/site_perl/5.27.3/x86_64-linux-ld/Class/MOP/Method/Wrapped.pm line 43.
Deep recursion on subroutine "NetHack​::Item​::identity" at /tmp/loop_over_bdir-14536-rzPOcB/NetHack-Item-0.21-0/blib/lib/NetHack/Item.pm line 653.
Deep recursion on subroutine "NetHack​::Item​::_wrapped_identity" at /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.2-75-gc1a6686e7b/ea6b/lib/site_perl/5.27.3/x86_64-linux-ld/Class/MOP/Method/Wrapped.pm line 95.
Out of memory!
Out of memory!
Out of memory!
Out of memory!
Out of memory!
Out of memory!
Out of memory!
Out of memory!
t/700-tracker.t ....................
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests
#####

Thank you very much.
--
James E Keenan (jkeenan@​cpan.org)

---
via perlbug​: queue​: perl5 status​: new
https://rt-archive.perl.org/perl5/Ticket/Display.html?id=132152

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Nov 8, 2017

From @xsawyerx

On Mon, 25 Sep 2017 16​:38​:33 -0700, gmail@​sartak.org wrote​:

From looking at the stack trace I suspect this could affect other
distributions that depend on Moose. I'll see if I can replicate the
issue in a standalone test.

Any update on this issue, Shawn?

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Nov 9, 2017

From @jkeenan

On Wed, 08 Nov 2017 18​:27​:39 GMT, xsawyerx@​cpan.org wrote​:

On Mon, 25 Sep 2017 16​:38​:33 -0700, gmail@​sartak.org wrote​:

From looking at the stack trace I suspect this could affect other
distributions that depend on Moose. I'll see if I can replicate the
issue in a standalone test.

Any update on this issue, Shawn?

Yesterday I got bit by the "Out of memory" problem again while doing automated testing of CPAN against blead. That cost me most of an hour getting everything back under control.

So I would really like to see this problem corrected or this distribution moved off CPAN.

Thank you very much.
--
James E Keenan (jkeenan@​cpan.org)

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Nov 10, 2017

From @iabyn

On Thu, Nov 09, 2017 at 05​:20​:47AM -0800, James E Keenan via RT wrote​:

On Wed, 08 Nov 2017 18​:27​:39 GMT, xsawyerx@​cpan.org wrote​:

On Mon, 25 Sep 2017 16​:38​:33 -0700, gmail@​sartak.org wrote​:

From looking at the stack trace I suspect this could affect other
distributions that depend on Moose. I'll see if I can replicate the
issue in a standalone test.

Any update on this issue, Shawn?

Yesterday I got bit by the "Out of memory" problem again while doing automated testing of CPAN against blead. That cost me most of an hour getting everything back under control.

So I would really like to see this problem corrected or this distribution moved off CPAN.

I've looked into it some more, and it turns out that it's a bug with
Set​::Object (which NetHack-Item uses) not honouring get magic.

I've raised a CPAN ticket​:

  https://rt.cpan.org/Ticket/Display.html?id=123582

Also, this proof-of-concept fix in Set​::Object makes NetHack-Item pass​:

Inline Patch
--- Object.xs-	2017-11-10 11:04:50.345719730 +0000
+++ Object.xs	2017-11-10 11:07:15.406916153 +0000
@@ -643,6 +643,7 @@
      sv_bless(self, gv_stashsv(pkg, FALSE));
 
      for (item = 1; item < items; ++item) {
+       SvGETMAGIC(ST(item));
        ISET_INSERT(s, ST(item));
      }
 


-- 

Please note that ash-trays are provided for the use of smokers,
whereas the floor is provided for the use of all patrons.
  -- Bill Royston

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Nov 12, 2017

From @xsawyerx

On 11/10/2017 12​:34 PM, Dave Mitchell wrote​:

On Thu, Nov 09, 2017 at 05​:20​:47AM -0800, James E Keenan via RT wrote​:

On Wed, 08 Nov 2017 18​:27​:39 GMT, xsawyerx@​cpan.org wrote​:

On Mon, 25 Sep 2017 16​:38​:33 -0700, gmail@​sartak.org wrote​:

From looking at the stack trace I suspect this could affect other
distributions that depend on Moose. I'll see if I can replicate the
issue in a standalone test.
Any update on this issue, Shawn?
Yesterday I got bit by the "Out of memory" problem again while doing automated testing of CPAN against blead. That cost me most of an hour getting everything back under control.

So I would really like to see this problem corrected or this distribution moved off CPAN.
I've looked into it some more, and it turns out that it's a bug with
Set​::Object (which NetHack-Item uses) not honouring get magic.

I've raised a CPAN ticket​:

https://rt.cpan.org/Ticket/Display.html?id=123582

Also, this proof-of-concept fix in Set​::Object makes NetHack-Item pass​:

--- Object.xs- 2017-11-10 11​:04​:50.345719730 +0000
+++ Object.xs 2017-11-10 11​:07​:15.406916153 +0000
@​@​ -643,6 +643,7 @​@​
sv_bless(self, gv_stashsv(pkg, FALSE));

  for \(item = 1; item \< items; \+\+item\) \{

+ SvGETMAGIC(ST(item));
ISET_INSERT(s, ST(item));
}

Nice, Dave!

I see Reini had already merged the patch.

Can we get an A-OK from our testers before we resolve this?

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Nov 13, 2017

From @andk

On Sun, 12 Nov 2017 08​:54​:59 +0100, Sawyer X <xsawyerx@​gmail.com> said​:

  > Can we get an A-OK from our testers before we resolve this?

The first pass reports have been generated with perls that previously
could not generate pass reports. You can visit
http​://matrix.cpantesters.org/?dist=NetHack-Item+0.21 and click on
http​://matrix.cpantesters.org/?dist=NetHack-Item%200.21;os=linux;perl=5.27.6;reports=1
or
http​://matrix.cpantesters.org/?dist=NetHack-Item%200.21;os=linux;perl=5.27.5;reports=1
to find them.

--
andreas

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Nov 14, 2017

From @xsawyerx

On Mon, 13 Nov 2017 11​:50​:30 -0800, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

On Sun, 12 Nov 2017 08​:54​:59 +0100, Sawyer X <xsawyerx@​gmail.com>
said​:

Can we get an A-OK from our testers before we resolve this?

The first pass reports have been generated with perls that previously
could not generate pass reports. You can visit
http​://matrix.cpantesters.org/?dist=NetHack-Item+0.21 and click on
http​://matrix.cpantesters.org/?dist=NetHack-
Item%200.21;os=linux;perl=5.27.6;reports=1
or
http​://matrix.cpantesters.org/?dist=NetHack-
Item%200.21;os=linux;perl=5.27.5;reports=1
to find them.

Resolved. Thank you, Andreas! (And everyone involved.)

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Nov 14, 2017

@xsawyerx - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this Nov 14, 2017
@p5pRT p5pRT added the Severity Low label Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.