Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBC: recent commit breaks App::perlbrew #16268

Closed
p5pRT opened this issue Nov 22, 2017 · 10 comments
Closed

BBC: recent commit breaks App::perlbrew #16268

p5pRT opened this issue Nov 22, 2017 · 10 comments

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Nov 22, 2017

Migrated from rt.perl.org#132483 (status was 'resolved')

Searchable as RT132483$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Nov 22, 2017

From @jkeenan

CPAN module App​::perlbrew is broken in blead. The breakage, which
occurred this month, started somewhere *after*
b3937e2^ and at or before
a1c09da. But my bisection ended very
messily, so I can't identify the breaking commit with great confidence.
Here are some results​:

#####
Running make for G/GU/GUGOD/App-perlbrew-0.80.tar.gz
cp lib/App/perlbrew.pm blib/lib/App/perlbrew.pm
cp bin/perlbrew blib/script/perlbrew
"/tmp/0Kh870nPwT/bin/perl" "-Iinc" -MExtUtils​::MY -e 'MY->fixin(shift)'
-- blib/script/perlbrew
Manifying 1 pod document
Manifying 1 pod document
  GUGOD/App-perlbrew-0.80.tar.gz
  /usr/bin/make -- OK
Running make test
PERL_DL_NONLAZY=1 "/tmp/0Kh870nPwT/bin/perl" "-MExtUtils​::Command​::MM"
"-MTest​::Harness" "-e" "undef *Test​::Harness​::Switches; test_harness(0,
'inc', 'blib/lib', 'blib/arch')" t/*.t
t/00.load.t ............................ ok
t/01.options.t ......................... ok
t/02.format_perl_version.t ............. ok
t/03.path_with_tilde.t ................. ok
t/03.test_get_available_versions.t ..... ok
t/04.find_available_perls.t ............ ok
t/05.get_current_perl.t ................ ok
t/06.installed_perls.t ................. ok
t/07.argv.t ............................ ok
t/08.error_available.t ................. ok
t/08.error_install.t ................... ok
t/08.error_install_blead.t ............. ok
t/08.error_install_cpanm.t ............. ok
t/09.exit_status.t ..................... 1/?
# Failed test 'threw Regexp ((?^​:unknown-command))'
# at t/09.exit_status.t line 21.
# expecting​: Regexp ((?^​:unknown-command))
# found​: Not a GLOB reference at
/tmp/hiV7_3iGYY/App-perlbrew-0.80-0/blib/lib/App/perlbrew.pm line 505.
# Looks like you failed 1 test of 3.
t/09.exit_status.t ..................... Dubious, test returned 1 (wstat
256, 0x100)
Failed 1/3 subtests
t/10.resolve.t ......................... ok
t/11.editdist.t ........................ ok
t/11.root_from_arg.t ................... ok
t/12.destdir.t ......................... ok
t/12.sitecustomize.t ................... ok
t/13.perl_release.t .................... ok
t/14.perl_version_parsing.t ............ ok
t/15.no-reuse-build-dir.t .............. ok
t/16.release-detail.t .................. ok
t/17.release-detail-cperl-local.t ...... ok
t/18.release-detail-perl-local.t ....... ok
t/18.release-detail-perl-remote.t ...... skipped​: These tests send HTTP
requests. Set env TEST_LIVE=1 to really run them.
t/command-alias.t ...................... ok
t/command-available.t .................. ok
t/command-compgen.t .................... 1/?
# Failed test 'compgen command, when there is no args displays a list
of subcommands' by dying​:
# Not a GLOB reference
# at /tmp/hiV7_3iGYY/App-perlbrew-0.80-0/blib/lib/App/perlbrew.pm
line 505.

# Failed test 'compgen command, when there is a part of a subcommand
displays a list of l*' by dying​:
# Not a GLOB reference
# at /tmp/hiV7_3iGYY/App-perlbrew-0.80-0/blib/lib/App/perlbrew.pm
line 505.

# Failed test 'compgen command, when there is a part of a subcommand
'versio[tab]' is completed as 'version'' by dying​:
# Not a GLOB reference
# at /tmp/hiV7_3iGYY/App-perlbrew-0.80-0/blib/lib/App/perlbrew.pm
line 505.
# Looks like you failed 3 tests of 7.
t/command-compgen.t .................... Dubious, test returned 3 (wstat
768, 0x300)
Failed 3/7 subtests
t/command-display-rc.t ................. ok
t/command-env.t ........................ 1/? Attempting to create
directory /tmp/4pIlouvJTa/libs/perl-5.14.1@​nobita
t/command-env.t ........................ ok
t/command-exec.t ....................... 1/? Command [perl -E 'somesub
42'] terminated with exit code 7 ($? = 1792) under the following perl
environment​:
format_info_output_value
Command [perl -E 'say 42'] terminated with exit code 3 ($? = 768) under
the following perl environment​:
Command [perl -E 'say 42'] terminated with exit code 3 ($? = 768) under
the following perl environment​:
Command [perl -E 'say 42'] terminated with exit code 3 ($? = 768) under
the following perl environment​:
Command [perl -E 'say 42'] terminated with exit code 255 ($? = -1) under
the following perl environment​:
Command [perl -E 'say 42'] terminated with exit code 7 ($? = 1792) under
the following perl environment​:
t/command-exec.t ....................... ok
t/command-help.t ....................... ok
t/command-info.t ....................... ok
t/command-install-cpanm.t .............. ok
t/command-install-patchperl.t .......... ok
t/command-lib.t ........................ ok
t/command-list.t ....................... ok
t/current_perl.t ....................... ok
t/do_system.t .......................... ok
t/failure-command-install-cpanm.t ...... ok
t/failure-command-install-patchperl.t .. ok
t/http-program-control.t ............... ok
t/http-ua-detect-non-curl.t ............ #
PATH=/tmp/hiV7_3iGYY/App-perlbrew-0.80-0/t/fake-bin​:/usr/lib/dart/bin​:/home/jkeenan/perl5/perlbrew/bin​:/home/jkeenan/perl5/perlbrew/perls/perl-5.26.0/bin​:/usr/lib/ccache​:/usr/local/bin​:/usr/local/sbin​:/usr/local/bin​:/usr/sbin​:/usr/bin​:/sbin​:/bin​:/usr/games​:/usr/local/games​:/snap/bin​:/home/jkeenan/bin​:/home/jkeenan/bin/perl​:/home/jkeenan/bin/shell​:~/.pub-cache/bin
# curl = /tmp/hiV7_3iGYY/App-perlbrew-0.80-0/t/fake-bin/curl
t/http-ua-detect-non-curl.t ............ ok
t/http-ua-detect.t ..................... ok
t/http.t ............................... skipped​: (no reason given)
t/installation-perlbrew.t .............. ok
t/installation.t ....................... ok
t/installation2.t ...................... ok
t/installation3.t ...................... ok
t/unit-files-are-the-same.t ............ ok

Test Summary Report


t/09.exit_status.t (Wstat​: 256 Tests​: 3 Failed​: 1)
  Failed test​: 1
  Non-zero exit status​: 1
t/command-compgen.t (Wstat​: 768 Tests​: 7 Failed​: 3)
  Failed tests​: 1-3
  Non-zero exit status​: 3
Files=51, Tests=486, 10 wallclock secs ( 0.25 usr 0.04 sys + 8.40 cusr
  0.61 csys = 9.30 CPU)
Result​: FAIL
Failed 2/51 test programs. 4/486 subtests failed.
Makefile​:801​: recipe for target 'test_dynamic' failed
make​: *** [test_dynamic] Error 255
  GUGOD/App-perlbrew-0.80.tar.gz
  /usr/bin/make test -- NOT OK
//hint// to see the cpan-testers results for installing this module, try​:
  reports GUGOD/App-perlbrew-0.80.tar.gz
Died at -e line 2.
HEAD is now at a1c09da in B​::Concise, show RV target better
bad - non-zero exit from /tmp/0Kh870nPwT/bin/perl -I /home/jkeenan/.cpan
-MCPAN​::MyConfig -MCPAN -e
$CPAN​::Config->{build_dir}=q{/tmp/hiV7_3iGYY}; -e
install('App​::perlbrew'); die unless CPAN​::Shell->expand(Module =>
'App​::perlbrew')->uptodate;
#####

Summary of my perl5 (revision 5 version 27 subversion 7) configuration​:
  Commit id​: 8510c6c
  Platform​:
  osname=linux
  osvers=4.4.0-98-generic
  archname=x86_64-linux
  uname='linux zareason 4.4.0-98-generic #121-ubuntu smp tue oct 10
14​:24​:03 utc 2017 x86_64 x86_64 x86_64 gnulinux '
  config_args='-des -Dusedevel -Uversiononly
-Dprefix=/home/jkeenan/testing/blead -Dman1dir=none -Dman3dir=none'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=undef
  usemultiplicity=undef
  use64bitint=define
  use64bitall=define
  uselongdouble=undef
  usemymalloc=n
  default_inc_excludes_dot=define
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-fwrapv -fno-strict-aliasing -pipe
-fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64'
  optimize='-O2'
  cppflags='-fwrapv -fno-strict-aliasing -pipe
-fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='5.4.1 20160904'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='double'
  nvsize=8
  Off_t='off_t'
  lseeksize=8
  alignbytes=8
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/5/include-fixed
/usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib
/usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /lib64 /usr/lib64
  libs=-lpthread -lnsl -ldb -ldl -lm -lcrypt -lutil -lc
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.23.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.23'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​:
  HAS_TIMES
  PERLIO_LAYERS
  PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_MALLOC_WRAP
  PERL_OP_PARENT
  PERL_PRESERVE_IVUV
  PERL_USE_DEVEL
  USE_64_BIT_ALL
  USE_64_BIT_INT
  USE_LARGE_FILES
  USE_LOCALE
  USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC
  USE_LOCALE_TIME
  USE_PERLIO
  USE_PERL_ATOF
  Built under linux
  Compiled at Nov 21 2017 18​:24​:22
  %ENV​:
  PERL2DIR="/home/jkeenan/gitwork/perl2"
  PERLBREW_BASHRC_VERSION="0.78"
  PERLBREW_HOME="/home/jkeenan/.perlbrew"
  PERLBREW_MANPATH="/home/jkeenan/perl5/perlbrew/perls/perl-5.26.0/man"

PERLBREW_PATH="/home/jkeenan/perl5/perlbrew/bin​:/home/jkeenan/perl5/perlbrew/perls/perl-5.26.0/bin"
  PERLBREW_PERL="perl-5.26.0"
  PERLBREW_ROOT="/home/jkeenan/perl5/perlbrew"
  PERLBREW_VERSION="0.78"
  PERL_WORKDIR="/home/jkeenan/gitwork/perl"
  @​INC​:
  lib
  /home/jkeenan/testing/blead/lib/perl5/site_perl/5.27.7/x86_64-linux
  /home/jkeenan/testing/blead/lib/perl5/site_perl/5.27.7
  /home/jkeenan/testing/blead/lib/perl5/5.27.7/x86_64-linux
  /home/jkeenan/testing/blead/lib/perl5/5.27.7

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Nov 22, 2017

From @xsawyerx

Taking a look at the code, I imagine it's the following check​:

            if(defined *$glob{CODE}) {...}

I'll contact Gugod.

On 11/22/2017 03​:40 AM, James E Keenan (via RT) wrote​:

# New Ticket Created by James E Keenan
# Please include the string​: [perl #132483]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=132483 >

CPAN module App​::perlbrew is broken in blead. The breakage, which
occurred this month, started somewhere *after*
b3937e2^ and at or before
a1c09da. But my bisection ended very
messily, so I can't identify the breaking commit with great confidence.
Here are some results​:

#####
Running make for G/GU/GUGOD/App-perlbrew-0.80.tar.gz
cp lib/App/perlbrew.pm blib/lib/App/perlbrew.pm
cp bin/perlbrew blib/script/perlbrew
"/tmp/0Kh870nPwT/bin/perl" "-Iinc" -MExtUtils​::MY -e 'MY->fixin(shift)'
-- blib/script/perlbrew
Manifying 1 pod document
Manifying 1 pod document
GUGOD/App-perlbrew-0.80.tar.gz
/usr/bin/make -- OK
Running make test
PERL_DL_NONLAZY=1 "/tmp/0Kh870nPwT/bin/perl" "-MExtUtils​::Command​::MM"
"-MTest​::Harness" "-e" "undef *Test​::Harness​::Switches; test_harness(0,
'inc', 'blib/lib', 'blib/arch')" t/*.t
t/00.load.t ............................ ok
t/01.options.t ......................... ok
t/02.format_perl_version.t ............. ok
t/03.path_with_tilde.t ................. ok
t/03.test_get_available_versions.t ..... ok
t/04.find_available_perls.t ............ ok
t/05.get_current_perl.t ................ ok
t/06.installed_perls.t ................. ok
t/07.argv.t ............................ ok
t/08.error_available.t ................. ok
t/08.error_install.t ................... ok
t/08.error_install_blead.t ............. ok
t/08.error_install_cpanm.t ............. ok
t/09.exit_status.t ..................... 1/?
# Failed test 'threw Regexp ((?^​:unknown-command))'
# at t/09.exit_status.t line 21.
# expecting​: Regexp ((?^​:unknown-command))
# found​: Not a GLOB reference at
/tmp/hiV7_3iGYY/App-perlbrew-0.80-0/blib/lib/App/perlbrew.pm line 505.
# Looks like you failed 1 test of 3.
t/09.exit_status.t ..................... Dubious, test returned 1 (wstat
256, 0x100)
Failed 1/3 subtests
t/10.resolve.t ......................... ok
t/11.editdist.t ........................ ok
t/11.root_from_arg.t ................... ok
t/12.destdir.t ......................... ok
t/12.sitecustomize.t ................... ok
t/13.perl_release.t .................... ok
t/14.perl_version_parsing.t ............ ok
t/15.no-reuse-build-dir.t .............. ok
t/16.release-detail.t .................. ok
t/17.release-detail-cperl-local.t ...... ok
t/18.release-detail-perl-local.t ....... ok
t/18.release-detail-perl-remote.t ...... skipped​: These tests send HTTP
requests. Set env TEST_LIVE=1 to really run them.
t/command-alias.t ...................... ok
t/command-available.t .................. ok
t/command-compgen.t .................... 1/?
# Failed test 'compgen command, when there is no args displays a list
of subcommands' by dying​:
# Not a GLOB reference
# at /tmp/hiV7_3iGYY/App-perlbrew-0.80-0/blib/lib/App/perlbrew.pm
line 505.

# Failed test 'compgen command, when there is a part of a subcommand
displays a list of l*' by dying​:
# Not a GLOB reference
# at /tmp/hiV7_3iGYY/App-perlbrew-0.80-0/blib/lib/App/perlbrew.pm
line 505.

# Failed test 'compgen command, when there is a part of a subcommand
'versio[tab]' is completed as 'version'' by dying​:
# Not a GLOB reference
# at /tmp/hiV7_3iGYY/App-perlbrew-0.80-0/blib/lib/App/perlbrew.pm
line 505.
# Looks like you failed 3 tests of 7.
t/command-compgen.t .................... Dubious, test returned 3 (wstat
768, 0x300)
Failed 3/7 subtests
t/command-display-rc.t ................. ok
t/command-env.t ........................ 1/? Attempting to create
directory /tmp/4pIlouvJTa/libs/perl-5.14.1@​nobita
t/command-env.t ........................ ok
t/command-exec.t ....................... 1/? Command [perl -E 'somesub
42'] terminated with exit code 7 ($? = 1792) under the following perl
environment​:
format_info_output_value
Command [perl -E 'say 42'] terminated with exit code 3 ($? = 768) under
the following perl environment​:
Command [perl -E 'say 42'] terminated with exit code 3 ($? = 768) under
the following perl environment​:
Command [perl -E 'say 42'] terminated with exit code 3 ($? = 768) under
the following perl environment​:
Command [perl -E 'say 42'] terminated with exit code 255 ($? = -1) under
the following perl environment​:
Command [perl -E 'say 42'] terminated with exit code 7 ($? = 1792) under
the following perl environment​:
t/command-exec.t ....................... ok
t/command-help.t ....................... ok
t/command-info.t ....................... ok
t/command-install-cpanm.t .............. ok
t/command-install-patchperl.t .......... ok
t/command-lib.t ........................ ok
t/command-list.t ....................... ok
t/current_perl.t ....................... ok
t/do_system.t .......................... ok
t/failure-command-install-cpanm.t ...... ok
t/failure-command-install-patchperl.t .. ok
t/http-program-control.t ............... ok
t/http-ua-detect-non-curl.t ............ #
PATH=/tmp/hiV7_3iGYY/App-perlbrew-0.80-0/t/fake-bin​:/usr/lib/dart/bin​:/home/jkeenan/perl5/perlbrew/bin​:/home/jkeenan/perl5/perlbrew/perls/perl-5.26.0/bin​:/usr/lib/ccache​:/usr/local/bin​:/usr/local/sbin​:/usr/local/bin​:/usr/sbin​:/usr/bin​:/sbin​:/bin​:/usr/games​:/usr/local/games​:/snap/bin​:/home/jkeenan/bin​:/home/jkeenan/bin/perl​:/home/jkeenan/bin/shell​:~/.pub-cache/bin
# curl = /tmp/hiV7_3iGYY/App-perlbrew-0.80-0/t/fake-bin/curl
t/http-ua-detect-non-curl.t ............ ok
t/http-ua-detect.t ..................... ok
t/http.t ............................... skipped​: (no reason given)
t/installation-perlbrew.t .............. ok
t/installation.t ....................... ok
t/installation2.t ...................... ok
t/installation3.t ...................... ok
t/unit-files-are-the-same.t ............ ok

Test Summary Report
-------------------
t/09.exit_status.t (Wstat​: 256 Tests​: 3 Failed​: 1)
Failed test​: 1
Non-zero exit status​: 1
t/command-compgen.t (Wstat​: 768 Tests​: 7 Failed​: 3)
Failed tests​: 1-3
Non-zero exit status​: 3
Files=51, Tests=486, 10 wallclock secs ( 0.25 usr 0.04 sys + 8.40 cusr
0.61 csys = 9.30 CPU)
Result​: FAIL
Failed 2/51 test programs. 4/486 subtests failed.
Makefile​:801​: recipe for target 'test_dynamic' failed
make​: *** [test_dynamic] Error 255
GUGOD/App-perlbrew-0.80.tar.gz
/usr/bin/make test -- NOT OK
//hint// to see the cpan-testers results for installing this module, try​:
reports GUGOD/App-perlbrew-0.80.tar.gz
Died at -e line 2.
HEAD is now at a1c09da in B​::Concise, show RV target better
bad - non-zero exit from /tmp/0Kh870nPwT/bin/perl -I /home/jkeenan/.cpan
-MCPAN​::MyConfig -MCPAN -e
$CPAN​::Config->{build_dir}=q{/tmp/hiV7_3iGYY}; -e
install('App​::perlbrew'); die unless CPAN​::Shell->expand(Module =>
'App​::perlbrew')->uptodate;
#####

Summary of my perl5 (revision 5 version 27 subversion 7) configuration​:
Commit id​: 8510c6c
Platform​:
osname=linux
osvers=4.4.0-98-generic
archname=x86_64-linux
uname='linux zareason 4.4.0-98-generic #121-ubuntu smp tue oct 10
14​:24​:03 utc 2017 x86_64 x86_64 x86_64 gnulinux '
config_args='-des -Dusedevel -Uversiononly
-Dprefix=/home/jkeenan/testing/blead -Dman1dir=none -Dman3dir=none'
hint=recommended
useposix=true
d_sigaction=define
useithreads=undef
usemultiplicity=undef
use64bitint=define
use64bitall=define
uselongdouble=undef
usemymalloc=n
default_inc_excludes_dot=define
bincompat5005=undef
Compiler​:
cc='cc'
ccflags ='-fwrapv -fno-strict-aliasing -pipe
-fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64'
optimize='-O2'
cppflags='-fwrapv -fno-strict-aliasing -pipe
-fstack-protector-strong -I/usr/local/include'
ccversion=''
gccversion='5.4.1 20160904'
gccosandvers=''
intsize=4
longsize=8
ptrsize=8
doublesize=8
byteorder=12345678
doublekind=3
d_longlong=define
longlongsize=8
d_longdbl=define
longdblsize=16
longdblkind=3
ivtype='long'
ivsize=8
nvtype='double'
nvsize=8
Off_t='off_t'
lseeksize=8
alignbytes=8
prototype=define
Linker and Libraries​:
ld='cc'
ldflags =' -fstack-protector-strong -L/usr/local/lib'
libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/5/include-fixed
/usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib
/usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /lib64 /usr/lib64
libs=-lpthread -lnsl -ldb -ldl -lm -lcrypt -lutil -lc
perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
libc=libc-2.23.so
so=so
useshrplib=false
libperl=libperl.a
gnulibc_version='2.23'
Dynamic Linking​:
dlsrc=dl_dlopen.xs
dlext=so
d_dlsymun=undef
ccdlflags='-Wl,-E'
cccdlflags='-fPIC'
lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
Compile-time options​:
HAS_TIMES
PERLIO_LAYERS
PERL_COPY_ON_WRITE
PERL_DONT_CREATE_GVSV
PERL_MALLOC_WRAP
PERL_OP_PARENT
PERL_PRESERVE_IVUV
PERL_USE_DEVEL
USE_64_BIT_ALL
USE_64_BIT_INT
USE_LARGE_FILES
USE_LOCALE
USE_LOCALE_COLLATE
USE_LOCALE_CTYPE
USE_LOCALE_NUMERIC
USE_LOCALE_TIME
USE_PERLIO
USE_PERL_ATOF
Built under linux
Compiled at Nov 21 2017 18​:24​:22
%ENV​:
PERL2DIR="/home/jkeenan/gitwork/perl2"
PERLBREW_BASHRC_VERSION="0.78"
PERLBREW_HOME="/home/jkeenan/.perlbrew"
PERLBREW_MANPATH="/home/jkeenan/perl5/perlbrew/perls/perl-5.26.0/man"

PERLBREW_PATH="/home/jkeenan/perl5/perlbrew/bin​:/home/jkeenan/perl5/perlbrew/perls/perl-5.26.0/bin"
PERLBREW_PERL="perl-5.26.0"
PERLBREW_ROOT="/home/jkeenan/perl5/perlbrew"
PERLBREW_VERSION="0.78"
PERL_WORKDIR="/home/jkeenan/gitwork/perl"
@​INC​:
lib
/home/jkeenan/testing/blead/lib/perl5/site_perl/5.27.7/x86_64-linux
/home/jkeenan/testing/blead/lib/perl5/site_perl/5.27.7
/home/jkeenan/testing/blead/lib/perl5/5.27.7/x86_64-linux
/home/jkeenan/testing/blead/lib/perl5/5.27.7

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Nov 22, 2017

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Nov 22, 2017

From @iabyn

On Tue, Nov 21, 2017 at 06​:40​:46PM -0800, James E Keenan wrote​:

CPAN module App​::perlbrew is broken in blead. The breakage, which
occurred this month, started somewhere *after*
b3937e2^ and at or before
a1c09da.

To save people looking, that's 177 commits in the range
  v5.27.5-181-gb3937e2
to v5.27.5-357-ga1c09da

--
Red sky at night - gerroff my land!
Red sky at morning - gerroff my land!
  -- old farmers' sayings #14

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Nov 22, 2017

From @atoomic

Thanks, James & Dave, after a git bisect on my side it appears that it comes from commit d964025
can you confirm that you are viewing the same offending commit?

___
Bisecting​: 87 revisions left to test after this (roughly 7 steps)
[2ac5cb3] Bump version of B/O.pm to 1.03

p5h/perl5demo@d964025

...

d964025 is the first bad commit
commit d964025
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Sun Oct 29 11​:21​:45 2017 -0700

  Revert "Temporarily revert CV-in-stash optimisation"

  This reverts commit 6eed25e.

:100644 100644 c61bfd08deb1ff7fc5f0795f180adebd635862c0 368f9b146e6284750fa9949a77a88d26e76c2a74 M op.c
:040000 040000 c3bc134118d6dfd1e02aaf2106045d59bc65ed60 4f56c0f0c1873c14139cfdc0d2dc95e219aabda2 M t

On Wed, 22 Nov 2017 03​:34​:24 -0800, davem wrote​:

On Tue, Nov 21, 2017 at 06​:40​:46PM -0800, James E Keenan wrote​:

CPAN module App​::perlbrew is broken in blead. The breakage, which
occurred this month, started somewhere *after*
b3937e2^ and at or before
a1c09da.

To save people looking, that's 177 commits in the range
v5.27.5-181-gb3937e2
to v5.27.5-357-ga1c09da

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Nov 22, 2017

From @atoomic

The App​::perlbrew code is expecting that any stash entry points to a GV, whereas now since 5.27.ish it can be a simple CV...
The code from App​::perlbrew​::commands sub needs some easy tweak.

I suspect that this might not be the only module expecting a GV for a stash entry...
We will probably discover more Modules over time that need similar patch.

I've submitted upstream ( App​::perlbrew repo a fix for it)
gugod/App-perlbrew#581

I think we should close this ticket as this an upstream issue.

thanks
nicolas

On Wed, 22 Nov 2017 08​:10​:24 -0800, atoomic@​cpan.org wrote​:

Thanks, James & Dave, after a git bisect on my side it appears that it
comes from commit d964025
can you confirm that you are viewing the same offending commit?

___
Bisecting​: 87 revisions left to test after this (roughly 7 steps)
[2ac5cb3] Bump version of B/O.pm to
1.03

p5h/perl5demo@d964025

...

d964025 is the first bad commit
commit d964025
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Sun Oct 29 11​:21​:45 2017 -0700

Revert "Temporarily revert CV-in-stash optimisation"

This reverts commit 6eed25e.

:100644 100644 c61bfd08deb1ff7fc5f0795f180adebd635862c0
368f9b146e6284750fa9949a77a88d26e76c2a74 M op.c
:040000 040000 c3bc134118d6dfd1e02aaf2106045d59bc65ed60
4f56c0f0c1873c14139cfdc0d2dc95e219aabda2 M t

On Wed, 22 Nov 2017 03​:34​:24 -0800, davem wrote​:

On Tue, Nov 21, 2017 at 06​:40​:46PM -0800, James E Keenan wrote​:

CPAN module App​::perlbrew is broken in blead. The breakage, which
occurred this month, started somewhere *after*
b3937e2^ and at or before
a1c09da.

To save people looking, that's 177 commits in the range
v5.27.5-181-gb3937e2
to v5.27.5-357-ga1c09da

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Nov 22, 2017

From @jkeenan

On Wed, 22 Nov 2017 17​:00​:24 GMT, atoomic@​cpan.org wrote​:

The App​::perlbrew code is expecting that any stash entry points to a
GV, whereas now since 5.27.ish it can be a simple CV...
The code from App​::perlbrew​::commands sub needs some easy tweak.

I suspect that this might not be the only module expecting a GV for a
stash entry...
We will probably discover more Modules over time that need similar
patch.

I've submitted upstream ( App​::perlbrew repo a fix for it)
gugod/App-perlbrew#581

I think we should close this ticket as this an upstream issue.

thanks
nicolas

On Wed, 22 Nov 2017 08​:10​:24 -0800, atoomic@​cpan.org wrote​:

Thanks, James & Dave, after a git bisect on my side it appears that
it
comes from commit d964025
can you confirm that you are viewing the same offending commit?

___
Bisecting​: 87 revisions left to test after this (roughly 7 steps)
[2ac5cb3] Bump version of B/O.pm to
1.03

p5h/perl5demo@d964025

...

d964025 is the first bad commit
commit d964025
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Sun Oct 29 11​:21​:45 2017 -0700

Revert "Temporarily revert CV-in-stash optimisation"

This reverts commit 6eed25e.

:100644 100644 c61bfd08deb1ff7fc5f0795f180adebd635862c0
368f9b146e6284750fa9949a77a88d26e76c2a74 M op.c
:040000 040000 c3bc134118d6dfd1e02aaf2106045d59bc65ed60
4f56c0f0c1873c14139cfdc0d2dc95e219aabda2 M t

On Wed, 22 Nov 2017 03​:34​:24 -0800, davem wrote​:

On Tue, Nov 21, 2017 at 06​:40​:46PM -0800, James E Keenan wrote​:

CPAN module App​::perlbrew is broken in blead. The breakage,
which
occurred this month, started somewhere *after*
b3937e2^ and at or before
a1c09da.

To save people looking, that's 177 commits in the range
v5.27.5-181-gb3937e2
to v5.27.5-357-ga1c09da

Nicolas, Dave M, thanks for that analysis. I'm reluctant to close this ticket at this time because I suspect that the number of CPAN distros that will have to modify their code to accommodate this change will be significant. I have confirmed that MOP is now failing against blead, as is QBit-WebInterface (though that is obscured by absence of an upstream C library).

While I don't think that the amount of repair work to be done on CPAN will be as great as, say, that needed for no-dot-in-@​INC in perl-5.26.0, that work will still be significant.

I wonder whether the commit(s) which triggered these failures was absolutely necessary -- but I don't claim to understand those issues well enough.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Nov 22, 2017

From @cpansprout

On Wed, 22 Nov 2017 09​:44​:45 -0800, jkeenan wrote​:

Nicolas, Dave M, thanks for that analysis. I'm reluctant to close
this ticket at this time because I suspect that the number of CPAN
distros that will have to modify their code to accommodate this change
will be significant.

But we already have #132252 to cover this issue. Tracking it in two separate tickets is just going to be confusing.

--

Father Chrysostomos

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Apr 19, 2018

From @iabyn

On Wed, Nov 22, 2017 at 10​:07​:11AM -0800, Father Chrysostomos via RT wrote​:

On Wed, 22 Nov 2017 09​:44​:45 -0800, jkeenan wrote​:

Nicolas, Dave M, thanks for that analysis. I'm reluctant to close
this ticket at this time because I suspect that the number of CPAN
distros that will have to modify their code to accommodate this change
will be significant.

But we already have #132252 to cover this issue. Tracking it in two
separate tickets is just going to be confusing.

Closing.

--
Counsellor Troi states something other than the blindingly obvious.
  -- Things That Never Happen in "Star Trek" #16

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Apr 20, 2018

@iabyn - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant