Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New build warning in locale.c #16355

Closed
p5pRT opened this issue Jan 9, 2018 · 10 comments
Closed

New build warning in locale.c #16355

p5pRT opened this issue Jan 9, 2018 · 10 comments

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Jan 9, 2018

Migrated from rt.perl.org#132701 (status was 'resolved')

Searchable as RT132701$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 9, 2018

From @dur-randir

Created by @dur-randir

Recent commit b09aaf4
Author​: Karl Williamson <khw@​cpan.org>
Date​: Sun Dec 31 07​:53​:32 2017 -0700

  locale.c​: Improve debugging output

  This extracts some debugging output code into a function (so that it can
  be called from more than one place) and add some detail to the output.

Introduced new build warning on non-debugging builds​:

cc -c -DPERL_CORE -fno-common -DPERL_DARWIN -mmacosx-version-min=10.9
-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include
-DPERL_USE_SAFE_PUTENV -std=c89 -O3 -Wall
-Werror=declaration-after-statement -Werror=pointer-arith -Wextra
-Wc++-compat -Wwrite-strings locale.c
locale.c​:205​:1​: warning​: unused function 'S_category_name' [-Wunused-function]
S_category_name(const int category)
^

Perl Info

Flags:
    category=core
    severity=low

Site configuration information for perl 5.27.7:

Configured by dur-randir at Fri Dec  1 17:01:46 MSK 2017.

Summary of my perl5 (revision 5 version 27 subversion 7) configuration:
  Commit id: 3c67ad9b9e6d659feb76f3acfc9f81cfe59e3660
  Platform:
    osname=darwin
    osvers=13.4.0
    archname=darwin-2level
    uname='darwin isengard.local 13.4.0 darwin kernel version 13.4.0:
mon jan 11 18:17:34 pst 2016; root:xnu-2422.115.15~1release_x86_64
x86_64 '
    config_args='-de -Dusedevel -DDEBUGGING'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=undef
    usemultiplicity=undef
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
    bincompat5005=undef
  Compiler:
    cc='cc'
    ccflags ='-fno-common -DPERL_DARWIN -mmacosx-version-min=10.9
-DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector
-I/usr/local/include -DPERL_USE_SAFE_PUTENV'
    optimize='-O3 -g'
    cppflags='-fno-common -DPERL_DARWIN -mmacosx-version-min=10.9
-DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector
-I/usr/local/include'
    ccversion=''
    gccversion='4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.56)'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags =' -mmacosx-version-min=10.9 -fstack-protector -L/usr/local/lib'
    libpth=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/6.0/lib
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/lib
/usr/local/lib /usr/lib
    libs=-lpthread -lgdbm -ldbm -ldl -lm -lutil -lc
    perllibs=-lpthread -ldl -lm -lutil -lc
    libc=
    so=dylib
    useshrplib=false
    libperl=libperl.a
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=bundle
    d_dlsymun=undef
    ccdlflags=' '
    cccdlflags=' '
    lddlflags=' -mmacosx-version-min=10.9 -bundle -undefined
dynamic_lookup -L/usr/local/lib -fstack-protector'



@INC for perl 5.27.7:
    lib
    /usr/local/lib/perl5/site_perl/5.27.7/darwin-2level
    /usr/local/lib/perl5/site_perl/5.27.7
    /usr/local/lib/perl5/5.27.7/darwin-2level
    /usr/local/lib/perl5/5.27.7


Environment for perl 5.27.7:
    DYLD_LIBRARY_PATH (unset)
    HOME=/Users/dur-randir
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/Users/dur-randir/perlbrew/bin:/Users/dur-randir/perlbrew/perls/perl-5.22.1/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/texbin
    PERLBREW_BASHRC_VERSION=0.78
    PERLBREW_HOME=/Users/dur-randir/.perlbrew
    PERLBREW_MANPATH=/Users/dur-randir/perlbrew/perls/perl-5.22.1/man
    PERLBREW_PATH=/Users/dur-randir/perlbrew/bin:/Users/dur-randir/perlbrew/perls/perl-5.22.1/bin
    PERLBREW_PERL=perl-5.22.1
    PERLBREW_ROOT=/Users/dur-randir/perlbrew
    PERLBREW_VERSION=0.78
    PERL_BADLANG (unset)
    SHELL=/usr/local/bin/zsh

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 9, 2018

From @khwilliamson

On 01/09/2018 12​:22 PM, Sergey Aleynikov (via RT) wrote​:

# New Ticket Created by Sergey Aleynikov
# Please include the string​: [perl #132701]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=132701 >

This is a bug report for perl from sergey.aleynikov@​gmail.com,
generated with the help of perlbug 1.41 running under perl 5.27.7.

-----------------------------------------------------------------
[Please describe your issue here]

Recent commit b09aaf4
Author​: Karl Williamson <khw@​cpan.org>
Date​: Sun Dec 31 07​:53​:32 2017 -0700

 locale\.c&#8203;: Improve debugging output

 This extracts some debugging output code into a function \(so that it can
 be called from more than one place\) and add some detail to the output\.

Introduced new build warning on non-debugging builds​:

cc -c -DPERL_CORE -fno-common -DPERL_DARWIN -mmacosx-version-min=10.9
-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include
-DPERL_USE_SAFE_PUTENV -std=c89 -O3 -Wall
-Werror=declaration-after-statement -Werror=pointer-arith -Wextra
-Wc++-compat -Wwrite-strings locale.c
locale.c​:205​:1​: warning​: unused function 'S_category_name' [-Wunused-function]
S_category_name(const int category)
^

This will go away with future commits in the pipeline

[Please do not change anything below this line]
-----------------------------------------------------------------
---
Flags​:
category=core
severity=low
---
Site configuration information for perl 5.27.7​:

Configured by dur-randir at Fri Dec 1 17​:01​:46 MSK 2017.

Summary of my perl5 (revision 5 version 27 subversion 7) configuration​:
Commit id​: 3c67ad9
Platform​:
osname=darwin
osvers=13.4.0
archname=darwin-2level
uname='darwin isengard.local 13.4.0 darwin kernel version 13.4.0​:
mon jan 11 18​:17​:34 pst 2016; root​:xnu-2422.115.15~1release_x86_64
x86_64 '
config_args='-de -Dusedevel -DDEBUGGING'
hint=recommended
useposix=true
d_sigaction=define
useithreads=undef
usemultiplicity=undef
use64bitint=define
use64bitall=define
uselongdouble=undef
usemymalloc=n
default_inc_excludes_dot=define
bincompat5005=undef
Compiler​:
cc='cc'
ccflags ='-fno-common -DPERL_DARWIN -mmacosx-version-min=10.9
-DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector
-I/usr/local/include -DPERL_USE_SAFE_PUTENV'
optimize='-O3 -g'
cppflags='-fno-common -DPERL_DARWIN -mmacosx-version-min=10.9
-DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector
-I/usr/local/include'
ccversion=''
gccversion='4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.56)'
gccosandvers=''
intsize=4
longsize=8
ptrsize=8
doublesize=8
byteorder=12345678
doublekind=3
d_longlong=define
longlongsize=8
d_longdbl=define
longdblsize=16
longdblkind=3
ivtype='long'
ivsize=8
nvtype='double'
nvsize=8
Off_t='off_t'
lseeksize=8
alignbytes=8
prototype=define
Linker and Libraries​:
ld='cc'
ldflags =' -mmacosx-version-min=10.9 -fstack-protector -L/usr/local/lib'
libpth=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/6.0/lib
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/lib
/usr/local/lib /usr/lib
libs=-lpthread -lgdbm -ldbm -ldl -lm -lutil -lc
perllibs=-lpthread -ldl -lm -lutil -lc
libc=
so=dylib
useshrplib=false
libperl=libperl.a
gnulibc_version=''
Dynamic Linking​:
dlsrc=dl_dlopen.xs
dlext=bundle
d_dlsymun=undef
ccdlflags=' '
cccdlflags=' '
lddlflags=' -mmacosx-version-min=10.9 -bundle -undefined
dynamic_lookup -L/usr/local/lib -fstack-protector'

---
@​INC for perl 5.27.7​:
lib
/usr/local/lib/perl5/site_perl/5.27.7/darwin-2level
/usr/local/lib/perl5/site_perl/5.27.7
/usr/local/lib/perl5/5.27.7/darwin-2level
/usr/local/lib/perl5/5.27.7

---
Environment for perl 5.27.7​:
DYLD_LIBRARY_PATH (unset)
HOME=/Users/dur-randir
LANG=en_US.UTF-8
LANGUAGE (unset)
LD_LIBRARY_PATH (unset)
LOGDIR (unset)
PATH=/Users/dur-randir/perlbrew/bin​:/Users/dur-randir/perlbrew/perls/perl-5.22.1/bin​:/usr/local/bin​:/usr/local/sbin​:/usr/bin​:/bin​:/usr/sbin​:/sbin​:/usr/texbin
PERLBREW_BASHRC_VERSION=0.78
PERLBREW_HOME=/Users/dur-randir/.perlbrew
PERLBREW_MANPATH=/Users/dur-randir/perlbrew/perls/perl-5.22.1/man
PERLBREW_PATH=/Users/dur-randir/perlbrew/bin​:/Users/dur-randir/perlbrew/perls/perl-5.22.1/bin
PERLBREW_PERL=perl-5.22.1
PERLBREW_ROOT=/Users/dur-randir/perlbrew
PERLBREW_VERSION=0.78
PERL_BADLANG (unset)
SHELL=/usr/local/bin/zsh

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 9, 2018

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 31, 2018

From @khwilliamson

I believe this is fixed now in blead. Please confirm
--
Karl Williamson

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 31, 2018

From @dur-randir

On Tue, 30 Jan 2018 21​:59​:02 -0800, khw wrote​:

I believe this is fixed now in blead. Please confirm

The old one is gone, the new one is

locale.c​:3680​:37​: warning​: format specifies type 'unsigned int' but the argument has type 'unsigned long' [-Wformat]
  PL_locale_utf8ness, strlen(PL_locale_utf8ness),
  ^~~~~~~~~~~~~~~~~~~~~~~~~~
locale.c​:3681​:28​: warning​: format specifies type 'unsigned int' but the argument has type 'size_t' (aka 'unsigned long') [-Wformat]
  delimited, input_name_len_with_overhead);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 31, 2018

From @jkeenan

On Wed, 31 Jan 2018 05​:59​:02 GMT, khw wrote​:

I believe this is fixed now in blead. Please confirm

'make' is now running warnings-free for me in my customary configurations on both Linux and FreeBSD-11.0. Thanks.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 31, 2018

From @khwilliamson

On 01/31/2018 12​:23 AM, Sergey Aleynikov via RT wrote​:

On Tue, 30 Jan 2018 21​:59​:02 -0800, khw wrote​:

I believe this is fixed now in blead. Please confirm

The old one is gone, the new one is

locale.c​:3680​:37​: warning​: format specifies type 'unsigned int' but the argument has type 'unsigned long' [-Wformat]
PL_locale_utf8ness, strlen(PL_locale_utf8ness),
^~~~~~~~~~~~~~~~~~~~~~~~~~
locale.c​:3681​:28​: warning​: format specifies type 'unsigned int' but the argument has type 'size_t' (aka 'unsigned long') [-Wformat]
delimited, input_name_len_with_overhead);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~

---
via perlbug​: queue​: perl5 status​: open
https://rt-archive.perl.org/perl5/Ticket/Display.html?id=132701

This should be fixed by 7fcf927

Please verify

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 31, 2018

From @dur-randir

On Wed, 31 Jan 2018 06​:03​:08 -0800, public@​khwilliamson.com wrote​:

This should be fixed by 7fcf927

Fixed, thanks.

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 31, 2018

From @khwilliamson

OP says now fixed
--
Karl Williamson

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 31, 2018

@khwilliamson - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant