Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBC Class::MethodMaker broken by 6661956a23de82b41adc406200054293d6d7aded #16363

Closed
p5pRT opened this issue Jan 16, 2018 · 6 comments
Closed

BBC Class::MethodMaker broken by 6661956a23de82b41adc406200054293d6d7aded #16363

p5pRT opened this issue Jan 16, 2018 · 6 comments

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Jan 16, 2018

Migrated from rt.perl.org#132727 (status was 'resolved')

Searchable as RT132727$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 16, 2018

From zefram@fysh.org

Created by zefram@fysh.org

The recent commit 6661956, creating
array elements in some situations that used to be too lazy, has been
observed to cause test failures for Class​::MethodMaker and Devel​::Size.
Early impressions are that Class​::MethodMaker is written in a fragile
manner, and that Devel​::Size doesn't really mind what the behaviour is
but explicitly tests the old behaviour.

The commit fixes bugs. We most likely don't want to revert it for this
level of breakage. The focus should be on fixing/updating the affected
modules.

Perl Info

Flags:
    category=core
    severity=low

Site configuration information for perl 5.27.8:

Configured by zefram at Tue Jan 16 10:59:14 GMT 2018.

Summary of my perl5 (revision 5 version 27 subversion 8) configuration:
  Derived from: db792da6c0161e671ca54420a1a6e98bf73ca161
  Platform:
    osname=linux
    osvers=3.16.0-4-amd64
    archname=x86_64-linux-thread-multi
    uname='linux barba.rous.org 3.16.0-4-amd64 #1 smp debian 3.16.43-2+deb8u2 (2017-06-26) x86_64 gnulinux '
    config_args='-des -Dprefix=/home/zefram/usr/perl/perl_install/perl-git-blead-i64-f52 -Duselargefiles -Dusethreads -Uafs -Ud_csh -Uusesfio -Uusenm -Duseshrplib -Dusedevel -Uversiononly -Ui_db -DDEBUGGING'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=define
    usemultiplicity=define
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
    bincompat5005=undef
  Compiler:
    cc='cc'
    ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
    optimize='-O2 -g'
    cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
    ccversion=''
    gccversion='4.9.2'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags =' -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.9/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
    libs=-lpthread -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
    perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    libc=libc-2.19.so
    so=so
    useshrplib=true
    libperl=libperl.so
    gnulibc_version='2.19'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=so
    d_dlsymun=undef
    ccdlflags='-Wl,-E -Wl,-rpath,/home/zefram/usr/perl/perl_install/perl-git-blead-i64-f52/lib/5.27.8/x86_64-linux-thread-multi/CORE'
    cccdlflags='-fPIC'
    lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector-strong'



@INC for perl 5.27.8:
    /home/zefram/usr/perl/pg/lib
    /home/zefram/usr/perl/perl_install/perl-git-blead-i64-f52/lib/site_perl/5.27.8/x86_64-linux-thread-multi
    /home/zefram/usr/perl/perl_install/perl-git-blead-i64-f52/lib/site_perl/5.27.8
    /home/zefram/usr/perl/perl_install/perl-git-blead-i64-f52/lib/5.27.8/x86_64-linux-thread-multi
    /home/zefram/usr/perl/perl_install/perl-git-blead-i64-f52/lib/5.27.8
    /home/zefram/usr/perl/perl_install/perl-git-blead-i64-f52/lib/site_perl/5.27.7
    /home/zefram/usr/perl/perl_install/perl-git-blead-i64-f52/lib/site_perl


Environment for perl 5.27.8:
    HOME=/home/zefram
    LANG (unset)
    LANGUAGE (unset)
    LD_LIBRARY_PATH=/home/zefram/usr/perl/pg
    LOGDIR (unset)
    PATH=/home/zefram/usr/perl/util:/home/zefram/pub/x86_64-unknown-linux-gnu/bin:/home/zefram/pub/common/bin:/usr/bin:/bin:/usr/local/bin:/usr/games
    PERL5LIB=/home/zefram/usr/perl/pg/lib
    PERLDOC=-oman
    PERL_BADLANG (unset)
    SHELL=/usr/bin/zsh

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 16, 2018

From zefram@fysh.org

I have opened [rt.cpan.org #124104] regarding Class-MethodMaker and
[rt.cpan.org #124105] regarding Devel-Size.

-zefram

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Apr 20, 2018

From @iabyn

On Tue, Jan 16, 2018 at 07​:15​:07PM +0000, Zefram wrote​:

I have opened [rt.cpan.org #124104] regarding Class-MethodMaker and
[rt.cpan.org #124105] regarding Devel-Size.

Class-MethodMaker passes with blead,
and the ticket for Devel-Size was last updated Mar 30, making it clear
(I think) what needs fixing in Devel-Size, so I don't think this
ticket should be a 5.28 blocker any more.

--
I before E. Except when it isn't.

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Apr 20, 2018

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Apr 20, 2018

From @arc

I'm marking this ticket resolved, so it will stop blocking 5.28.

--
Aaron Crane

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Apr 20, 2018

@arc - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant