Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apparent typo in script_run docs #16375

Closed
p5pRT opened this issue Jan 20, 2018 · 5 comments
Closed

Apparent typo in script_run docs #16375

p5pRT opened this issue Jan 20, 2018 · 5 comments

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Jan 20, 2018

Migrated from rt.perl.org#132748 (status was 'resolved')

Searchable as RT132748$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 20, 2018

From @trwyant

Created by @trwyant

The documentation for the new regex (+script_run​:...) experimental
feature appears to contain typos in a couple places. At least,

  qr/(?script_run​: \d+ \b )/x

which appears in pod/perl5278delta.pod and pod/perlre.pod, fails to
compile. Should this be (+script_run​:...), as in the other examples in
perlre.pod?

I intend to attach a patch file, derived from commit
3093cd0, which was blead at the time I
cloned the repository.

Perl Info

Flags:
    category=docs
    severity=low

Site configuration information for perl 5.27.8:

Configured by tom at Sat Jan 20 10:56:58 EST 2018.

Summary of my perl5 (revision 5 version 27 subversion 8) configuration:
   
  Platform:
    osname=darwin
    osvers=17.3.0
    archname=darwin-2level
    uname='darwin samwise.local 17.3.0 darwin kernel version 17.3.0: thu nov 9 18:09:22 pst 2017; root:xnu-4570.31.3~1release_x86_64 x86_64 '
    config_args='-Dprefix=/trw/local/perl/5.27.8 -Dcf_email=wyant@cpan.org -d -Dusedevel -Uversiononly'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=undef
    usemultiplicity=undef
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
    bincompat5005=undef
  Compiler:
    cc='cc'
    ccflags ='-fno-common -DPERL_DARWIN -mmacosx-version-min=10.13 -fno-strict-aliasing -pipe -fstack-protector-strong -I/opt/local/include -DPERL_USE_SAFE_PUTENV'
    optimize='-O3'
    cppflags='-fno-common -DPERL_DARWIN -mmacosx-version-min=10.13 -fno-strict-aliasing -pipe -fstack-protector-strong -I/opt/local/include'
    ccversion=''
    gccversion='4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags =' -mmacosx-version-min=10.13 -fstack-protector-strong -L/opt/local/lib'
    libpth=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/9.0.0/lib /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib /usr/lib /opt/local/lib
    libs=-lpthread -lgdbm -ldbm -ldl -lm -lutil -lc
    perllibs=-lpthread -ldl -lm -lutil -lc
    libc=
    so=dylib
    useshrplib=false
    libperl=libperl.a
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=bundle
    d_dlsymun=undef
    ccdlflags=' '
    cccdlflags=' '
    lddlflags=' -mmacosx-version-min=10.13 -bundle -undefined dynamic_lookup -L/opt/local/lib -fstack-protector-strong'



@INC for perl 5.27.8:
    /trw/local/perl/5.27.8/lib/site_perl/5.27.8/darwin-2level
    /trw/local/perl/5.27.8/lib/site_perl/5.27.8
    /trw/local/perl/5.27.8/lib/5.27.8/darwin-2level
    /trw/local/perl/5.27.8/lib/5.27.8


Environment for perl 5.27.8:
    DYLD_LIBRARY_PATH (unset)
    HOME=/Users/tom
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/trw/local/perl/5.27.8/bin:/trw/local/lynx/2.8.8-with-ssl/bin:/trw/local/perl6/2015.12/bin:/trw/local/perl6/2015.12/share/perl6/site/bin:/trw/local/simh/3.9-0/bin:/opt/local/bin:/opt/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/Users/tom/Code/Tools
    PERLDOC=-oMan
    PERLPKGOPT=-noppm
    PERL_BADLANG (unset)
    SHELL=/bin/bash

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 20, 2018

From @trwyant

perlbug.patch
diff --git a/pod/perl5278delta.pod b/pod/perl5278delta.pod
index 501e8b2cb3..f9f51aa185 100644
--- a/pod/perl5278delta.pod
+++ b/pod/perl5278delta.pod
@@ -33,7 +33,7 @@ A mixture of scripts, such as Cyrillic and Latin, in a string is often
 the sign of a spoofing attack.  A new regular expression construct
 now allows for easy detection of these.  For example, you can say
 
- qr/(?script_run: \d+ \b )/x
+ qr/(+script_run: \d+ \b )/x
 
 And the digits matched will all be from the same set of 10.  You won't
 get a look-alike digit from a different script that has a different
diff --git a/pod/perlre.pod b/pod/perlre.pod
index 993a08ede8..74f44fedc3 100644
--- a/pod/perlre.pod
+++ b/pod/perlre.pod
@@ -2470,7 +2470,7 @@ own set.  This is because these are often used in commerce even in such
 scripts.  But any mixing of the ASCII and other digits will cause the
 sequence to not be a script run, failing the match.  As an example,
 
- qr/(?script_run: \d+ \b )/x
+ qr/(+script_run: \d+ \b )/x
 
 guarantees that the digits matched will all be from the same set of 10.
 You won't get a look-alike digit from a different script that has a

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 20, 2018

@khwilliamson - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 20, 2018

From @khwilliamson

Thanks

Applied as 85a8548

--
Karl Williamson

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 20, 2018

@khwilliamson - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant