Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blead Breaks CPAN: GRAY/POSIX-RT-Spawn-0.11.tar.gz #16390

Closed
p5pRT opened this issue Jan 28, 2018 · 17 comments
Closed

Blead Breaks CPAN: GRAY/POSIX-RT-Spawn-0.11.tar.gz #16390

p5pRT opened this issue Jan 28, 2018 · 17 comments
Labels
BBC

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Jan 28, 2018

Migrated from rt.perl.org#132777 (status was 'open')

Searchable as RT132777$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 28, 2018

From @eserte

This is a bug report for perl from slaven@​rezic.de,
generated with the help of perlbug 1.41 running under perl 5.27.8.


POSIX-RT-Spawn-0.11 does not compile anymore with 5.27.7 and 5.27.8
(sorry, again, no bisect available).

A sample build report​:
http​://www.cpantesters.org/cpan/report/3cd59972-02d2-11e8-9e00-9d8022978595

It seems that PL_Argv and PL_Cmd are not available anymore, but I did
not find a matching entry in perl5.27.7's perldelta.



Flags​:
  category=core
  severity=low


Site configuration information for perl 5.27.8​:

Configured by eserte at Sat Jan 20 09​:22​:10 CET 2018.

Summary of my perl5 (revision 5 version 27 subversion 8) configuration​:
 
  Platform​:
  osname=linux
  osvers=3.16.0-4-amd64
  archname=x86_64-linux
  uname='linux cabulja 3.16.0-4-amd64 #1 smp debian 3.16.51-3 (2017-12-13) x86_64 gnulinux '
  config_args='-ds -e -Dprefix=/opt/perl-5.27.8 -Dusedevel -Dusemallocwrap=no -Dcf_email=srezic@​cpan.org'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=undef
  usemultiplicity=undef
  use64bitint=define
  use64bitall=define
  uselongdouble=undef
  usemymalloc=n
  default_inc_excludes_dot=define
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
  optimize='-O2'
  cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='4.9.2'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='double'
  nvsize=8
  Off_t='off_t'
  lseeksize=8
  alignbytes=8
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.9/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lpthread -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.19.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.19'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'


@​INC for perl 5.27.8​:
  /opt/perl-5.27.8/lib/site_perl/5.27.8/x86_64-linux
  /opt/perl-5.27.8/lib/site_perl/5.27.8
  /opt/perl-5.27.8/lib/5.27.8/x86_64-linux
  /opt/perl-5.27.8/lib/5.27.8


Environment for perl 5.27.8​:
  HOME=/home/eserte
  LANG=en_US.UTF-8
  LANGUAGE (unset)
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=/usr/local/bin​:/usr/bin​:/bin​:/usr/local/sbin​:/usr/sbin​:/sbin​:/home/eserte/bin/linux-gnu​:/home/eserte/bin/sh​:/home/eserte/bin​:/home/eserte/bin/pistachio-perl/bin​:/usr/games​:/home/eserte/devel
  PERLDOC=-MPod​::Perldoc​::ToTextOverstrike
  PERL_BADLANG (unset)
  SHELL=/bin/zsh

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 28, 2018

From zefram@fysh.org

slaven@​rezic.de wrote​:

It seems that PL_Argv and PL_Cmd are not available anymore, but I did
not find a matching entry in perl5.27.7's perldelta.

Removed in commit 282fc0b. They weren't
specifically mentioned in perldelta because they were never part of the
public API.

POSIX-RT-Spawn has no more need for these globals than the core did.
It would be improved by making changes similar to those made to the core
in the cited commit, to manage this memory via the save stack.

-zefram

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 28, 2018

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 30, 2018

From @Leont

On Sun, Jan 28, 2018 at 2​:17 PM, Zefram <zefram@​fysh.org> wrote​:

Removed in commit 282fc0b. They weren't
specifically mentioned in perldelta because they were never part of the
public API.

We currently have 323 interpreter variables and AFAIK more than a
hundred true globals. Only 28 of them are listed in the perlapi.

I would hope we intend to support more than that.

Leon

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 4, 2018

From @Leont

On Tue, Jan 30, 2018 at 11​:00 PM, Leon Timmermans <fawaka@​gmail.com> wrote​:

On Sun, Jan 28, 2018 at 2​:17 PM, Zefram <zefram@​fysh.org> wrote​:

Removed in commit 282fc0b. They weren't
specifically mentioned in perldelta because they were never part of the
public API.

We currently have 323 interpreter variables and AFAIK more than a
hundred true globals. Only 28 of them are listed in the perlapi.

Actually my regex was wrong, only 14 are defined (the others were only
mentioned), 5 of those are explicitly marked as experimental.

Leon

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Apr 20, 2018

From @iabyn

On Sun, Feb 04, 2018 at 11​:57​:57AM +0100, Leon Timmermans wrote​:

On Tue, Jan 30, 2018 at 11​:00 PM, Leon Timmermans <fawaka@​gmail.com> wrote​:

On Sun, Jan 28, 2018 at 2​:17 PM, Zefram <zefram@​fysh.org> wrote​:

Removed in commit 282fc0b. They weren't
specifically mentioned in perldelta because they were never part of the
public API.

We currently have 323 interpreter variables and AFAIK more than a
hundred true globals. Only 28 of them are listed in the perlapi.

Actually my regex was wrong, only 14 are defined (the others were only
mentioned), 5 of those are explicitly marked as experimental.

Do you have any opinion as to whether more interpeter and globals vars
should be part of the API?

Anyway, since there hasn't been any other reported breakage from
removing these two vars, I intend to remove this ticket from the 5.28
blockers

--
Please note that ash-trays are provided for the use of smokers,
whereas the floor is provided for the use of all patrons.
  -- Bill Royston

@p5pRT
Copy link
Author

@p5pRT p5pRT commented May 2, 2018

From @Leont

On Fri, Apr 20, 2018 at 10​:19 AM, Dave Mitchell <davem@​iabyn.com> wrote​:

On Sun, Feb 04, 2018 at 11​:57​:57AM +0100, Leon Timmermans wrote​:

On Tue, Jan 30, 2018 at 11​:00 PM, Leon Timmermans <fawaka@​gmail.com> wrote​:

On Sun, Jan 28, 2018 at 2​:17 PM, Zefram <zefram@​fysh.org> wrote​:

Removed in commit 282fc0b. They weren't
specifically mentioned in perldelta because they were never part of the
public API.

We currently have 323 interpreter variables and AFAIK more than a
hundred true globals. Only 28 of them are listed in the perlapi.

Actually my regex was wrong, only 14 are defined (the others were only
mentioned), 5 of those are explicitly marked as experimental.

Do you have any opinion as to whether more interpeter and globals vars
should be part of the API?

I can't think of any reason not to make PL_curstash API, it's both
common, useful, simple, and highly unlikely to ever need change.
PL_curcop is also common and useful for fetching warnings bits, and
local hints. The latter even has some API defined, it just lacks an
blessed way to get that cop.
PL_defgv (and/or its wrappers) also seem useful and stable enough.

I can think of a few others (e.g. PL_defstash), but those three are
definitely on the top of my list.

Leon

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jun 23, 2018

From @eserte

Dana Sun, 28 Jan 2018 02​:01​:09 -0800, slaven@​rezic.de reče​:

This is a bug report for perl from slaven@​rezic.de,
generated with the help of perlbug 1.41 running under perl 5.27.8.

-----------------------------------------------------------------
POSIX-RT-Spawn-0.11 does not compile anymore with 5.27.7 and 5.27.8
(sorry, again, no bisect available).

A sample build report​:
http​://www.cpantesters.org/cpan/report/3cd59972-02d2-11e8-9e00-
9d8022978595

It seems that PL_Argv and PL_Cmd are not available anymore, but I did
not find a matching entry in perl5.27.7's perldelta.

-----------------------------------------------------------------
---
Flags​:
category=core
severity=low
---
Site configuration information for perl 5.27.8​:

Configured by eserte at Sat Jan 20 09​:22​:10 CET 2018.

Summary of my perl5 (revision 5 version 27 subversion 8)
configuration​:

Platform​:
osname=linux
osvers=3.16.0-4-amd64
archname=x86_64-linux
uname='linux cabulja 3.16.0-4-amd64 #1 smp debian 3.16.51-3 (2017-
12-13) x86_64 gnulinux '
config_args='-ds -e -Dprefix=/opt/perl-5.27.8 -Dusedevel
-Dusemallocwrap=no -Dcf_email=srezic@​cpan.org'
hint=recommended
useposix=true
d_sigaction=define
useithreads=undef
usemultiplicity=undef
use64bitint=define
use64bitall=define
uselongdouble=undef
usemymalloc=n
default_inc_excludes_dot=define
bincompat5005=undef
Compiler​:
cc='cc'
ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-
strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-D_FORTIFY_SOURCE=2'
optimize='-O2'
cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-
strong -I/usr/local/include'
ccversion=''
gccversion='4.9.2'
gccosandvers=''
intsize=4
longsize=8
ptrsize=8
doublesize=8
byteorder=12345678
doublekind=3
d_longlong=define
longlongsize=8
d_longdbl=define
longdblsize=16
longdblkind=3
ivtype='long'
ivsize=8
nvtype='double'
nvsize=8
Off_t='off_t'
lseeksize=8
alignbytes=8
prototype=define
Linker and Libraries​:
ld='cc'
ldflags =' -fstack-protector-strong -L/usr/local/lib'
libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.9/include-
fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu
/lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
libs=-lpthread -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc
-lgdbm_compat
perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
libc=libc-2.19.so
so=so
useshrplib=false
libperl=libperl.a
gnulibc_version='2.19'
Dynamic Linking​:
dlsrc=dl_dlopen.xs
dlext=so
d_dlsymun=undef
ccdlflags='-Wl,-E'
cccdlflags='-fPIC'
lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'

---
@​INC for perl 5.27.8​:
/opt/perl-5.27.8/lib/site_perl/5.27.8/x86_64-linux
/opt/perl-5.27.8/lib/site_perl/5.27.8
/opt/perl-5.27.8/lib/5.27.8/x86_64-linux
/opt/perl-5.27.8/lib/5.27.8

---
Environment for perl 5.27.8​:
HOME=/home/eserte
LANG=en_US.UTF-8
LANGUAGE (unset)
LD_LIBRARY_PATH (unset)
LOGDIR (unset)
PATH=/usr/local/bin​:/usr/bin​:/bin​:/usr/local/sbin​:/usr/sbin​:/sbin​:/home/eserte/bin/linux-
gnu​:/home/eserte/bin/sh​:/home/eserte/bin​:/home/eserte/bin/pistachio-
perl/bin​:/usr/games​:/home/eserte/devel
PERLDOC=-MPod​::Perldoc​::ToTextOverstrike
PERL_BADLANG (unset)
SHELL=/bin/zsh

-> https://rt.cpan.org/Ticket/Display.html?id=125666

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 31, 2019

From @tonycoz

On Wed, 02 May 2018 00​:09​:20 -0700, LeonT wrote​:

I can think of a few others (e.g. PL_defstash), but those three are
definitely on the top of my list.

Done as separate patches to directly connect the reasoning for each
variable to the documentation.

Attached as one file to avoid anyone having to deal with seven separate
patch files.

Tony

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jan 31, 2019

From @tonycoz

132777-document-some-intrpvars.patch
From 330fc8b194d27f19653af150c808f0a752d4d964 Mon Sep 17 00:00:00 2001
From: Tony Cook <tony@develop-help.com>
Date: Thu, 31 Jan 2019 13:37:44 +1100
Subject: (perl #132777) document PL_exit_flags

PL_exit_flags is referred to in perlembed, perldiag and two
perldeltas, so APIify and document it.
---
 intrpvar.h | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/intrpvar.h b/intrpvar.h
index fad1eaafbb..c96b6b18ac 100644
--- a/intrpvar.h
+++ b/intrpvar.h
@@ -257,6 +257,37 @@ PERLVAR(I, efloatsize,	STRLEN)
 PERLVARI(I, dumpindent,	U16,	4)	/* number of blanks per dump
 					   indentation level */
 
+/*
+=for apidoc Amn|U8|PL_exit_flags
+
+Contains flags controlling perl's behaviour on exit():
+
+=over
+
+=item * C<PERL_EXIT_DESTRUCT_END>
+
+If set, END blocks are executed when the interpreter is destroyed.
+This is normally set by perl itself after the interpreter is
+constructed.
+
+=item * C<PERL_EXIT_ABORT>
+
+Call C<abort()> on exit.  This is used internally by perl itself to
+abort if exit is called while processing exit.
+
+=item * C<PERL_EXIT_WARN>
+
+Warn on exit.
+
+=item * C<PERL_EXIT_EXPECTED>
+
+Set by the L<perlfunc/exit> operator.
+
+=back
+
+=cut
+*/
+
 PERLVAR(I, exit_flags,	U8)		/* was exit() unexpected, etc. */
 
 PERLVAR(I, utf8locale,	bool)		/* utf8 locale detected */
-- 
2.11.0


From bc9d47338a4c65934c099b1c7a001951089f882e Mon Sep 17 00:00:00 2001
From: Tony Cook <tony@develop-help.com>
Date: Thu, 31 Jan 2019 14:04:52 +1100
Subject: (perl #132777) document and add PL_curcop to the API

PL_curcop is used fairly widely on CPAN, mostly to get the current
line number and file, to check lexical hints, or to check the
stash.
---
 intrpvar.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/intrpvar.h b/intrpvar.h
index c96b6b18ac..c585d7af0a 100644
--- a/intrpvar.h
+++ b/intrpvar.h
@@ -122,6 +122,15 @@ PERLVARI(I, utf8cache, I8, PERL___I)	/* Is the utf8 caching code enabled? */
 PERLVAR(I, defstash,	HV *)		/* main symbol table */
 PERLVAR(I, curstash,	HV *)		/* symbol table for current package */
 
+/*
+=for apidoc Amn|COP*|PL_curcop
+
+The currently active COP (control op) roughly representing the current
+statement in the source.
+
+=cut
+*/
+
 PERLVAR(I, curcop,	COP *)
 PERLVAR(I, curstack,	AV *)		/* THE STACK */
 PERLVAR(I, curstackinfo, PERL_SI *)	/* current stack + context */
-- 
2.11.0


From 104d04c647308b8de2aa1847f06ff0bdf32ce31a Mon Sep 17 00:00:00 2001
From: Tony Cook <tony@develop-help.com>
Date: Thu, 31 Jan 2019 14:35:52 +1100
Subject: (perl #132777) APIify and document PL_curstash

per leont: I can't think of any reason not to make PL_curstash API,
it's both common, useful, simple, and highly unlikely to ever need
change.
---
 intrpvar.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/intrpvar.h b/intrpvar.h
index c585d7af0a..edececc4cf 100644
--- a/intrpvar.h
+++ b/intrpvar.h
@@ -117,6 +117,13 @@ PERLVAR(I, dowarn,	U8)
 PERLVARI(I, utf8cache, I8, PERL___I)	/* Is the utf8 caching code enabled? */
 #undef PERL___I
 
+/*
+=for apidoc Amn|HV*|PL_curstash
+
+The stash for the package code will be compiled into.
+
+=cut
+*/
 
 /* Stashes */
 PERLVAR(I, defstash,	HV *)		/* main symbol table */
-- 
2.11.0


From 74789673fac08098b107bab7410818b4b7fe6b98 Mon Sep 17 00:00:00 2001
From: Tony Cook <tony@develop-help.com>
Date: Thu, 31 Jan 2019 14:52:14 +1100
Subject: (perl #132777) document and APIify PL_defgv

This is used occasionally on CPAN, typically to access $_.
---
 intrpvar.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/intrpvar.h b/intrpvar.h
index edececc4cf..2fb3042578 100644
--- a/intrpvar.h
+++ b/intrpvar.h
@@ -93,6 +93,14 @@ PERLVARI(I, tainted,	bool, FALSE)	/* using variables controlled by $< */
  */
 PERLVAR(I, delaymagic,	U16)		/* ($<,$>) = ... */
 
+/*
+=for apidoc Amn|GV *|PL_defgv
+
+The GV representing C<*_>.  Useful for access to C<$_>.
+
+=cut
+*/
+
 PERLVAR(I, localizing,	U8)		/* are we processing a local() list? */
 PERLVAR(I, in_eval,	U8)		/* trap "fatal" errors? */
 PERLVAR(I, defgv,	GV *)           /* the *_ glob */
-- 
2.11.0


From 071c253d96806be6af1fc45a915aa2eafba1b666 Mon Sep 17 00:00:00 2001
From: Tony Cook <tony@develop-help.com>
Date: Thu, 31 Jan 2019 15:06:41 +1100
Subject: (perl #132777) document and APIify PL_parser

Used in a few places on CPAN, either to check or modify the
compilation error count, or to do a little parsing via bufptr.
---
 intrpvar.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/intrpvar.h b/intrpvar.h
index 2fb3042578..d2a54aca7d 100644
--- a/intrpvar.h
+++ b/intrpvar.h
@@ -206,6 +206,14 @@ PERLVAR(I, padname_undef,	PADNAME)
 PERLVAR(I, padname_const,	PADNAME)
 PERLVAR(I, Sv,		SV *)		/* used to hold temporary values */
 
+/*
+=for apidoc Amn|yy_parser*|PL_parser
+
+The parser state when compiling code.
+
+=cut
+*/
+
 PERLVAR(I, parser,	yy_parser *)	/* current parser state */
 
 PERLVAR(I, stashcache,	HV *)		/* Cache to speed up S_method_common */
-- 
2.11.0


From 0f043b183750070c40fdf65956e4fed8accaf77e Mon Sep 17 00:00:00 2001
From: Tony Cook <tony@develop-help.com>
Date: Thu, 31 Jan 2019 15:25:05 +1100
Subject: (perl #132777) document (sort of) and APIify PL_runops

This is documented in perlguts in such a way that it appears be
effectively API, so APIify it.

It's used on CPAN in a small number of modules.
---
 intrpvar.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/intrpvar.h b/intrpvar.h
index d2a54aca7d..47a3f519fb 100644
--- a/intrpvar.h
+++ b/intrpvar.h
@@ -627,6 +627,14 @@ PERLVAR(I, debug,	volatile U32)	/* flags given to -D switch */
 
 PERLVARI(I, padlist_generation, U32, 1)	/* id to identify padlist clones */
 
+/*
+=for apidoc Amn|runops_proc_t|PL_runops
+
+See L<perlguts/Pluggable runops>.
+
+=cut
+*/
+
 PERLVARI(I, runops,	runops_proc_t, RUNOPS_DEFAULT)
 
 PERLVAR(I, subname,	SV *)		/* name of current subroutine */
-- 
2.11.0


From 6cd68d72b70fcc90983e5e48eb1cbb8875f50129 Mon Sep 17 00:00:00 2001
From: Tony Cook <tony@develop-help.com>
Date: Thu, 31 Jan 2019 15:39:39 +1100
Subject: (perl #132777) APIify and document PL_perl_destruct_level

This is documented in perlembed.  It's only rarely used on CPAN
but it's pretty basic.
---
 intrpvar.h | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/intrpvar.h b/intrpvar.h
index 47a3f519fb..6b42c6381f 100644
--- a/intrpvar.h
+++ b/intrpvar.h
@@ -689,8 +689,25 @@ PERLVARI(I, phase,	enum perl_phase, PERL_PHASE_CONSTRUCT)
 
 PERLVARI(I, in_load_module, bool, FALSE)	/* to prevent recursions in PerlIO_find_layer */
 
-/* This value may be set when embedding for full cleanup  */
-/* 0=none, 1=full, 2=full with checks */
+/*
+=for apidoc Amn|signed char|PL_perl_destruct_level
+
+This value may be set when embedding for full cleanup.
+
+Possible values:
+
+=over
+
+=item * 0=none
+
+=item * 1=full
+
+=item * 2=full with checks.
+
+=back
+
+=cut
+*/
 /* mod_perl is special, and also assigns a meaning -1 */
 PERLVARI(I, perl_destruct_level, signed char,	0)
 
-- 
2.11.0

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Apr 14, 2019

From @jkeenan

On Thu, 31 Jan 2019 04​:52​:43 GMT, tonyc wrote​:

On Wed, 02 May 2018 00​:09​:20 -0700, LeonT wrote​:

I can think of a few others (e.g. PL_defstash), but those three are
definitely on the top of my list.

Done as separate patches to directly connect the reasoning for each
variable to the documentation.

Attached as one file to avoid anyone having to deal with seven separate
patch files.

Tony

Tony, can you provide an update as to the status of this ticket?

Thank you very much.
--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Aug 8, 2019

From @tonycoz

On Sat, 13 Apr 2019 19​:04​:54 -0700, jkeenan wrote​:

On Thu, 31 Jan 2019 04​:52​:43 GMT, tonyc wrote​:

On Wed, 02 May 2018 00​:09​:20 -0700, LeonT wrote​:

I can think of a few others (e.g. PL_defstash), but those three are
definitely on the top of my list.

Done as separate patches to directly connect the reasoning for each
variable to the documentation.

Attached as one file to avoid anyone having to deal with seven separate
patch files.

Tony

Tony, can you provide an update as to the status of this ticket?

Thank you very much.

I've applied the patches (with some changes for PL_perl_destruct_level) as merge commit 4510b39.

Tony

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Aug 11, 2019

From @jkeenan

On Thu, 08 Aug 2019 06​:02​:57 GMT, tonyc wrote​:

On Sat, 13 Apr 2019 19​:04​:54 -0700, jkeenan wrote​:

On Thu, 31 Jan 2019 04​:52​:43 GMT, tonyc wrote​:

On Wed, 02 May 2018 00​:09​:20 -0700, LeonT wrote​:

I can think of a few others (e.g. PL_defstash), but those three
are
definitely on the top of my list.

Done as separate patches to directly connect the reasoning for each
variable to the documentation.

Attached as one file to avoid anyone having to deal with seven
separate
patch files.

Tony

Tony, can you provide an update as to the status of this ticket?

Thank you very much.

I've applied the patches (with some changes for
PL_perl_destruct_level) as merge commit
4510b39.

Tony

This ticket was originally concerned with POSIX​::RT​::Spawn's failure to compile against what was then blead. It still does not compile against blead, presumably because it's .xs needs to be modified.

How should we advise the author of POSIX​::RT​::Spawn (and perhaps other modules) to proceed?

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Aug 12, 2019

From @tonycoz

On Sun, 11 Aug 2019 11​:56​:50 -0700, jkeenan wrote​:

On Thu, 08 Aug 2019 06​:02​:57 GMT, tonyc wrote​:

On Sat, 13 Apr 2019 19​:04​:54 -0700, jkeenan wrote​:

On Thu, 31 Jan 2019 04​:52​:43 GMT, tonyc wrote​:

On Wed, 02 May 2018 00​:09​:20 -0700, LeonT wrote​:

I can think of a few others (e.g. PL_defstash), but those three
are
definitely on the top of my list.

Done as separate patches to directly connect the reasoning for
each
variable to the documentation.

Attached as one file to avoid anyone having to deal with seven
separate
patch files.

Tony

Tony, can you provide an update as to the status of this ticket?

Thank you very much.

I've applied the patches (with some changes for
PL_perl_destruct_level) as merge commit
4510b39.

Tony

This ticket was originally concerned with POSIX​::RT​::Spawn's failure
to compile against what was then blead. It still does not compile
against blead, presumably because it's .xs needs to be modified.

How should we advise the author of POSIX​::RT​::Spawn (and perhaps other
modules) to proceed?

They need to eliminate use of those variables, similar to the way core did.

The minimal suggested change in the rt.cpan ticket is unsafe.

Tony

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Aug 12, 2019

From @jkeenan

On Mon, 12 Aug 2019 00​:08​:50 GMT, tonyc wrote​:

On Sun, 11 Aug 2019 11​:56​:50 -0700, jkeenan wrote​:

On Thu, 08 Aug 2019 06​:02​:57 GMT, tonyc wrote​:

On Sat, 13 Apr 2019 19​:04​:54 -0700, jkeenan wrote​:

On Thu, 31 Jan 2019 04​:52​:43 GMT, tonyc wrote​:

On Wed, 02 May 2018 00​:09​:20 -0700, LeonT wrote​:

I can think of a few others (e.g. PL_defstash), but those three
are
definitely on the top of my list.

Done as separate patches to directly connect the reasoning for
each
variable to the documentation.

Attached as one file to avoid anyone having to deal with seven
separate
patch files.

Tony

Tony, can you provide an update as to the status of this ticket?

Thank you very much.

I've applied the patches (with some changes for
PL_perl_destruct_level) as merge commit
4510b39.

Tony

This ticket was originally concerned with POSIX​::RT​::Spawn's failure
to compile against what was then blead. It still does not compile
against blead, presumably because it's .xs needs to be modified.

How should we advise the author of POSIX​::RT​::Spawn (and perhaps other
modules) to proceed?

They need to eliminate use of those variables, similar to the way core did.

The minimal suggested change in the rt.cpan ticket is unsafe.

Tony

Okay, I noted that here​: https://rt.cpan.org/Ticket/Display.html?id=125666#txn-1859636

--
James E Keenan (jkeenan@​cpan.org)

@xenu xenu removed the Severity Low label Dec 29, 2021
@jkeenan jkeenan added BBC non-5.36-blocker labels Mar 15, 2022
@hvds
Copy link
Contributor

@hvds hvds commented Mar 17, 2022

The last update to any of the author's 51 CPAN distributions was a little over 3 years ago, and to this particular distribution was over 10 years ago. I don't see any change in perl being prompted by this ticket, so there's little value in keeping it as an open ticket here - I think we should close it.

@jkeenan
Copy link
Contributor

@jkeenan jkeenan commented Mar 17, 2022

The last update to any of the author's 51 CPAN distributions was a little over 3 years ago, and to this particular distribution was over 10 years ago. I don't see any change in perl being prompted by this ticket, so there's little value in keeping it as an open ticket here - I think we should close it.

I concur. The maintainer has not responded to Slaven's suggestion of a patch to C-level code. Closing.

@jkeenan jkeenan closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BBC
Projects
None yet
Development

No branches or pull requests

4 participants