Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blead Breaks CPAN: PERLANCAR/Unix-Passwd-File-0.250.tar.gz #16400

Closed
p5pRT opened this issue Feb 1, 2018 · 12 comments
Closed

Blead Breaks CPAN: PERLANCAR/Unix-Passwd-File-0.250.tar.gz #16400

p5pRT opened this issue Feb 1, 2018 · 12 comments

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Feb 1, 2018

Migrated from rt.perl.org#132799 (status was 'resolved')

Searchable as RT132799$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 1, 2018

From @eserte

This is a bug report for perl from slaven@​rezic.de,
generated with the help of perlbug 1.41 running under perl 5.27.8.


Two tests in the Unix-Passwd-File-0.250 test suite fail with perl
5.27.8​:

...
t/get_group.t ............... Use of "goto" to jump into a construct is deprecated at /home/eserte/.cpan/build/2018020121/Unix-Passwd-File-0.250-0/blib/lib/Unix/Passwd/File.pm line 379.
t/get_group.t ............... No subtests run
...
t/get_user.t ................ Use of "goto" to jump into a construct is deprecated at /home/eserte/.cpan/build/2018020121/Unix-Passwd-File-0.250-0/blib/lib/Unix/Passwd/File.pm line 323.
t/get_user.t ................ No subtests run
...

Test Summary Report


t/get_group.t (Wstat​: 11 Tests​: 0 Failed​: 0)
  Non-zero wait status​: 11
  Parse errors​: No plan found in TAP output
t/get_user.t (Wstat​: 11 Tests​: 0 Failed​: 0)
  Non-zero wait status​: 11
  Parse errors​: No plan found in TAP output

So we have segmentation faults here (status=11).

The test suite also failed with 5.27.7, but this was probably
because of other reasons (smartmatch).

Again no bisect; good start/end commits for a bisect may be found here​:
http​://fast-matrix.cpantesters.org/?dist=Unix-Passwd-File-0.250;os=linux;perl=5.27.8;reports=1#sl=6,1



Flags​:
  category=core
  severity=low


Site configuration information for perl 5.27.8​:

Configured by eserte at Sat Jan 20 09​:22​:10 CET 2018.

Summary of my perl5 (revision 5 version 27 subversion 8) configuration​:
 
  Platform​:
  osname=linux
  osvers=3.16.0-4-amd64
  archname=x86_64-linux
  uname='linux cabulja 3.16.0-4-amd64 #1 smp debian 3.16.51-3 (2017-12-13) x86_64 gnulinux '
  config_args='-ds -e -Dprefix=/opt/perl-5.27.8 -Dusedevel -Dusemallocwrap=no -Dcf_email=srezic@​cpan.org'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=undef
  usemultiplicity=undef
  use64bitint=define
  use64bitall=define
  uselongdouble=undef
  usemymalloc=n
  default_inc_excludes_dot=define
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
  optimize='-O2'
  cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='4.9.2'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='double'
  nvsize=8
  Off_t='off_t'
  lseeksize=8
  alignbytes=8
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.9/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lpthread -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.19.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.19'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'


@​INC for perl 5.27.8​:
  /opt/perl-5.27.8/lib/site_perl/5.27.8/x86_64-linux
  /opt/perl-5.27.8/lib/site_perl/5.27.8
  /opt/perl-5.27.8/lib/5.27.8/x86_64-linux
  /opt/perl-5.27.8/lib/5.27.8


Environment for perl 5.27.8​:
  HOME=/home/eserte
  LANG=en_US.UTF-8
  LANGUAGE (unset)
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=/usr/local/bin​:/usr/bin​:/bin​:/usr/local/sbin​:/usr/sbin​:/sbin​:/home/eserte/bin/linux-gnu​:/home/eserte/bin/sh​:/home/eserte/bin​:/home/eserte/bin/pistachio-perl/bin​:/usr/games​:/home/eserte/devel
  PERLDOC=-MPod​::Perldoc​::ToTextOverstrike
  PERL_BADLANG (unset)
  SHELL=/bin/zsh

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 1, 2018

From @dur-randir

On Thu, 01 Feb 2018 12​:30​:37 -0800, slaven@​rezic.de wrote​:

Two tests in the Unix-Passwd-File-0.250 test suite fail with perl
5.27.8​:

Looks like this one​: commit 6d90e98
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Sun Jan 7 22​:23​:03 2018 -0800

  [perl #130936] Forbid some cases of inward goto

  This commit in general forbids entry into the parameter of a binary or
  list operator, to avoid crashes and stack corruption.

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 1, 2018

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 2, 2018

From @jkeenan

On Thu, 01 Feb 2018 20​:30​:37 GMT, slaven@​rezic.de wrote​:

This is a bug report for perl from slaven@​rezic.de,
generated with the help of perlbug 1.41 running under perl 5.27.8.

-----------------------------------------------------------------
Two tests in the Unix-Passwd-File-0.250 test suite fail with perl
5.27.8​:

...
t/get_group.t ............... Use of "goto" to jump into a construct
is deprecated at /home/eserte/.cpan/build/2018020121/Unix-Passwd-File-
0.250-0/blib/lib/Unix/Passwd/File.pm line 379.
t/get_group.t ............... No subtests run
...
t/get_user.t ................ Use of "goto" to jump into a construct
is deprecated at /home/eserte/.cpan/build/2018020121/Unix-Passwd-File-
0.250-0/blib/lib/Unix/Passwd/File.pm line 323.
t/get_user.t ................ No subtests run
...

Test Summary Report
-------------------
t/get_group.t (Wstat​: 11 Tests​: 0 Failed​: 0)
Non-zero wait status​: 11
Parse errors​: No plan found in TAP output
t/get_user.t (Wstat​: 11 Tests​: 0 Failed​: 0)
Non-zero wait status​: 11
Parse errors​: No plan found in TAP output

So we have segmentation faults here (status=11).

The test suite also failed with 5.27.7, but this was probably
because of other reasons (smartmatch).

Again no bisect; good start/end commits for a bisect may be found
here​:
http​://fast-matrix.cpantesters.org/?dist=Unix-Passwd-File-
0.250;os=linux;perl=5.27.8;reports=1#sl=6,1

The error message appears in this recent commit​:

#####
commit dc6e8de
Author​: Abigail <abigail@​abigail.be>
Date​: Mon Jan 16 11​:44​:30 2017 +0100

  There's an objection to fatalizing jumping into a construct.
 
  This reverts commit 84b32f5.
  This reverts commit d30393a.
 
  We need more debate on this one; either we should undeprecate it,
  or settle on an end-of-life version.
#####

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 5, 2018

From @cpansprout

On Thu, 01 Feb 2018 15​:04​:31 -0800, randir wrote​:

On Thu, 01 Feb 2018 12​:30​:37 -0800, slaven@​rezic.de wrote​:

Two tests in the Unix-Passwd-File-0.250 test suite fail with perl
5.27.8​:

Looks like this one​: commit 6d90e98
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Sun Jan 7 22​:23​:03 2018 -0800

\[perl \#130936\] Forbid some cases of inward goto

This commit in general forbids entry into the parameter of a binary or
list operator\, to avoid crashes and stack corruption\.

Fixed in 88980524f2d09.

--

Father Chrysostomos

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 5, 2018

@cpansprout - Status changed from 'open' to 'resolved'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 5, 2018

From @jkeenan

On Mon, 05 Feb 2018 07​:18​:44 GMT, sprout wrote​:

On Thu, 01 Feb 2018 15​:04​:31 -0800, randir wrote​:

On Thu, 01 Feb 2018 12​:30​:37 -0800, slaven@​rezic.de wrote​:

Two tests in the Unix-Passwd-File-0.250 test suite fail with perl
5.27.8​:

Looks like this one​: commit 6d90e98
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Sun Jan 7 22​:23​:03 2018 -0800

\[perl \#130936\] Forbid some cases of inward goto

This commit in general forbids entry into the parameter of a binary or
list operator\, to avoid crashes and stack corruption\.

Fixed in 88980524f2d09.

Can you double-check the commit number on that? Are you sure it isn't​:

commit 4bfb553
Author​: Father Chrysostomos <sprout@​cpan.org>
AuthorDate​: Mon Feb 5 01​:50​:15 2018
Commit​: Father Chrysostomos <sprout@​cpan.org>
CommitDate​: Mon Feb 5 01​:51​:36 2018

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 5, 2018

@jkeenan - Status changed from 'resolved' to 'open'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 5, 2018

From @cpansprout

On Mon, 05 Feb 2018 05​:05​:53 -0800, jkeenan wrote​:

On Mon, 05 Feb 2018 07​:18​:44 GMT, sprout wrote​:

On Thu, 01 Feb 2018 15​:04​:31 -0800, randir wrote​:

On Thu, 01 Feb 2018 12​:30​:37 -0800, slaven@​rezic.de wrote​:

Two tests in the Unix-Passwd-File-0.250 test suite fail with perl
5.27.8​:

Looks like this one​: commit
6d90e98
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Sun Jan 7 22​:23​:03 2018 -0800

[perl #130936] Forbid some cases of inward goto

This commit in general forbids entry into the parameter of a binary
or
list operator, to avoid crashes and stack corruption.

Fixed in 88980524f2d09.

Can you double-check the commit number on that? Are you sure it
isn't​:

commit 4bfb553
Author​: Father Chrysostomos <sprout@​cpan.org>
AuthorDate​: Mon Feb 5 01​:50​:15 2018
Commit​: Father Chrysostomos <sprout@​cpan.org>
CommitDate​: Mon Feb 5 01​:51​:36 2018

It is. Thank you. (It changed after I rebased.)

--

Father Chrysostomos

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 6, 2018

@jkeenan - Status changed from 'open' to 'pending release'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jun 23, 2018

From @khwilliamson

Thank you for filing this report. You have helped make Perl better.

With the release yesterday of Perl 5.28.0, this and 185 other issues have been
resolved.

Perl 5.28.0 may be downloaded via​:
https://metacpan.org/release/XSAWYERX/perl-5.28.0

If you find that the problem persists, feel free to reopen this ticket.

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jun 23, 2018

@khwilliamson - Status changed from 'pending release' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant