Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] ExtUtils::ParseXS::Eval: Fix variable name ALIAS in documentation #16410

Closed
p5pRT opened this issue Feb 9, 2018 · 8 comments
Closed

[PATCH] ExtUtils::ParseXS::Eval: Fix variable name ALIAS in documentation #16410

p5pRT opened this issue Feb 9, 2018 · 8 comments

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Feb 9, 2018

Migrated from rt.perl.org#132839 (status was 'resolved')

Searchable as RT132839$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 9, 2018

From @pali

Hi! In attachment is a patch which fixes documentation, perl variable
name for ExtUtils​::ParseXS​::Eval package.

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 9, 2018

From @pali

0001-ExtUtils-ParseXS-Eval-Fix-variable-name-ALIAS-in-doc.patch
From 7c5314511a9f28245764686db7b8677af9fefaf1 Mon Sep 17 00:00:00 2001
From: Pali <pali@cpan.org>
Date: Fri, 9 Feb 2018 12:02:34 +0100
Subject: [PATCH] ExtUtils::ParseXS::Eval: Fix variable name ALIAS in
 documentation

Correct name of variable is ALIAS, not Alias.
---
 dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Eval.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Eval.pm b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Eval.pm
index 96ef6527cf..92be0de1fa 100644
--- a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Eval.pm
+++ b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Eval.pm
@@ -29,7 +29,7 @@ Warns the contents of C<$@> if any.
 Not all these variables are necessarily considered "public" wrt. use in
 typemaps, so beware. Variables set up from the ExtUtils::ParseXS object:
 
-  $Package $Alias $func_name $Full_func_name $pname
+  $Package $ALIAS $func_name $Full_func_name $pname
 
 Variables set up from C<$other_hashref>:
 
@@ -63,7 +63,7 @@ Warns the contents of C<$@> if any.
 Not all these variables are necessarily considered "public" wrt. use in
 typemaps, so beware. Variables set up from the ExtUtils::ParseXS object:
 
-  $Package $Alias $func_name $Full_func_name $pname
+  $Package $ALIAS $func_name $Full_func_name $pname
 
 Variables set up from C<$other_hashref>:
 
-- 
2.11.0

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 9, 2018

From @jkeenan

On Fri, 09 Feb 2018 11​:06​:24 GMT, pali@​cpan.org wrote​:

Hi! In attachment is a patch which fixes documentation, perl variable
name for ExtUtils​::ParseXS​::Eval package.

Assuming no objection from the maintainer, I will apply this patch and increment $VERSION throughout within 7 days (and have taken the ticket for that purpose).

Thank you very much.
--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 9, 2018

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 15, 2018

From @jkeenan

Pushed to blead in 5999263, with increments to $VERSION in all .pm files (per advice on list from demerphq).

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 15, 2018

@jkeenan - Status changed from 'open' to 'pending release'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jun 23, 2018

From @khwilliamson

Thank you for filing this report. You have helped make Perl better.

With the release yesterday of Perl 5.28.0, this and 185 other issues have been
resolved.

Perl 5.28.0 may be downloaded via​:
https://metacpan.org/release/XSAWYERX/perl-5.28.0

If you find that the problem persists, feel free to reopen this ticket.

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jun 23, 2018

@khwilliamson - Status changed from 'pending release' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant