Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit "Add API function Perl_langinfo()" breaks XS-APItest/t/locale.t:ALT_DIGITS test #16426

Closed
p5pRT opened this issue Feb 18, 2018 · 6 comments
Closed

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Feb 18, 2018

Migrated from rt.perl.org#132879 (status was 'resolved')

Searchable as RT132879$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 18, 2018

From @bulk88

Created by @bulk88

blead perl fails a test for me on Win32 perl, Win XP 32 bit, VC 2003
compiler. Started happening in 5.27.4. I narrowed it to this commit.

at commit "Teach podcheck about strftime() and localeconv() man pages"
https://perl5.git.perl.org/perl.git/commit/97a3682bccec0fd02cc1de1c9897bf23545ccf9c

-------------------------------------------------
C​:\perl521\src\win32>cd ..\t & perl harness -v
../ext/XS-APItest/t/locale.t
& cd ..\win32
../ext/XS-APItest/t/locale.t ..
1..2
ok 1 - Gconvert doesn't recognize underlying locale outside 'use locale'
ok 2 - Gconvert doesn't recognize underlying locale inside 'use locale'
ok
All tests successful.
Files=1, Tests=2, 0 wallclock secs ( 0.03 usr + 0.00 sys = 0.03 CPU)
Result​: PASS

C​:\perl521\src\win32>
-------------------------------------------------
broken at commit "Add API function Perl_langinfo()"
https://perl5.git.perl.org/perl.git/commit/f741678155ebcc9639c420c23996e89e67bb0a4b
-------------------------------------------------
C​:\perl521\src\win32>cd ..\t & perl harness -v
../ext/XS-APItest/t/locale.t
& cd ..\win32
../ext/XS-APItest/t/locale.t ..
ok 1 - Gconvert doesn't recognize underlying locale outside 'use locale'
ok 2 - Gconvert doesn't recognize underlying locale inside 'use locale'
ok 3 - Returns expected value for ABDAY_1
ok 4 - Returns expected value for ABDAY_2
ok 5 - Returns expected value for ABDAY_3
# Failed test 22 - Returns expected value for ALT_DIGITS at t/locale.t
line 129
ok 6 - Returns expected value for ABDAY_4
# got "w"
ok 7 - Returns expected value for ABDAY_5# expected ""

ok 8 - Returns expected value for ABDAY_6
ok 9 - Returns expected value for ABDAY_7
ok 10 - Returns expected value for ABMON_1
ok 11 - Returns expected value for ABMON_10
ok 12 - Returns expected value for ABMON_11
ok 13 - Returns expected value for ABMON_12
ok 14 - Returns expected value for ABMON_2
ok 15 - Returns expected value for ABMON_3
ok 16 - Returns expected value for ABMON_4
ok 17 - Returns expected value for ABMON_5
ok 18 - Returns expected value for ABMON_6
ok 19 - Returns expected value for ABMON_7
ok 20 - Returns expected value for ABMON_8
ok 21 - Returns expected value for ABMON_9
not ok 22 - Returns expected value for ALT_DIGITS
ok 23 - Returns expected value for AM_STR
ok 24 - Returns expected value for DAY_1
ok 25 - Returns expected value for DAY_2
ok 26 - Returns expected value for DAY_3
ok 27 - Returns expected value for DAY_4
ok 28 - Returns expected value for DAY_5
ok 29 - Returns expected value for DAY_6
ok 30 - Returns expected value for DAY_7
ok 31 - Returns expected value for ERA
ok 32 - Returns expected value for MON_1
ok 33 - Returns expected value for MON_10
ok 34 - Returns expected value for MON_11
ok 35 - Returns expected value for MON_12
ok 36 - Returns expected value for MON_2
ok 37 - Returns expected value for MON_3
ok 38 - Returns expected value for MON_4
ok 39 - Returns expected value for MON_5
ok 40 - Returns expected value for MON_6
ok 41 - Returns expected value for MON_7
ok 42 - Returns expected value for MON_8
ok 43 - Returns expected value for MON_9
ok 44 - Returns expected value for PM_STR
ok 45 - Returns expected value for RADIXCHAR
ok 46 - Returns expected value for THOUSEP
1..46
Failed 1/46 subtests

Test Summary Report
-------------------
../ext/XS-APItest/t/locale.t (Wstat​: 0 Tests​: 46 Failed​: 1)
  Failed test​: 22
Files=1, Tests=46, 1 wallclock secs ( 0.00 usr + 0.02 sys = 0.02 CPU)
Result​: FAIL

C​:\perl521\src\win32>
----------------------------------------------------------------

Perl Info

Flags:
     category=core
     severity=medium

Site configuration information for perl 5.27.9:

Configured by Administrator at Tue Jan 30 20:34:30 2018.

Summary of my perl5 (revision 5 version 27 subversion 9) configuration:

   Platform:
     osname=MSWin32
     osvers=5.2.3790
     archname=MSWin32-x86-multi-thread
     uname=''
     config_args='undef'
     hint=recommended
     useposix=true
     d_sigaction=undef
     useithreads=define
     usemultiplicity=define
     use64bitint=undef
     use64bitall=undef
     uselongdouble=undef
     usemymalloc=n
     default_inc_excludes_dot=define
     bincompat5005=undef
   Compiler:
     cc='cl'
     ccflags ='-nologo -GF -W3 -O1 -MD -Zi -DNDEBUG -GL -DWIN32
-D_CONSOLE -DNO_STRICT -D_CRT_SECURE_NO_DEPRECATE
-D_CRT_NONSTDC_NO_DEPRECATE  -DPERL_TEXTMODE_SCRIPTS
-DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DWIN32_NO_REGISTRY'
     optimize='-O1 -MD -Zi -DNDEBUG -GL'
     cppflags='-DWIN32'
     ccversion='15.00.30729.01'
     gccversion=''
     gccosandvers=''
     intsize=4
     longsize=4
     ptrsize=4
     doublesize=8
     byteorder=1234
     doublekind=3
     d_longlong=undef
     longlongsize=8
     d_longdbl=define
     longdblsize=8
     longdblkind=0
     ivtype='long'
     ivsize=4
     nvtype='double'
     nvsize=8
     Off_t='__int64'
     lseeksize=8
     alignbytes=8
     prototype=define
   Linker and Libraries:
     ld='link'
     ldflags ='-nologo -nodefaultlib -debug -opt:ref,icf -ltcg
-libpath:"c:\perl\lib\CORE"        -machine:x86'
     libpth="C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\lib"
     libs=oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib
comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib
netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib version.lib
odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
     perllibs=oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib
comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib
netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib version.lib
odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
     libc=msvcrt.lib
     so=dll
     useshrplib=true
     libperl=perl527.lib
     gnulibc_version=''
   Dynamic Linking:
     dlsrc=dl_win32.xs
     dlext=dll
     d_dlsymun=undef
     ccdlflags=' '
     cccdlflags=' '
     lddlflags='-dll -nologo -nodefaultlib -debug -opt:ref,icf -ltcg
     -libpath:"c:\perl\lib\CORE"        -machine:x86'



@INC for perl 5.27.9:
     lib
     C:/p527/srcnew/lib


Environment for perl 5.27.9:
     CYGWIN=tty
     HOME (unset)
     LANG (unset)
     LANGUAGE (unset)
     LD_LIBRARY_PATH=/usr/lib/x86:/usr/X11R6/lib
     LOGDIR (unset)
     PATH=C:\WINDOWS\system32;C:\Program Files (x86)\Microsoft Visual
Studio 9.0\VC\BIN;C:\Program Files\Microsoft
SDKs\Windows\v6.0A\bin;C:\Perl\bin;C:\WINDOWS;C:\Program Files
(x86)\Microsoft Visual Studio 9.0\Common7\IDE;C:\Program Files
(x86)\Git\bin;C:\sp3220\c\bin;
     PERL_BADLANG (unset)
     SHELL (unset)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 22, 2018

From @khwilliamson

I believe a565fc6 fixes this problem. Please verify.
--
Karl Williamson

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 22, 2018

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 22, 2018

From @bulk88

On Thu, 22 Feb 2018 13​:29​:42 -0800, khw wrote​:

I believe a565fc6 fixes this problem.
Please verify.

its fixed

--
bulk88 ~ bulk88 at hotmail.com

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 23, 2018

From @khwilliamson

OP agrees that this is fixed
--
Karl Williamson

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Feb 23, 2018

@khwilliamson - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant