Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timegm should be called with 4-digit year #16430

Closed
p5pRT opened this issue Feb 22, 2018 · 4 comments
Closed

timegm should be called with 4-digit year #16430

p5pRT opened this issue Feb 22, 2018 · 4 comments

Comments

@p5pRT
Copy link
Collaborator

@p5pRT p5pRT commented Feb 22, 2018

Migrated from rt.perl.org#132896 (status was 'rejected')

Searchable as RT132896$

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Feb 22, 2018

From perlbugbmw@lsmod.de

Created by perlbugbmw@lsmod.de

timegm should be called with 4-digit year
to avoid ambiguities in Time​::Local with 2-digit years

please review/test/merge this fix​:

--- perl-5.26.1.orig/cpan/libnet/lib/Net/NNTP.pm
+++ perl-5.26.1/cpan/libnet/lib/Net/NNTP.pm
@​@​ -601 +601 @​@​ sub date {
- ? timegm($6, $5, $4, $3, $2 - 1, $1 - 1900)
+ ? timegm($6, $5, $4, $3, $2 - 1, $1)

Perl Info

Flags:
    category=library
    severity=low
    module=Net::NNTP

This perlbug was built using Perl 5.18.2 - Fri Nov 24 17:17:29 UTC 2017
It is being executed now by  Perl 5.18.2 - Fri Nov 24 17:15:01 UTC 2017.

Site configuration information for perl 5.18.2:

Configured by abuild at Fri Nov 24 17:15:01 UTC 2017.

Summary of my perl5 (revision 5 version 18 subversion 2) configuration:
   
  Platform:
    osname=linux, osvers=4.4.92-31-default, archname=x86_64-linux-thread-multi
    uname='linux build70 4.4.92-31-default #1 smp sun oct 22 06:56:24 utc 2017 (1d80e8a) x86_64 x86_64 x86_64 gnulinux '
    config_args='-ds -e -Dprefix=/usr -Dvendorprefix=/usr -Dinstallusrbinperl -Dusethreads -Di_db -Di_dbm -Di_ndbm -Di_gdbm -Dd_dbm_open -Duseshrplib=true -Doptimize=-fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -Wall -pipe -Accflags=-DPERL_USE_SAFE_PUTENV -Dotherlibdirs=/usr/lib/perl5/site_perl -Dinc_version_list=5.18.0/x86_64-linux-thread-multi 5.18.0 5.18.1/x86_64-linux-thread-multi 5.18.1'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=define, usemultiplicity=define
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=define, use64bitall=define, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DPERL_USE_SAFE_PUTENV -fno-strict-aliasing -pipe -fstack-protector -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -Wall -pipe',
    cppflags='-D_REENTRANT -D_GNU_SOURCE -DPERL_USE_SAFE_PUTENV -fno-strict-aliasing -pipe -fstack-protector'
    ccversion='', gccversion='4.8.5', gccosandvers=''
    intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
    ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -L/usr/local/lib64 -fstack-protector'
    libpth=/lib64 /usr/lib64 /usr/local/lib64
    libs=-lm -ldl -lcrypt -lpthread
    perllibs=-lm -ldl -lcrypt -lpthread
    libc=/lib64/libc-2.22.so, so=so, useshrplib=true, libperl=libperl.so
    gnulibc_version='2.22'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E -Wl,-rpath,/usr/lib/perl5/5.18.2/x86_64-linux-thread-multi/CORE'
    cccdlflags='-fPIC', lddlflags='-shared -L/usr/local/lib64 -fstack-protector'

Locally applied patches:
    


@INC for perl 5.18.2:
    /home/bernhard/perl5/lib/perl5
    /home/bernhard/perl5/lib/perl5
    /usr/lib/perl5/site_perl/5.18.2/x86_64-linux-thread-multi
    /usr/lib/perl5/site_perl/5.18.2
    /usr/lib/perl5/vendor_perl/5.18.2/x86_64-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.18.2
    /usr/lib/perl5/5.18.2/x86_64-linux-thread-multi
    /usr/lib/perl5/5.18.2
    /usr/lib/perl5/site_perl


Environment for perl 5.18.2:
    HOME=/home/bernhard
    LANG=en_US.utf8
    LANGUAGE (unset)
    LC_CTYPE=en_DK.utf8
    LC_TIME=en_DK.utf8
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/bernhard/code/cvs/reproducible/reproducibleopensuse:/home/bernhard/perl5/bin:/home/bernhard/code/cvs/reproducible/reproducibleopensuse:/home/bernhard/perl5/bin:/home/bernhard/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/games
    PERL5LIB=/home/bernhard/perl5/lib/perl5:/home/bernhard/perl5/lib/perl5
    PERL_BADLANG (unset)
    PERL_LOCAL_LIB_ROOT=/home/bernhard/perl5:/home/bernhard/perl5
    PERL_MB_OPT=--install_base "/home/bernhard/perl5"
    PERL_MM_OPT=INSTALL_BASE=/home/bernhard/perl5
    SHELL=/bin/bash

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Feb 22, 2018

From @jkeenan

libnet is maintained upstream on CPAN. I have opened this ticket in that distribution's bugtracker.

https://rt.cpan.org/Ticket/Display.html?id=124534

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Feb 22, 2018

The RT System itself - Status changed from 'new' to 'open'

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Feb 22, 2018

@jkeenan - Status changed from 'open' to 'rejected'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.