Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blead Breaks CPAN: Dancer2 #16454

Closed
p5pRT opened this issue Mar 8, 2018 · 6 comments
Closed

Blead Breaks CPAN: Dancer2 #16454

p5pRT opened this issue Mar 8, 2018 · 6 comments

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Mar 8, 2018

Migrated from rt.perl.org#132950 (status was 'rejected')

Searchable as RT132950$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 8, 2018

From carlos@carlosguevara.com

This is a bug report for perl from "Carlos Guevara" <carlos@​carlosguevara.com>,
generated with the help of perlbug 1.41 running under perl 5.27.10.


It looks like blead broke Dancer2​:
http​://www.cpantesters.org/cpan/report/2a0fd474-224e-11e8-ba18-97cfe85ef830



Flags​:
  category=core
  severity=low


Site configuration information for perl 5.27.10​:

Configured by root at Thu Mar 8 00​:53​:46 CST 2018.

Summary of my perl5 (revision 5 version 27 subversion 10) configuration​:
  Commit id​: 823ba44
  Platform​:
  osname=linux
  osvers=3.16.0-5-amd64
  archname=x86_64-linux
  uname='linux cjg-jessie 3.16.0-5-amd64 #1 smp debian
3.16.51-3+deb8u1 (2018-01-08) x86_64 gnulinux '
  config_args='-des -Dprefix=/bin/perl-blead
-Dscriptdir=
/bin/perl-blead/bin -Dusedevel -Duse64bitall'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=undef
  usemultiplicity=undef
  use64bitint=define
  use64bitall=define
  uselongdouble=undef
  usemymalloc=n
  default_inc_excludes_dot=define
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-fwrapv -fno-strict-aliasing -pipe
-fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
  optimize='-O2'
  cppflags='-fwrapv -fno-strict-aliasing -pipe
-fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='4.9.2'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='double'
  nvsize=8
  Off_t='off_t'
  lseeksize=8
  alignbytes=8
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib
/usr/lib/gcc/x86_64-linux-gnu/4.9/include-fixed
/usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu
/lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.19.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.19'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'


@​INC for perl 5.27.10​:
  /home/cpan/bin/perl-blead/lib/site_perl/5.27.10/x86_64-linux
  /home/cpan/bin/perl-blead/lib/site_perl/5.27.10
  /home/cpan/bin/perl-blead/lib/5.27.10/x86_64-linux
  /home/cpan/bin/perl-blead/lib/5.27.10


Environment for perl 5.27.10​:
  HOME=/home/cpan
  LANG=en_US.UTF-8
  LANGUAGE (unset)
  LC_ALL=C
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=/home/cpan/bin/perl-blead/bin​:/home/cpan/bin​:/usr/local/bin​:/usr/bin​:/bin​:/usr/local/games​:/usr/games
  PERL_BADLANG (unset)
  SHELL=/bin/bash

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 8, 2018

From @dur-randir

On Wed, 07 Mar 2018 23​:21​:55 -0800, carlos@​carlosguevara.com wrote​:

It looks like blead broke Dancer2​:
http​://www.cpantesters.org/cpan/report/2a0fd474-224e-11e8-ba18-
97cfe85ef830

I rather suspect a bug in Dancer2 itself. For me, version 0.201000 passes tests on blead and version 0.202000 fails t/request.t as far back as 5.18. I didn't dig further.

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 8, 2018

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 8, 2018

From @jkeenan

On Thu, 08 Mar 2018 09​:45​:55 GMT, randir wrote​:

On Wed, 07 Mar 2018 23​:21​:55 -0800, carlos@​carlosguevara.com wrote​:

It looks like blead broke Dancer2​:
http​://www.cpantesters.org/cpan/report/2a0fd474-224e-11e8-ba18-
97cfe85ef830

I rather suspect a bug in Dancer2 itself. For me, version 0.201000
passes tests on blead and version 0.202000 fails t/request.t as far
back as 5.18. I didn't dig further.

I agree that this is more likely a case where, rather than "blead breaks CPAN", blead exposes sub-optimal code in CPAN.

The relevant code in Dancer2 is this​:

#####
  while (my ($name, $value) = each %{$cookies}) {
  $cookies->{$name} = Dancer2​::Core​::Cookie->new(
  name => $name,
  value => [split(/[&;]/, $value)]
  );
  }
#####

If $value is undefined within a given cookie -- as it explicitly is in one case (used 3 times) in t/request.t -- then it is not surprising that Dancer2​::Core​::Cookie->new() would fail.

I have submitted this pull request​:
PerlDancer/Dancer2#1437

The p.r. clears up the exception and permits t/request.t to run to conclusion. Three unit tests fail -- but I think that's due to how the tests are written and I'm leaving it up to the Dancer2 community to figure out how to address that.

I'll leave this ticket open, but I myself am *not* going to mark this as a blocker for 5.28.0.

Thank you very much.
--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 8, 2018

From peter@sysnix.com

This is a known issue in Dancer2 PerlDancer/Dancer2#1435 and not a BBC so feel free to close this issue.

@p5pRT p5pRT closed this as completed Mar 8, 2018
@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 8, 2018

@jkeenan - Status changed from 'open' to 'rejected'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant