Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BBC]: Commit 0740a29 breaks Devel::NYTProf #16473

Closed
p5pRT opened this issue Mar 21, 2018 · 9 comments
Closed

[BBC]: Commit 0740a29 breaks Devel::NYTProf #16473

p5pRT opened this issue Mar 21, 2018 · 9 comments

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Mar 21, 2018

Migrated from rt.perl.org#133010 (status was 'resolved')

Searchable as RT133010$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 21, 2018

From @jkeenan

It has been reported that commit
0740a29 broke Devel​::NYTProf. (I'm
currently bisecting to double-confirm the breaking point.)

#####
CommitDate​: Tue Dec 5 01​:21​:35 2017

stop using &PL_sv_yes as no-op method

  Method lookup yields a fake method for ->import or ->unimport if
there's actual method, for historical reasons so that "use" doesn't
barf if there's no import method. This fake method used to be
&PL_sv_yes being used as a magic placeholder, recognised specially by
pp_entersub. But &PL_sv_yes is a string, which we'd expect to serve as
a symbolic CV ref. Change method lookup to yield an actual CV with a
body in this case, and remove the special case from pp_entersub. This
fixes the remaining part of [perl #126042].
#####

This was reported by Zefram in
https://rt.cpan.org/Ticket/Display.html?id=123846 and receipt
acknowledged by author Tim Bunce. A report was subsequently filed by
simcop2387 in the module's preferred bug tracker at
timbunce/devel-nytprof#113 and confirmed in
that issue by me for perl-5.27.9 on Feb 21.

In order to show both the warnings and the test failures I'm attaching
another recent attempt to build that module. (The perl_V.txt is recent
but not from that same attempt; it's just to make RT happier.)

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 21, 2018

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 21, 2018

From @jkeenan

Summary of my perl5 (revision 5 version 27 subversion 10) configuration​:
  Commit id​: f0282de
  Platform​:
  osname=linux
  osvers=4.4.0-112-generic
  archname=x86_64-linux
  uname='linux zareason 4.4.0-112-generic #135-ubuntu smp fri jan 19 11​:48​:36 utc 2018 x86_64 x86_64 x86_64 gnulinux '
  config_args='-des -Dusedevel'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=undef
  usemultiplicity=undef
  use64bitint=define
  use64bitall=define
  uselongdouble=undef
  usemymalloc=n
  default_inc_excludes_dot=define
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
  optimize='-O2'
  cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='5.4.1 20160904'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='double'
  nvsize=8
  Off_t='off_t'
  lseeksize=8
  alignbytes=8
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/5/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /lib64 /usr/lib64
  libs=-lpthread -lnsl -ldb -ldl -lm -lcrypt -lutil -lc
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.23.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.23'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​:
  HAS_TIMES
  PERLIO_LAYERS
  PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_MALLOC_WRAP
  PERL_OP_PARENT
  PERL_PRESERVE_IVUV
  PERL_USE_DEVEL
  USE_64_BIT_ALL
  USE_64_BIT_INT
  USE_LARGE_FILES
  USE_LOCALE
  USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC
  USE_LOCALE_TIME
  USE_PERLIO
  USE_PERL_ATOF
  Built under linux
  Compiled at Mar 20 2018 17​:28​:52
  %ENV​:
  PERL2DIR="/home/jkeenan/gitwork/perl2"
  PERLBREW_BASHRC_VERSION="0.78"
  PERLBREW_HOME="/home/jkeenan/.perlbrew"
  PERLBREW_MANPATH="/home/jkeenan/perl5/perlbrew/perls/perl-5.26.0/man"
  PERLBREW_PATH="/home/jkeenan/perl5/perlbrew/bin​:/home/jkeenan/perl5/perlbrew/perls/perl-5.26.0/bin"
  PERLBREW_PERL="perl-5.26.0"
  PERLBREW_ROOT="/home/jkeenan/perl5/perlbrew"
  PERLBREW_VERSION="0.78"
  PERL_WORKDIR="/home/jkeenan/gitwork/perl"
  @​INC​:
  lib
  /usr/local/lib/perl5/site_perl/5.27.10/x86_64-linux
  /usr/local/lib/perl5/site_perl/5.27.10
  /usr/local/lib/perl5/5.27.10/x86_64-linux
  /usr/local/lib/perl5/5.27.10

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 22, 2018

From @jkeenan

On Wed, 21 Mar 2018 21​:28​:04 GMT, jkeenan@​pobox.com wrote​:

It has been reported that commit
0740a29 broke Devel​::NYTProf. (I'm
currently bisecting to double-confirm the breaking point.)

Breakage point confirmed by bisection​:
0740a29 is the first bad commit

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 22, 2018

From [Unknown Contact. See original ticket]

On Wed, 21 Mar 2018 21​:28​:04 GMT, jkeenan@​pobox.com wrote​:

It has been reported that commit
0740a29 broke Devel​::NYTProf. (I'm
currently bisecting to double-confirm the breaking point.)

Breakage point confirmed by bisection​:
0740a29 is the first bad commit

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 23, 2018

From @jkeenan

On Thu, 22 Mar 2018 02​:49​:54 GMT, jkeenan wrote​:

On Wed, 21 Mar 2018 21​:28​:04 GMT, jkeenan@​pobox.com wrote​:

It has been reported that commit
0740a29 broke Devel​::NYTProf. (I'm
currently bisecting to double-confirm the breaking point.)

Breakage point confirmed by bisection​:
0740a29 is the first bad commit

TIMB is on the case!

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 23, 2018

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 26, 2018

@iabyn - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Mar 26, 2018
@p5pRT
Copy link
Author

@p5pRT p5pRT commented Mar 26, 2018

From @jkeenan

On Fri, 23 Mar 2018 21​:34​:49 GMT, jkeenan wrote​:

On Thu, 22 Mar 2018 02​:49​:54 GMT, jkeenan wrote​:

On Wed, 21 Mar 2018 21​:28​:04 GMT, jkeenan@​pobox.com wrote​:

It has been reported that commit
0740a29 broke Devel​::NYTProf. (I'm
currently bisecting to double-confirm the breaking point.)

Breakage point confirmed by bisection​:
0740a29 is the first bad commit

TIMB is on the case!

Confirmation of the correction uploaded to CPAN overnight​:

#####
$ ./bin/perl -v | head -2 | tail -1
This is perl 5, version 27, subversion 11 (v5.27.11 (v5.27.10-19-ge771953)) built for x86_64-linux-thread-multi
$ ./bin/cpanm Devel​::NYTProf
...
Building and testing Algorithm-Diff-1.1903 ... OK
Successfully installed Algorithm-Diff-1.1903
Building and testing Text-Diff-1.45 ... OK
Successfully installed Text-Diff-1.45
Building and testing Test-Differences-0.64 ... OK
Successfully installed Test-Differences-0.64
Building and testing Devel-NYTProf-6.05 ... OK
Successfully installed Devel-NYTProf-6.05
4 distributions installed
#####

Thank you very much.
--
James E Keenan (jkeenan@​cpan.org)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant