Remove Locale-Codes from core modules #16660
Comments
From @jkeenanSo that we can have a permanent record in RT of this proposed module Sullivan Beck, maintainer of Locale-Codes, originally proposed removal https://lists.gt.net/perl/porters/338584?search_string=Locale-Codes;#338584 Today (Aug 18 2018), Sullivan Beck wrote: ##### I've got a patch ready that removes Locale-Codes from perl core. It is https://sullybeck.com/0001-Remove-Locale-Codes-from-core.patch.gz I did NOT update any change file to state that the package was no longer Also, running make on the resulting source gave errors when running: t/porting/podcheck I'm not familiar with the podcheck script, so I'm uncertain of the Let me know if there's anything else that I should do on my end. ##### Sullivan's (gzipped) patch is attached. Once RT gives me a ticket Thank you very much. |
From @jkeenanOn Sun, 19 Aug 2018 02:07:10 GMT, jkeenan@pobox.com wrote:
Here's the branch: smoke-me/jkeenan/sbeck/133458-remove-locale-codes As Sullivan noted, there were problems with the porting tests. It took me several commits to get all tests PASSing. I'm attaching the 3 commits for code review purposes. Thank you very much. |
From @jkeenan0002-Remove-superseded-links-from-Unicode-UCD.patchFrom 6f98fceb19fcd8cd2a2af18f4504c3e2110a9020 Mon Sep 17 00:00:00 2001
From: James E Keenan <jkeenan@cpan.org>
Date: Sat, 18 Aug 2018 22:27:50 -0400
Subject: [PATCH 2/4] Remove superseded links from Unicode::UCD.
Run regen/regcharclass.pl to update regcharclass.h.
---
lib/Unicode/UCD.pm | 12 +++++-------
regcharclass.h | 2 +-
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/lib/Unicode/UCD.pm b/lib/Unicode/UCD.pm
index 0bb9667..e42a188 100644
--- a/lib/Unicode/UCD.pm
+++ b/lib/Unicode/UCD.pm
@@ -5,7 +5,7 @@ use warnings;
no warnings 'surrogate'; # surrogates can be inputs to this
use charnames ();
-our $VERSION = '0.71';
+our $VERSION = '0.72';
require Exporter;
@@ -1611,14 +1611,12 @@ and are returned by L</charinfo()>.
Note that when this function does return a value, it will be for the complete
set of mappings for a code point, even those whose length is one.
-If there are additional casing rules that apply only in certain locales,
-an additional key for each will be defined in the returned hash. Each such key
+If there are additional casing rules that apply only in certain locales, an
+additional key for each will be defined in the returned hash. Each such key
will be its locale name, defined as a 2-letter ISO 3166 country code, possibly
followed by a "_" and a 2-letter ISO language code (possibly followed by a "_"
-and a variant code). You can find the lists of all possible locales, see
-L<Locale::Country> and L<Locale::Language>.
-(In Unicode 6.0, the only locales returned by this function
-are C<lt>, C<tr>, and C<az>.)
+and a variant code). (In Unicode 6.0, the only locales returned by this
+function are C<lt>, C<tr>, and C<az>.)
Each locale key is a reference to a hash that has the form above, and gives
the casing rules for that particular locale, which take precedence over the
diff --git a/regcharclass.h b/regcharclass.h
index 5240fdc..f133b88 100644
--- a/regcharclass.h
+++ b/regcharclass.h
@@ -1863,7 +1863,7 @@
#endif /* PERL_REGCHARCLASS_H_ */
/* Generated from:
- * f0b404b165a72b0aaeca3ce517cd14ea1b501720c98719dadbb990f1952fc568 lib/Unicode/UCD.pm
+ * 97f567befddc6f431bfc2ed71d1e8fa4d567fe3ed76420743305ecf0445a37eb lib/Unicode/UCD.pm
* 0bc5023a4606962114c4eb3775fae072cad8fecef5894d0de06603b1c70cbb47 lib/unicore/ArabicShaping.txt
* 2c7e2fb0cb91b378f0fa9301e951946e4de68f2ab6afc68d21bcff57cd2a8ad8 lib/unicore/BidiBrackets.txt
* f6d297765469724af523737c80faba3c33518fade4c5dc599e3ab51846f56916 lib/unicore/BidiMirroring.txt
--
2.7.4
|
From @jkeenan0003-Changes-from-running-.-perl-Ilib-regen-mk_invlists.p.patchFrom f77812129284e32855d3d7098949dc15723d8d73 Mon Sep 17 00:00:00 2001
From: James E Keenan <jkeenan@cpan.org>
Date: Sat, 18 Aug 2018 22:38:55 -0400
Subject: [PATCH 3/4] Changes from running: './perl -Ilib regen/mk_invlists.pl'
---
charclass_invlists.h | 2 +-
uni_keywords.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/charclass_invlists.h b/charclass_invlists.h
index 9965fbe..1e459dc 100644
--- a/charclass_invlists.h
+++ b/charclass_invlists.h
@@ -383371,7 +383371,7 @@ static const U8 WB_table[23][23] = {
#endif /* defined(PERL_IN_REGEXEC_C) */
/* Generated from:
- * f0b404b165a72b0aaeca3ce517cd14ea1b501720c98719dadbb990f1952fc568 lib/Unicode/UCD.pm
+ * 97f567befddc6f431bfc2ed71d1e8fa4d567fe3ed76420743305ecf0445a37eb lib/Unicode/UCD.pm
* 0bc5023a4606962114c4eb3775fae072cad8fecef5894d0de06603b1c70cbb47 lib/unicore/ArabicShaping.txt
* 2c7e2fb0cb91b378f0fa9301e951946e4de68f2ab6afc68d21bcff57cd2a8ad8 lib/unicore/BidiBrackets.txt
* f6d297765469724af523737c80faba3c33518fade4c5dc599e3ab51846f56916 lib/unicore/BidiMirroring.txt
diff --git a/uni_keywords.h b/uni_keywords.h
index 61aa62c..770668c 100644
--- a/uni_keywords.h
+++ b/uni_keywords.h
@@ -6944,7 +6944,7 @@ MPH_VALt match_uniprop( const unsigned char * const key, const U16 key_len ) {
}
/* Generated from:
- * f0b404b165a72b0aaeca3ce517cd14ea1b501720c98719dadbb990f1952fc568 lib/Unicode/UCD.pm
+ * 97f567befddc6f431bfc2ed71d1e8fa4d567fe3ed76420743305ecf0445a37eb lib/Unicode/UCD.pm
* 0bc5023a4606962114c4eb3775fae072cad8fecef5894d0de06603b1c70cbb47 lib/unicore/ArabicShaping.txt
* 2c7e2fb0cb91b378f0fa9301e951946e4de68f2ab6afc68d21bcff57cd2a8ad8 lib/unicore/BidiBrackets.txt
* f6d297765469724af523737c80faba3c33518fade4c5dc599e3ab51846f56916 lib/unicore/BidiMirroring.txt
--
2.7.4
|
From @jkeenan0004-Run-.-perl-Ilib-regen-lib_cleanup.pl.patchFrom 4c9fdf613b231bb5a223114e3c8b774f5fde3b3b Mon Sep 17 00:00:00 2001
From: James E Keenan <jkeenan@cpan.org>
Date: Sat, 18 Aug 2018 23:08:34 -0400
Subject: [PATCH 4/4] Run ./perl -Ilib regen/lib_cleanup.pl.
---
Makefile.SH | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/Makefile.SH b/Makefile.SH
index a98c651..6f33a73 100755
--- a/Makefile.SH
+++ b/Makefile.SH
@@ -1443,16 +1443,15 @@ _cleaner2:
-rmdir lib/Parse/CPAN lib/Parse lib/Params lib/Net/FTP lib/Module/Load
-rmdir lib/Module/CoreList lib/Module lib/Memoize lib/Math/BigInt
-rmdir lib/Math/BigFloat lib/Math lib/MIME lib/Locale/Maketext
- -rmdir lib/Locale/Codes lib/Locale lib/List/Util lib/List lib/JSON/PP
- -rmdir lib/JSON lib/IPC lib/IO/Uncompress/Adapter lib/IO/Uncompress
- -rmdir lib/IO/Socket lib/IO/Compress/Zlib lib/IO/Compress/Zip
- -rmdir lib/IO/Compress/Gzip lib/IO/Compress/Base
- -rmdir lib/IO/Compress/Adapter lib/IO/Compress lib/IO
- -rmdir lib/I18N/LangTags lib/I18N lib/Hash/Util lib/Hash lib/HTTP
- -rmdir lib/Filter/Util lib/Filter lib/File/Spec lib/ExtUtils/Typemaps
- -rmdir lib/ExtUtils/ParseXS lib/ExtUtils/MakeMaker/version
- -rmdir lib/ExtUtils/MakeMaker lib/ExtUtils/Liblist
- -rmdir lib/ExtUtils/Constant lib/ExtUtils/Command
+ -rmdir lib/Locale lib/List/Util lib/List lib/JSON/PP lib/JSON lib/IPC
+ -rmdir lib/IO/Uncompress/Adapter lib/IO/Uncompress lib/IO/Socket
+ -rmdir lib/IO/Compress/Zlib lib/IO/Compress/Zip lib/IO/Compress/Gzip
+ -rmdir lib/IO/Compress/Base lib/IO/Compress/Adapter lib/IO/Compress
+ -rmdir lib/IO lib/I18N/LangTags lib/I18N lib/Hash/Util lib/Hash
+ -rmdir lib/HTTP lib/Filter/Util lib/Filter lib/File/Spec
+ -rmdir lib/ExtUtils/Typemaps lib/ExtUtils/ParseXS
+ -rmdir lib/ExtUtils/MakeMaker/version lib/ExtUtils/MakeMaker
+ -rmdir lib/ExtUtils/Liblist lib/ExtUtils/Constant lib/ExtUtils/Command
-rmdir lib/ExtUtils/CBuilder/Platform/Windows
-rmdir lib/ExtUtils/CBuilder/Platform lib/ExtUtils/CBuilder
-rmdir lib/Exporter lib/Encode/Unicode lib/Encode/MIME/Header
--
2.7.4
|
|
The RT System itself - Status changed from 'new' to 'open' |
From @khwilliamsonOn 08/18/2018 09:23 PM, James E Keenan via RT wrote:
Attached is an alternative patch (that might want to be split). There More importantly, the podcheck fix doesn't involve removing the links |
From @khwilliamson0005-YALocale-Codes-patch.patchFrom 4a369f73b32bc70aedeb1ba3ede83cb1b3c96daa Mon Sep 17 00:00:00 2001
From: Karl Williamson <khw@cpan.org>
Date: Sat, 18 Aug 2018 21:59:42 -0600
Subject: [PATCH 5/5] YALocale::Codes patch
---
Makefile.SH | 19 +++++++++----------
Porting/corelist-perldelta.pl | 7 -------
t/TEST | 1 -
t/porting/known_pod_issues.dat | 2 ++
4 files changed, 11 insertions(+), 18 deletions(-)
diff --git a/Makefile.SH b/Makefile.SH
index a98c651a62..6f33a73a36 100755
--- a/Makefile.SH
+++ b/Makefile.SH
@@ -1443,16 +1443,15 @@ _cleaner2:
-rmdir lib/Parse/CPAN lib/Parse lib/Params lib/Net/FTP lib/Module/Load
-rmdir lib/Module/CoreList lib/Module lib/Memoize lib/Math/BigInt
-rmdir lib/Math/BigFloat lib/Math lib/MIME lib/Locale/Maketext
- -rmdir lib/Locale/Codes lib/Locale lib/List/Util lib/List lib/JSON/PP
- -rmdir lib/JSON lib/IPC lib/IO/Uncompress/Adapter lib/IO/Uncompress
- -rmdir lib/IO/Socket lib/IO/Compress/Zlib lib/IO/Compress/Zip
- -rmdir lib/IO/Compress/Gzip lib/IO/Compress/Base
- -rmdir lib/IO/Compress/Adapter lib/IO/Compress lib/IO
- -rmdir lib/I18N/LangTags lib/I18N lib/Hash/Util lib/Hash lib/HTTP
- -rmdir lib/Filter/Util lib/Filter lib/File/Spec lib/ExtUtils/Typemaps
- -rmdir lib/ExtUtils/ParseXS lib/ExtUtils/MakeMaker/version
- -rmdir lib/ExtUtils/MakeMaker lib/ExtUtils/Liblist
- -rmdir lib/ExtUtils/Constant lib/ExtUtils/Command
+ -rmdir lib/Locale lib/List/Util lib/List lib/JSON/PP lib/JSON lib/IPC
+ -rmdir lib/IO/Uncompress/Adapter lib/IO/Uncompress lib/IO/Socket
+ -rmdir lib/IO/Compress/Zlib lib/IO/Compress/Zip lib/IO/Compress/Gzip
+ -rmdir lib/IO/Compress/Base lib/IO/Compress/Adapter lib/IO/Compress
+ -rmdir lib/IO lib/I18N/LangTags lib/I18N lib/Hash/Util lib/Hash
+ -rmdir lib/HTTP lib/Filter/Util lib/Filter lib/File/Spec
+ -rmdir lib/ExtUtils/Typemaps lib/ExtUtils/ParseXS
+ -rmdir lib/ExtUtils/MakeMaker/version lib/ExtUtils/MakeMaker
+ -rmdir lib/ExtUtils/Liblist lib/ExtUtils/Constant lib/ExtUtils/Command
-rmdir lib/ExtUtils/CBuilder/Platform/Windows
-rmdir lib/ExtUtils/CBuilder/Platform lib/ExtUtils/CBuilder
-rmdir lib/Exporter lib/Encode/Unicode lib/Encode/MIME/Header
diff --git a/Porting/corelist-perldelta.pl b/Porting/corelist-perldelta.pl
index 5290d77238..c8a1429cdb 100755
--- a/Porting/corelist-perldelta.pl
+++ b/Porting/corelist-perldelta.pl
@@ -174,13 +174,6 @@ sub corelist_delta {
'data' => $changes{'Net::Cmd'}
}
],
- 'Locale-Codes' => [
- {
- 'name' => 'Locale::Codes',
- 'modification' => $getModifyType->( $changes{'Locale::Codes'} ),
- 'data' => $changes{'Locale::Codes'}
- }
- ],
'PathTools' => [
{
'name' => 'File::Spec',
diff --git a/t/TEST b/t/TEST
index 9a4b4e7a28..f8f338ffe2 100755
--- a/t/TEST
+++ b/t/TEST
@@ -49,7 +49,6 @@ my %abs = (
'../cpan/File-Fetch' => 1,
'../cpan/IPC-Cmd' => 1,
'../cpan/IPC-SysV' => 1,
- '../cpan/Locale-Codes' => 1,
'../cpan/Module-Load' => 1,
'../cpan/Module-Load-Conditional' => 1,
'../cpan/Pod-Simple' => 1,
diff --git a/t/porting/known_pod_issues.dat b/t/porting/known_pod_issues.dat
index 9237c57df2..baff04842f 100644
--- a/t/porting/known_pod_issues.dat
+++ b/t/porting/known_pod_issues.dat
@@ -161,6 +161,8 @@ Lingua::ZH::Romanize::Pinyin
List::Gather
listen(2)
local::lib
+Locale::Country
+Locale::Language
localeconv(3)
lockf(3)
Log::Message
--
2.17.1
|
From @khwilliamsonOn 08/18/2018 09:23 PM, James E Keenan via RT wrote:
Attached is an alternative patch (that might want to be split). There More importantly, the podcheck fix doesn't involve removing the links |
From @khwilliamson0005-YALocale-Codes-patch.patchFrom 4a369f73b32bc70aedeb1ba3ede83cb1b3c96daa Mon Sep 17 00:00:00 2001
From: Karl Williamson <khw@cpan.org>
Date: Sat, 18 Aug 2018 21:59:42 -0600
Subject: [PATCH 5/5] YALocale::Codes patch
---
Makefile.SH | 19 +++++++++----------
Porting/corelist-perldelta.pl | 7 -------
t/TEST | 1 -
t/porting/known_pod_issues.dat | 2 ++
4 files changed, 11 insertions(+), 18 deletions(-)
diff --git a/Makefile.SH b/Makefile.SH
index a98c651a62..6f33a73a36 100755
--- a/Makefile.SH
+++ b/Makefile.SH
@@ -1443,16 +1443,15 @@ _cleaner2:
-rmdir lib/Parse/CPAN lib/Parse lib/Params lib/Net/FTP lib/Module/Load
-rmdir lib/Module/CoreList lib/Module lib/Memoize lib/Math/BigInt
-rmdir lib/Math/BigFloat lib/Math lib/MIME lib/Locale/Maketext
- -rmdir lib/Locale/Codes lib/Locale lib/List/Util lib/List lib/JSON/PP
- -rmdir lib/JSON lib/IPC lib/IO/Uncompress/Adapter lib/IO/Uncompress
- -rmdir lib/IO/Socket lib/IO/Compress/Zlib lib/IO/Compress/Zip
- -rmdir lib/IO/Compress/Gzip lib/IO/Compress/Base
- -rmdir lib/IO/Compress/Adapter lib/IO/Compress lib/IO
- -rmdir lib/I18N/LangTags lib/I18N lib/Hash/Util lib/Hash lib/HTTP
- -rmdir lib/Filter/Util lib/Filter lib/File/Spec lib/ExtUtils/Typemaps
- -rmdir lib/ExtUtils/ParseXS lib/ExtUtils/MakeMaker/version
- -rmdir lib/ExtUtils/MakeMaker lib/ExtUtils/Liblist
- -rmdir lib/ExtUtils/Constant lib/ExtUtils/Command
+ -rmdir lib/Locale lib/List/Util lib/List lib/JSON/PP lib/JSON lib/IPC
+ -rmdir lib/IO/Uncompress/Adapter lib/IO/Uncompress lib/IO/Socket
+ -rmdir lib/IO/Compress/Zlib lib/IO/Compress/Zip lib/IO/Compress/Gzip
+ -rmdir lib/IO/Compress/Base lib/IO/Compress/Adapter lib/IO/Compress
+ -rmdir lib/IO lib/I18N/LangTags lib/I18N lib/Hash/Util lib/Hash
+ -rmdir lib/HTTP lib/Filter/Util lib/Filter lib/File/Spec
+ -rmdir lib/ExtUtils/Typemaps lib/ExtUtils/ParseXS
+ -rmdir lib/ExtUtils/MakeMaker/version lib/ExtUtils/MakeMaker
+ -rmdir lib/ExtUtils/Liblist lib/ExtUtils/Constant lib/ExtUtils/Command
-rmdir lib/ExtUtils/CBuilder/Platform/Windows
-rmdir lib/ExtUtils/CBuilder/Platform lib/ExtUtils/CBuilder
-rmdir lib/Exporter lib/Encode/Unicode lib/Encode/MIME/Header
diff --git a/Porting/corelist-perldelta.pl b/Porting/corelist-perldelta.pl
index 5290d77238..c8a1429cdb 100755
--- a/Porting/corelist-perldelta.pl
+++ b/Porting/corelist-perldelta.pl
@@ -174,13 +174,6 @@ sub corelist_delta {
'data' => $changes{'Net::Cmd'}
}
],
- 'Locale-Codes' => [
- {
- 'name' => 'Locale::Codes',
- 'modification' => $getModifyType->( $changes{'Locale::Codes'} ),
- 'data' => $changes{'Locale::Codes'}
- }
- ],
'PathTools' => [
{
'name' => 'File::Spec',
diff --git a/t/TEST b/t/TEST
index 9a4b4e7a28..f8f338ffe2 100755
--- a/t/TEST
+++ b/t/TEST
@@ -49,7 +49,6 @@ my %abs = (
'../cpan/File-Fetch' => 1,
'../cpan/IPC-Cmd' => 1,
'../cpan/IPC-SysV' => 1,
- '../cpan/Locale-Codes' => 1,
'../cpan/Module-Load' => 1,
'../cpan/Module-Load-Conditional' => 1,
'../cpan/Pod-Simple' => 1,
diff --git a/t/porting/known_pod_issues.dat b/t/porting/known_pod_issues.dat
index 9237c57df2..baff04842f 100644
--- a/t/porting/known_pod_issues.dat
+++ b/t/porting/known_pod_issues.dat
@@ -161,6 +161,8 @@ Lingua::ZH::Romanize::Pinyin
List::Gather
listen(2)
local::lib
+Locale::Country
+Locale::Language
localeconv(3)
lockf(3)
Log::Message
--
2.17.1
|
From @jkeenanOn Sun, 19 Aug 2018 04:05:54 GMT, public@khwilliamson.com wrote:
I'm not wedded to my particular choices, so, rather than multiplying branches, I suggest you apply this patch to the smoke-me branch I created yesterday. Thank you very much. |
From @khwilliamsonOn 08/19/2018 06:47 AM, James E Keenan via RT wrote:
Done. I reverted your two patches in this regard, and added my own. |
1 similar comment
From @khwilliamsonOn 08/19/2018 06:47 AM, James E Keenan via RT wrote:
Done. I reverted your two patches in this regard, and added my own. |
From @khwilliamsonOn 08/19/2018 10:01 AM, Karl Williamson wrote:
Locale-Codes is now removed from blead by |
1 similar comment
From @khwilliamsonOn 08/19/2018 10:01 AM, Karl Williamson wrote:
Locale-Codes is now removed from blead by |
From @khwilliamsonLocale-Codes is now removed from blead by |
|
@khwilliamson - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release today of Perl 5.30.0, this and 160 other issues have been Perl 5.30.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
|
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#133458 (status was 'resolved')
Searchable as RT133458$
The text was updated successfully, but these errors were encountered: