[PATCH] Fix B extension skip in ext/B/t/strict.t

[p5pRT]

Migrated from rt.perl.org#133713 (status was 'resolved')

Searchable as RT133713$

[p5pRT]

From @ppisar

If perl is built in an environment with a locale where
"B" > "attribute" (e.g. "C" locale), ext/B/t/strict.t test will be skipped
in contrast to other B tests​:

../ext/B/t/showlex.t .............. ok
../ext/B/t/strict.t ............... skipped​: Perl was not compiled with B

The tests match $Config{'extensions'} for "B" and skip the tests if not
found. However, ext/B/t/strict.t uses a distinct regular expression
that fails if $Config{'extensions'} starts with "B ".

This patch makes the ext/B/t/strict.t test alike to other ones.

Signed-off-by​: Petr PísaÅ� <ppisar@​redhat.com>

---

ext/B/t/strict.t | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Inline Patch

diff --git a/ext/B/t/strict.t b/ext/B/t/strict.t
index 4d1b84aa20..9f5eacd7da 100644
--- a/ext/B/t/strict.t
+++ b/ext/B/t/strict.t
@@ -7,7 +7,7 @@ use Config;
 use Test::More;
 
 BEGIN {
-    if ( ( $Config{'extensions'} !~ /\sB\s/ ) ) {
+    if ( ( $Config{'extensions'} !~ /\bB\b/ ) ) {
         plan skip_all => "Perl was not compiled with B";
         exit 0;
     }
-- 
2.17.2

[p5pRT]

From @jkeenan

On Fri, 07 Dec 2018 11​:30​:44 GMT, ppisar wrote​:

If perl is built in an environment with a locale where
"B" > "attribute" (e.g. "C" locale), ext/B/t/strict.t test will be skipped
in contrast to other B tests​:

../ext/B/t/showlex.t .............. ok
../ext/B/t/strict.t ............... skipped​: Perl was not compiled with B

The tests match $Config{'extensions'} for "B" and skip the tests if not
found. However, ext/B/t/strict.t uses a distinct regular expression
that fails if $Config{'extensions'} starts with "B ".

This patch makes the ext/B/t/strict.t test alike to other ones.

Signed-off-by​: Petr PísaÅ� <ppisar@​redhat.com>
---
ext/B/t/strict.t | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ext/B/t/strict.t b/ext/B/t/strict.t
index 4d1b84aa20..9f5eacd7da 100644
--- a/ext/B/t/strict.t
+++ b/ext/B/t/strict.t
@​@​ -7,7 +7,7 @​@​ use Config;
use Test​::More;

BEGIN {
- if ( ( $Config{'extensions'} !~ /\sB\s/ ) ) {
+ if ( ( $Config{'extensions'} !~ /\bB\b/ ) ) {
plan skip_all => "Perl was not compiled with B";
exit 0;
}

Thanks. Pushed to blead in commit dc0a6b7

--
James E Keenan (jkeenan@​cpan.org)

[p5pRT]

The RT System itself - Status changed from 'new' to 'open'

[p5pRT]

@jkeenan - Status changed from 'open' to 'pending release'

[p5pRT]

From @khwilliamson

Thank you for filing this report. You have helped make Perl better.

With the release today of Perl 5.30.0, this and 160 other issues have been
resolved.

Perl 5.30.0 may be downloaded via​:
https://metacpan.org/release/XSAWYERX/perl-5.30.0

If you find that the problem persists, feel free to reopen this ticket.

[p5pRT]

@khwilliamson - Status changed from 'pending release' to 'resolved'