Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.29.8-151-g765e6ecf32 breaks BKB/Lingua-JA-Moji-0.56.tar.gz #16913

Closed
p5pRT opened this issue Mar 31, 2019 · 6 comments
Closed

Bleadperl v5.29.8-151-g765e6ecf32 breaks BKB/Lingua-JA-Moji-0.56.tar.gz #16913

p5pRT opened this issue Mar 31, 2019 · 6 comments
Labels

Comments

@p5pRT
Copy link
Collaborator

@p5pRT p5pRT commented Mar 31, 2019

Migrated from rt.perl.org#133968 (status was 'resolved')

Searchable as RT133968$

@p5pRT
Copy link
Collaborator Author

@p5pRT p5pRT commented Mar 31, 2019

From @andk

Xref​: benkasminbullock/Lingua-JA-Moji#24
--
andreas
perl perl perl

@p5pRT
Copy link
Collaborator Author

@p5pRT p5pRT commented Mar 31, 2019

From @jkeenan

On Sun, 31 Mar 2019 19​:29​:19 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Xref​: benkasminbullock/Lingua-JA-Moji#24

This appears to have been un-broken at a later commit. At HEAD I install with cpanm and get​:

#####
$ ./bin/perl -v | head -2 | tail -1
This is perl 5, version 29, subversion 10 (v5.29.10 (v5.29.9-50-gfcacab092a)) built for x86_64-linux

$ ./bin/perl -MLingua​::JA​::Moji -E 'say q|hello world|'
hello world
#####

Thank you very much.
--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Collaborator Author

@p5pRT p5pRT commented Mar 31, 2019

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Collaborator Author

@p5pRT p5pRT commented Mar 31, 2019

From @khwilliamson

On 3/31/19 2​:31 PM, James E Keenan via RT wrote​:

On Sun, 31 Mar 2019 19​:29​:19 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Xref​: benkasminbullock/Lingua-JA-Moji#24

This appears to have been un-broken at a later commit. At HEAD I install with cpanm and get​:

#####
$ ./bin/perl -v | head -2 | tail -1
This is perl 5, version 29, subversion 10 (v5.29.10 (v5.29.9-50-gfcacab092a)) built for x86_64-linux

$ ./bin/perl -MLingua​::JA​::Moji -E 'say q|hello world|'
hello world
#####

Thank you very much.

This bug should have been fixed by

commit 766d6d3
  Author​: Karl Williamson <khw@​cpan.org>
  Date​: Thu Mar 28 12​:26​:43 2019 -0600

  PATCH​: [perl #133942] BBC​: BKB/Lingua-JA-Moji

  This ticket was originally fixed by a PR being issued on the
  distribution, which was merged and a new version placed on CPAN.

  But before Slaven had a chance to test it, commit
  765e6ec came along, and happened to
  break it again from a totally independent cause.

* So we have two separate bugs on the same ticket, only one of which was
  perl's fault. And this commit fixes that. The problematic commit was
  still looking in the regnode FLAGS field in one function, whereas that
  field has been repurposed for ANYOFH nodes, so should be ignored for
  them.

@p5pRT
Copy link
Collaborator Author

@p5pRT p5pRT commented Apr 13, 2019

From @khwilliamson

Fixed, as listed above
--
Karl Williamson

@p5pRT
Copy link
Collaborator Author

@p5pRT p5pRT commented Apr 13, 2019

@khwilliamson - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this Apr 13, 2019
@p5pRT p5pRT added the Severity Low label Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.