Repository navigation
open(FH, "+>>", undef) doesn't set O_APPEND #17058
Description
Migrated from rt.perl.org#134221 (status was 'pending release')
Searchable as RT134221$
Migrated from rt.perl.org#134221 (status was 'pending release')
Searchable as RT134221$
Activity
p5pRT commentedon Jun 24, 2019
From e@80x24.org
Created by e@80x24.org
I love using open(FH, MODE, undef) to create unlinked temporary
files with minimal typing.
But I was surprised when using "+>>" as the MODE did not set
O_APPEND on the temporary file handle (or warn about the ">>"
being ignored. I want to use O_APPEND so I can easily append to
it from one callback while while using sendfile or pread+SSL_write
to write to a socket.
I'm using this as a lazy write buffer for reading the output of
process (e.g. git-http-backend/git-archive) while sending to
a client which may not be able to keep up with the output speed.
Thanks for keeping Perl 5 alive!
Perl Info
p5pRT commentedon Jul 2, 2019
From @tonycoz
On Sun, 23 Jun 2019 18:50:24 -0700, e@80x24.org wrote:
I've attached a partial solution, that works on Linux (and presumably other POSIX-ish systems) and Win32.
From what I remember of a discussion with Craig back when working on the in-place editing re-work, the code currently guarded by !defined(VMS) should also work on VMS, except for the default to /tmp/.
Tony
p5pRT commentedon Jul 2, 2019
From @tonycoz
open-temp-flags.diff
p5pRT commentedon Jul 2, 2019
The RT System itself - Status changed from 'new' to 'open'
p5pRT commentedon Jul 2, 2019
From e@80x24.org
Tony Cook via RT <perlbug-followup@perl.org> wrote:
Thanks, I can confirm "+>>" works and sets O_APPEND with your
patches on top of 82651ab on
my FreeBSD 11.2 system.
However, there's a regression:
"+>" (which previously worked and is documented) now fails
completely:
./perl -e 'open(my$fh, "+>", undef) or die "open: $ !"'
I couldn't even find the syscall being made via truss.
I have no clue about non-POSIX-ish stuff :x
p5pRT commentedon Jul 3, 2019
From @tonycoz
On Tue, 02 Jul 2019 00:18:35 -0700, e@80x24.org wrote:
Here's an updated patch.
Tony
p5pRT commentedon Jul 3, 2019
From @tonycoz
open-temp-flags2.diff
p5pRT commentedon Jul 3, 2019
From e@80x24.org
Tony Cook via RT <perlbug-followup@perl.org> wrote:
Looks good and confirmed both "+>" and "+>>" via truss output on
FreeBSD 11.2
p5pRT commentedon Jul 16, 2019
From @tonycoz
On Tue, 02 Jul 2019 18:34:26 -0700, e@80x24.org wrote:
Craig helped me out with the VMS support.
So:
ae73d7e append mode for POSIX-like systems
0424723 for Win32
74b421c and VMS now (sort of) uses the same mkostemp() code that POSIX-like systems do.
Tony
p5pRT commentedon Jul 16, 2019
@tonycoz - Status changed from 'open' to 'pending release'
p5pRT commentedon Jul 18, 2019
From @steve-m-hay
Unfortunately, this has broken VC++ builds on Windows (at least VC6 thru VC2015) - there is no O_ACCMODE here.
p5pRT commentedon Jul 19, 2019
From @tonycoz
On Thu, 18 Jul 2019 12:24:20 -0700, shay wrote:
Fixed by 52bd4b1.
Tony