Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH 5.005_57] Build-dependent #ifdefs in _thrdvar.h #184

Closed
p5pRT opened this issue Jul 13, 1999 · 1 comment
Closed

[PATCH 5.005_57] Build-dependent #ifdefs in _thrdvar.h #184

p5pRT opened this issue Jul 13, 1999 · 1 comment

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Jul 13, 1999

Migrated from rt.perl.org#989 (status was 'resolved')

Searchable as RT989$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jul 13, 1999

From domo@vo.lu

Perusing thrdvar.h, I see the comment

* Avoid build-specific #ifdefs here, like DEBUGGING. That way,
* we can keep binary compatibility of the curinterp structure */

but later I see precisely

#ifdef DEBUGGING
PERLVARI(Twatchaddr, char **, 0)
PERLVAR(Twatchok, char *)
#endif

This is a Bad Thing, no? Here's a patch to which gives both normal
and debugging perls the same curinterp structure, at the cost of
saddling all perls with a couple of variables that they may not use.

Setting aside threading #ifdefs, which can't be avoided,
5.005_03 does not have this problem -- although, like _57, it does
have #ifdef OP_IN_REGISTER. But, whatever that is, it's
sufficiently obscure not to matter AFAICT.

Inline Patch
--- thrdvar.h-as-received       Tue May 25 09:38:57 1999
+++ thrdvar.h   Tue Jul 13 12:15:19 1999
@@ -176,10 +176,10 @@
 PERLVARI(Treginterp_cnt,int,       0)  /* Whether `Regexp'
                                                   was interpolated. */
 PERLVARI(Treg_starttry,        char *,     0)  /* -Dr: where regtry was called.
 */
-#ifdef DEBUGGING
+
 PERLVARI(Twatchaddr,   char **,    0)
 PERLVAR(Twatchok,      char *)
-#endif
+

 /* Note that the variables below are all explicitly referenced in the code
  * as thr->whatever and therefore don't need the 'T' prefix. */
Perl Info


Site configuration information for perl 5.00557:

Configured by domo at Sat May 29 19:17:27 WET DST 1999.

Summary of my perl5 (revision 5.0 version 5 subversion 57) configuration:
  Platform:
    osname=machten, osvers=4.1.1, archname=powerpc-machten
    uname='machten ppp1 4 1.1 powerpc '
    config_args='-des'
    hint=recommended, useposix=true, d_sigaction=define
    usethreads=undef useperlio=undef d_sfio=undef
    use64bits=undef usemultiplicity=undef
  Compiler:
    cc='cc', optimize='-O2 -fomit-frame-pointer', gccversion=2.8.1
    cppflags='-DNOTDEF_MACHTEN -DREG_INFTY=2047'
    ccflags ='-DNOTDEF_MACHTEN -DREG_INFTY=2047'
    stdchar='char', d_stdstdio=undef, usevfork=true
    intsize=4, longsize=4, ptrsize=4, doublesize=8
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=8
    alignbytes=8, usemymalloc=y, prototype=define
  Linker and Libraries:
    ld='ld', ldflags =' -Xlstack=1048576 -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib
    libs=-lndbm -lgdbm -ldb -ldl -lm -lc
    libc=/usr/lib/libc.a, so=so, useshrplib=false, libperl=libperl.a
  Dynamic Linking:
    dlsrc=dl_none.xs, dlext=none, d_dlsymun=undef, ccdlflags=''
    cccdlflags='', lddlflags=''

Locally applied patches:
    


@INC for perl 5.00557:
    /usr/local/lib/perl5/5.00557/powerpc-machten
    /usr/local/lib/perl5/5.00557
    /usr/local/lib/perl5/site_perl/5.00557/powerpc-machten
    /usr/local/lib/perl5/site_perl/5.00557
    .


Environment for perl 5.00557:
    HOME=/home/domo
    LANG (unset)
    LANGUAGE (unset)
    LD_LIBRARY_PATH=/usr/lib
    LOGDIR (unset)
    PATH=/sbin:/usr/sbin:/home/domo/bin:/usr/local/bin:/usr/bin:/bin:/usr/X11/bin:/usr/libexec
    PERL_BADLANG (unset)
    SHELL=/bin/bash

-- 
Dominic Dunlop



Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant