[PATCH perl5.005_61] typo in perl.h

[p5pRT]

Migrated from rt.perl.org#1262 (status was 'resolved')

Searchable as RT1262$

[p5pRT]

From rmb1@cise.npl.co.uk

building perl5.005_61 with -Duse64bits, I had a compiler error
relating to IVSIZE not being declared. The following patch fixes
the problem. With this patch perl5.005_61 compiles and passes all
the test except op/lfs.t (large file system).

Robin

--- perl.h 1999/08/23 14​:40​:29 1.1
+++ perl.h 1999/08/23 14​:41​:20
@​@​ -1023,7 +1023,7 @​@​
# define UV_MAX PERL_UQUAD_MAX
# define UV_MIN PERL_UQUAD_MIN
# endif
-# define IVSIZF 8
+# define IVSIZE 8
# define UVSIZE 8
# define IV_IS_QUAD
# define UV_IS_QUAD

Perl Info

Site configuration information for perl 5.00561:

Configured by rmb1 at Mon Aug 23 15:44:46 BST 1999.

Summary of my perl5 (revision 5.0 version 5 subversion 61) configuration:
  Platform:
    osname=solaris, osvers=2.7, archname=sun4-solaris
    uname='sunos tempest 5.7 generic_106541-04 sun4u sparc sunw,ultra-5_10 '
    config_args='-Dcc=gcc -Doptimize=-O -g -Duseperlio -Dprefix=/opt/gnu -Duse64bits -Dman1dir=none -Dman3dir=none -Dcf_email=rmb1@cise.npl.co.uk -des'
    hint=recommended, useposix=true, d_sigaction=define
    usethreads=undef useperlio=define d_sfio=undef
    use64bits=define usemultiplicity=undef
  Compiler:
    cc='gcc', optimize='-O -g', gccversion=2.95.1 19990816 (release)
    cppflags='-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DUSE_LONG_LONG -DDEBUGGING -I/usr/local/include -I/opt/gnu/include'
    ccflags ='-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DUSE_LONG_LONG -DDEBUGGING -I/usr/local/include -I/opt/gnu/include'
    stdchar='char', d_stdstdio=define, usevfork=false
    intsize=4, longsize=4, ptrsize=4, doublesize=8
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
    alignbytes=8, usemymalloc=y, prototype=define
  Linker and Libraries:
    ld='gcc', ldflags ='  -L/usr/local/lib -L/opt/gnu/lib'
    libpth=/usr/local/lib /opt/gnu/lib /lib /usr/lib /usr/ccs/lib
    libs=-lsocket -lnsl -ldl -lm -lc -lcrypt -lsec
    libc=/lib/libc.so, so=so, useshrplib=false, libperl=libperl.a
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags=' '
    cccdlflags='-fPIC', lddlflags='-G -L/usr/local/lib -L/opt/gnu/lib'

Locally applied patches:
    


@INC for perl 5.00561:
    lib
    /home/rmb1/appl/lib/perl5/site_perl/5.005/sun4-solaris
    /home/rmb1/appl/lib/perl5/site_perl/5.005
    /opt/gnu/lib/perl5/5.00561/sun4-solaris
    /opt/gnu/lib/perl5/5.00561
    /opt/gnu/lib/site_perl/5.00561/sun4-solaris
    /opt/gnu/lib/site_perl
    .


Environment for perl 5.00561:
    HOME=/home/rmb1
    LANG=C
    LANGUAGE (unset)
    LD_LIBRARY_PATH=/usr/lib
    LOGDIR (unset)
    PATH=/home/rmb1/appl/script:/opt/gnu/script:/opt/gnu/bin:/usr/appl/script:/usr/local/appl/bin:/usr/tempest/bin:/usr/local/bin:/usr/local/Admigration/exec:/usr/local/hotjava/bin:/usr/openwin/bin:/usr/dt/bin:/usr/ccs/bin:/usr/bin
    PERL5LIB=/home/rmb1/appl/lib/perl5/site_perl/5.005
    PERL_BADLANG (unset)
    SHELL=/bin/csh

[p5pRT]

From @jhi

Robin Barker writes​:

This is a bug report for perl from rmb1@​cise.npl.co.uk,
generated with the help of perlbug 1.27 running under perl 5.00561.

-----------------------------------------------------------------
[Please enter your report here]

building perl5.005_61 with -Duse64bits, I had a compiler error
relating to IVSIZE not being declared. The following patch fixes
the problem. With this patch perl5.005_61 compiles and passes all
the test except op/lfs.t (large file system).

Robin

--- perl.h 1999/08/23 14​:40​:29 1.1
+++ perl.h 1999/08/23 14​:41​:20
@​@​ -1023,7 +1023,7 @​@​
# define UV_MAX PERL_UQUAD_MAX
# define UV_MIN PERL_UQUAD_MIN
# endif
-# define IVSIZF 8
+# define IVSIZE 8

Oops! Sorry. But many thanks for testing -Duse64bits.

When you say "passes all the tests except op/lfs.t", please be more
exact. Is the test skipped or does it fail? If the latter, please
run it separately​:

  cd t
  ./perl op/lfs.t

and tell us the output. Also, how did lib/syslfs.t test out?

--
$jhi++; # http​://www.iki.fi/jhi/
  # There is this special biologist word we use for 'stable'.
  # It is 'dead'. -- Jack Cohen

[p5pRT]

From [Unknown Contact. See original ticket]

From jhi@​cc.hut.fi Mon Aug 23 19​:38​:16 1999

-# define IVSIZF 8
+# define IVSIZE 8

Oops! Sorry. But many thanks for testing -Duse64bits.

When you say "passes all the tests except op/lfs.t", please be more
exact. Is the test skipped or does it fail? If the latter, please
run it separately​:

cd t
\./perl op/lfs\.t

and tell us the output. Also, how did lib/syslfs.t test out?

It does fail​:

% (cd t; ./perl op/lfs.t)
# 35651591 418361 33188 1 1061 1002 0 1000003 935489167 935489167 935489167 8192 32
# 35651591 418361 33188 1 1061 1002 0 705032707 935489167 935489167 935489167 8192 48
1..8
not ok 1
not ok 2
not ok 3
not ok 4
not ok 5
not ok 6
ok 7
ok 8

% (cd t; ./perl lib/syslfs.t)
# 35651591 418361 33188 1 1061 1002 0 1000003 935489207 935489207 935489207 8192 32
# 35651591 418361 33188 1 1061 1002 0 5000000003 935489207 935489207 935489207 8192 48
1..8
ok 1
ok 2
ok 3
ok 4
ok 5
ok 6
ok 7
ok 8

Robin

P.S. I also got the following strange result

% ./perl -lwe 'print scalar gmtime'
Tue Aug 103079215114 34359738391​:8585639624704​:935489303 0

I get the same effect with -Dccflags=-DBIG_TIME

[p5pRT]

From @jhi

Robin Barker writes​:

% (cd t; ./perl op/lfs.t)
# 35651591 418361 33188 1 1061 1002 0 1000003 935489167 935489167 935489167 8192 32
# 35651591 418361 33188 1 1061 1002 0 705032707 935489167 935489167 935489167 8192 48
1..8
not ok 1
not ok 2
not ok 3
not ok 4
not ok 5
not ok 6
ok 7
ok 8

The 705032707 indicates that truncation from 5 gigabytes to 32-bit worlds
took place.

On which filesystem and more importantly what kind of a filesystem did
you run the test? ufs? tmpfs? nfs?

% (cd t; ./perl lib/syslfs.t)
# 35651591 418361 33188 1 1061 1002 0 1000003 935489207 935489207 935489207 8192 32
# 35651591 418361 33188 1 1061 1002 0 5000000003 935489207 935489207 935489207 8192 48
1..8
ok 1
ok 2
ok 3
ok 4
ok 5
ok 6
ok 7
ok 8

Hmmm. lfs.t (which tests stdio, or its moral equivalent) fails,
but syslfs.t (which tests raw io) succeeds. Strange.

% ./perl -lwe 'print scalar gmtime'
Tue Aug 103079215114 34359738391​:8585639624704​:935489303 0

I get the same effect with -Dccflags=-DBIG_TIME

I will look into this, too. Looks like a printf problem.

--
$jhi++; # http​://www.iki.fi/jhi/
  # There is this special biologist word we use for 'stable'.
  # It is 'dead'. -- Jack Cohen

[p5pRT]

From @jhi

On which filesystem and more importantly what kind of a filesystem did
you run the test? ufs? tmpfs? nfs?

What does mount(1) show for the filesystem?

--
$jhi++; # http​://www.iki.fi/jhi/
  # There is this special biologist word we use for 'stable'.
  # It is 'dead'. -- Jack Cohen

[p5pRT]

From @jhi

Robin Barker writes​:

P.S. I also got the following strange result

% ./perl -lwe 'print scalar gmtime'
Tue Aug 103079215114 34359738391​:8585639624704​:935489303 0

Fixed in _62.

--
$jhi++; # http​://www.iki.fi/jhi/
  # There is this special biologist word we use for 'stable'.
  # It is 'dead'. -- Jack Cohen