Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2p does not quote @ #501

p5pRT opened this issue Sep 8, 1999 · 1 comment

s2p does not quote @ #501

p5pRT opened this issue Sep 8, 1999 · 1 comment


Copy link

@p5pRT p5pRT commented Sep 8, 1999

Migrated from (status was 'resolved')

Searchable as RT1347$

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 8, 1999


s2p does not quote @​ when it appears in a sed script. I think the following
patch fixes the problem correctly​:

Inline Patch
--- /usr/bin/s2p        Thu Aug 19 10:30:03 1999
+++ s2p Wed Sep  8 18:16:14 1999
@@ -518,7 +518,11 @@
                    elsif ($repl && substr($_,$i,1) =~ /^\d$/) {
                        substr($_,$i-1,1) = '$';
-               }
+               }elsif ($c eq '@') {
+                    substr($_, $i, 0) = '\\';
+                    $i++;
+                    $len++;
+                }
                elsif ($c eq '&' && $repl) {
                    substr($_, $i, 0) = '$';
@@ -764,6 +768,7 @@
     $addr =~ s/\t/\\t/g;
+    $addr =~ s/\@/\\@/g;

a simple test case is simply



Perl Info

Site configuration information for perl 5.00503:

Configured by darren at Thu Aug 19 01:13:41 PDT 1999.

Summary of my perl5 (5.0 patchlevel 5 subversion 3) configuration:
    osname=linux, osvers=2.0.36, archname=i386-linux
    uname='linux broca 2.0.36 #2 sun nov 29 02:38:59 pst 1998 i686 unknown '
    hint=recommended, useposix=true, d_sigaction=define
    usethreads=undef useperlio=undef d_sfio=undef
    cc='cc', optimize='-O2', gccversion=2.95.1 19990809 (prerelease)
    cppflags='-Dbool=char -DHAS_BOOL -D_REENTRANT -DDEBIAN -I/usr/local/include'
    ccflags ='-Dbool=char -DHAS_BOOL -D_REENTRANT -DDEBIAN -I/usr/local/include'
    stdchar='char', d_stdstdio=undef, usevfork=false
    intsize=4, longsize=4, ptrsize=4, doublesize=8
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    alignbytes=4, usemymalloc=n, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -L/usr/local/lib'
    libpth=/usr/local/lib /lib /usr/lib
    libs=-lnsl -lndbm -lgdbm -ldbm -ldb -ldl -lm -lc -lposix -lcrypt
    libc=, so=so, useshrplib=false, libperl=libperl.a
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-rdynamic'
    cccdlflags='-fpic', lddlflags='-shared -L/usr/local/lib'

Locally applied patches:

@INC for perl 5.00503:

Environment for perl 5.00503:
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PERL_BADLANG (unset)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.