Badly defined croak() in malloc.c (does not affect perl itself)

[p5pRT]

Migrated from rt.perl.org#1670 (status was 'resolved')

Searchable as RT1670$

[p5pRT]

From sampo@mail.neuronio.pt

The croak macro is badly defined such that code like

  if (error)
  croak("%d", errno);

expands to

  if (error)
  warn("%d", errno);
  exit(1); /* This exit should not happen! */

--Sampo

diff -c malloc.c.orig malloc.c
*** malloc.c.orig Thu Oct 21 11​:46​:52 1999
--- malloc.c Thu Oct 21 11​:48​:21 1999
***************
*** 206,212 ****
  # define PerlIO_stderr() stderr
  # endif
  # ifndef croak /* make depend */
! # define croak(mess, arg) warn((mess), (arg)); exit(1);
  # endif
  # ifndef warn
  # define warn(mess, arg) fprintf(stderr, (mess), (arg));
--- 206,212 ----
  # define PerlIO_stderr() stderr
  # endif
  # ifndef croak /* make depend */
! # define croak(mess, arg) do{ warn((mess), (arg)); exit(1); }while(0)
  # endif
  # ifndef warn
  # define warn(mess, arg) fprintf(stderr, (mess), (arg));