Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 problems with File::Spec::Win32 #855

Closed
p5pRT opened this issue Nov 15, 1999 · 3 comments
Closed

2 problems with File::Spec::Win32 #855

p5pRT opened this issue Nov 15, 1999 · 3 comments

Comments

@p5pRT
Copy link
Collaborator

@p5pRT p5pRT commented Nov 15, 1999

Migrated from rt.perl.org#1785 (status was 'resolved')

Searchable as RT1785$

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Nov 15, 1999

From MEL@DISC.com

1. rel2abs goes into an infinite loop if the $base parameter is omitted.
2. canonpath does not support the optional $reduce_ricochet parameter.

Mark Lofdahl
mel@​disc.com

Summary of my perl5 (5.0 patchlevel 5 subversion 03) configuration​:
  Platform​:
  osname=MSWin32, osvers=4.0, archname=MSWin32-x86-object
  uname=''
  hint=recommended, useposix=true, d_sigaction=undef
  usethreads=undef useperlio=undef d_sfio=undef
  Compiler​:
  cc='cl.exe', optimize='-O2 -MD -DNDEBUG -TP -GX', gccversion=
  cppflags='-DWIN32'
  ccflags ='-O2 -MD -DNDEBUG -TP -GX -DWIN32 -D_CONSOLE -DNO_STRICT
-DHAVE_DE
S_FCRYPT -DPERL_OBJECT'
  stdchar='char', d_stdstdio=define, usevfork=false
  intsize=4, longsize=4, ptrsize=4, doublesize=8
  d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=10
  alignbytes=8, usemymalloc=n, prototype=define
  Linker and Libraries​:
  ld='link', ldflags ='-nologo -nodefaultlib -release
-libpath​:"C​:\perl\50050
3a\lib\MSWin32-x86-object\CORE" -machine​:x86'
  libpth=C​:\PROGRA1\MICROS2\VC98\lib
  libs= oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib
comdlg32.
lib advapi32.lib shell32.lib ole32.lib oleaut32.lib netapi32.lib uuid.lib
wsock
32.lib mpr.lib winmm.lib version.lib odbc32.lib odbccp32.lib PerlCRT.lib
  libc=PerlCRT.lib, so=dll, useshrplib=yes, libperl=perlcore.lib
  Dynamic Linking​:
  dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
  cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -release
-libpath​:"C​:
\perl\500503a\lib\MSWin32-x86-object\CORE" -machine​:x86'

Characteristics of this binary (from libperl)​:
  Locally applied patches​:
  ActivePerl Build 521
  Built under MSWin32
  Compiled at Nov 1 1999 10​:12​:05
  %ENV​:
  PERL5LIB="D​:/newqa/lib"
  PERL5OPT="-w"
  PERL5SHELL="sh"
  @​INC​:
  D​:/newqa/lib
  c​:/perl/500503a/lib/MSWin32-x86-object
  c​:/perl/500503a/lib
  c​:/perl/site/500503a/lib

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Nov 15, 1999

From [Unknown Contact. See original ticket]

Mark Lofdahl wrote​:

As I've been working with File​::Spec​::Win32, I've noticed a couple problems​:

Thanks for the bug report, I'll look in to them. You show 5.005_03, but
the bugs you're reporting are in code not in that version. Is this
an ActiveState Build 521 issue, or are you (I hope) using development
version?

1. rel2abs goes into an infinite loop if the $base parameter is omitted.

I'll look in to this. rel2abs() should call cwd() in this case.

2. canonpath does not support the optional $reduce_ricochet parameter.

The canonpath() family support for $reduce_ricochet should not yet be
in any stable version of perl, and there was some discussion of having
two entry points instead, with mincanonpath() doing s{name/../?}{}
reductions after calling canonpath().

Any votes from the p5p crew on this issue?

Also, should I patch abs2rel() and rel2abs() to have a calling convention
(parameter order) more similar to catdir() and catfile()?

Barrie

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Nov 15, 1999

From @gsar

On Mon, 15 Nov 1999 17​:59​:15 EST, Barrie Slaymaker wrote​:

Mark Lofdahl wrote​:

As I've been working with File​::Spec​::Win32, I've noticed a couple problems​:

Thanks for the bug report, I'll look in to them. You show 5.005_03, but
the bugs you're reporting are in code not in that version. Is this
an ActiveState Build 521 issue, or are you (I hope) using development
version?

Build 520 and later have the File​::Spec from 5.005_5x (needed, IIRC, for
the newer Pod​::Html from 5.005_5x that was critical for generating
well-formed HTML).

2. canonpath does not support the optional $reduce_ricochet parameter.

The canonpath() family support for $reduce_ricochet should not yet be
in any stable version of perl, and there was some discussion of having
two entry points instead, with mincanonpath() doing s{name/../?}{}
reductions after calling canonpath().

Any votes from the p5p crew on this issue?

Two entry points works for me.

Also, should I patch abs2rel() and rel2abs() to have a calling convention
(parameter order) more similar to catdir() and catfile()?

What's I see in there looks fine.

Sarathy
gsar@​ActiveState.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.