ExtUtils::Install resets umask after writing .packlist #907
Comments
From goevert@amaunet.cs.uni-dortmund.deExtUtils::Install::install resets umask after writing .packlist. [goevert@gamgee] gdiff -u /app/unido-i06-src/lang/perl/5.005_62/perl5.005_62/lib/ExtUtils/Install.pm /app/unido-i06/sun4_56/lang/perl/5.005_62/lib/ExtUtils/Install.pm Inline Patch--- /app/unido-i06-src/lang/perl/5.005_62/perl5.005_62/lib/ExtUtils/Install.pm Sat Sep 4 22:01:50 1999
+++ /app/unido-i06/sun4_56/lang/perl/5.005_62/lib/ExtUtils/Install.pm Wed Dec 1 18:36:55 1999
@@ -134,13 +134,13 @@
}, ".");
chdir($cwd) or Carp::croak("Couldn't chdir to $cwd: $!");
}
+ umask $umask unless $Is_VMS;
if ($pack{'write'}) {
$dir = dirname($pack{'write'});
mkpath($dir,0,0755);
print "Writing $pack{'write'}\n";
$packlist->write($pack{'write'});
}
- umask $umask unless $Is_VMS;
}
sub directory_not_empty ($) { Perl Info
|
From [Unknown Contact. See original ticket]I got a better idea: Why not simply remove all uses of umask from all I know I'm constantly irritated by the need to go through the install |
From @doughera88On Wed, 1 Dec 1999, Tom Horsley wrote:
I'd tend to agree with that. There are undoubtedly some cases where Specific counter-examples welcome. Andy Dougherty doughera@lafayette.edu |
From [Unknown Contact. See original ticket]Andy Dougherty <doughera@lafayette.edu> writes:
I seem to remember from a long time ago that there were a lot of clueless That said I see no reason why Configure could not ask: "Should I honour your umask (currently 060) during installs?" -- |
From @gsarOn Wed, 01 Dec 1999 20:58:02 GMT, Nick Ing-Simmons wrote:
Here's what I've done about this. I'd agree that users should get a warning on suspect umask values, Sarathy Inline Patch-----------------------------------8<-----------------------------------
Change 4632 by gsar@auger on 1999/12/03 07:42:23
don't mess with the umask()
Affected files ...
... //depot/perl/installhtml#13 edit
... //depot/perl/installman#15 edit
... //depot/perl/installperl#45 edit
... //depot/perl/lib/ExtUtils/Install.pm#17 edit
... //depot/perl/lib/ExtUtils/Manifest.pm#10 edit
Differences ...
==== //depot/perl/installhtml#13 (xtext) ====
Index: perl/installhtml
--- perl/installhtml.~1~ Thu Dec 2 23:42:26 1999
+++ perl/installhtml Thu Dec 2 23:42:26 1999
@@ -9,8 +9,6 @@
use Cwd;
use Pod::Html;
-umask 022;
-
=head1 NAME
installhtml - converts a collection of POD pages to HTML format.
==== //depot/perl/installman#15 (xtext) ====
Index: perl/installman
--- perl/installman.~1~ Thu Dec 2 23:42:26 1999
+++ perl/installman Thu Dec 2 23:42:26 1999
@@ -10,7 +10,6 @@
use vars qw($packlist);
require Cwd;
-umask 022;
$ENV{SHELL} = 'sh' if $^O eq 'os2';
$ver = $];
==== //depot/perl/installperl#45 (xtext) ====
Index: perl/installperl
--- perl/installperl.~1~ Thu Dec 2 23:42:26 1999
+++ perl/installperl Thu Dec 2 23:42:26 1999
@@ -54,8 +54,6 @@
shift;
}
-umask 022 unless $Is_VMS;
-
my @scripts = qw(utils/c2ph utils/h2ph utils/h2xs utils/perlbug utils/perldoc
utils/pl2pm utils/splain utils/perlcc utils/dprofpp
x2p/s2p x2p/find2perl
==== //depot/perl/lib/ExtUtils/Install.pm#17 (text) ====
Index: perl/lib/ExtUtils/Install.pm
--- perl/lib/ExtUtils/Install.pm.~1~ Thu Dec 2 23:42:26 1999
+++ perl/lib/ExtUtils/Install.pm Thu Dec 2 23:42:26 1999
@@ -67,7 +67,6 @@
}
$packlist->read($pack{"read"}) if (-f $pack{"read"});
my $cwd = cwd();
- my $umask = umask 0 unless $Is_VMS;
my($source);
MOD_INSTALL: foreach $source (sort keys %hash) {
@@ -140,7 +139,6 @@
print "Writing $pack{'write'}\n";
$packlist->write($pack{'write'});
}
- umask $umask unless $Is_VMS;
}
sub directory_not_empty ($) {
@@ -259,7 +257,6 @@
close(FROMTO);
}
- my $umask = umask 0022 unless $Is_VMS;
mkpath($autodir,0,0755);
foreach (keys %$fromto) {
next if -f $fromto->{$_} && -M $fromto->{$_} < -M $_;
@@ -280,7 +277,6 @@
next unless /\.pm$/;
autosplit($fromto->{$_},$autodir);
}
- umask $umask unless $Is_VMS;
}
package ExtUtils::Install::Warn;
==== //depot/perl/lib/ExtUtils/Manifest.pm#10 (text) ====
Index: perl/lib/ExtUtils/Manifest.pm
--- perl/lib/ExtUtils/Manifest.pm.~1~ Thu Dec 2 23:42:26 1999
+++ perl/lib/ExtUtils/Manifest.pm Thu Dec 2 23:42:26 1999
@@ -187,7 +187,6 @@
require File::Basename;
my(%dirs,$file);
$target = VMS::Filespec::unixify($target) if $Is_VMS;
- umask 0 unless $Is_VMS;
File::Path::mkpath([ $target ],1,$Is_VMS ? undef : 0755);
foreach $file (keys %$read){
$file = VMS::Filespec::unixify($file) if $Is_VMS;
End of Patch. |
Migrated from rt.perl.org#1842 (status was 'resolved')
Searchable as RT1842$
The text was updated successfully, but these errors were encountered: