perl_call_pv definition wrong

[p5pRT]

Migrated from rt.perl.org#1857 (status was 'resolved')

Searchable as RT1857$

[p5pRT]

From lars.krueger@daimlerchrysler.com

-----------------------------------------------------------------
The definition of
I32 perl_call_pv(char *subname, I32 flags) ;
is wrong in my optinion.

It should be
I32 perl_call_pv( const char *subname, I32 flags) ;
as it does not modify the given string. (I would be disappointed if it does.
:-) )

This bug causes only warnings and is more a stylistic problem than a functional
one.

The same applies to perl_call_method and perl_call_argv and propably some other
functions.

Perl Info

Site configuration information for perl 5.00502:

Summary of my perl5 (5.0 patchlevel 5 subversion 02) configuration:
  Platform:
    osname=MSWin32, osvers=4.0, archname=MSWin32-x86-object
    uname=''
    hint=recommended, useposix=true, d_sigaction=undef
    usethreads=undef useperlio=undef d_sfio=undef
  Compiler:
    cc='cl.exe', optimize='-O2 -MD -DNDEBUG -TP -GX', gccversion=
    cppflags='-DWIN32'
    ccflags ='-O2 -MD -DNDEBUG -TP -GX -DWIN32 -D_CONSOLE -DNO_STRICT
-DHAVE_DES_FCRYPT -DPERL_OBJECT'
    stdchar='char', d_stdstdio=define, usevfork=false
    intsize=4, longsize=4, ptrsize=4, doublesize=8
    d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=10
    alignbytes=8, usemymalloc=n, prototype=define
  Linker and Libraries:
    ld='link', ldflags ='-nologo -nodefaultlib -release -machine:x86'
    libpth="C:\Perl\lib\core"
    libs= oldnames.lib kernel32.lib user32.lib gdi32.lib  winspool.lib
comdlg32.lib advapi32.lib shell32.lib ole32.lib  oleaut32.lib netapi32.lib
uuid.lib wsock32.lib mpr.lib winmm.lib  version.lib odbc32.lib odbccp32.lib
PerlCRT.lib
    libc=C:\Perl\lib\core\PerlCRT.lib, so=dll, useshrplib=yes,
libperl=perlcore.lib
  Dynamic Linking:
    dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
    cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -release
-machine:x86'

Locally applied patches:
    ACTIVEPERL_LOCAL_PATCHES_ENTRY


@INC for perl 5.00502:
    C:\PERL\lib
    C:\PERL\site\lib
    .


Environment for perl 5.00502:
    HOME (unset)
    LANG (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=C:\PERL\BIN
    PERL_BADLANG (unset)
    SHELL (unset)

[p5pRT]

From @gsar

On Mon, 06 Dec 1999 10​:54​:44 +0100, Lars Krueger wrote​:

The definition of
I32 perl_call_pv(char *subname, I32 flags) ;
is wrong in my optinion.

It should be
I32 perl_call_pv( const char *subname, I32 flags) ;
as it does not modify the given string. (I would be disappointed if it does.
​:-) )

You'll be happy to find that this has been fixed for the upcoming v5.6.

Sarathy
gsar@​ActiveState.com