Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enc2xs -C scans the current directory #9202

Closed
p5pRT opened this issue Jan 22, 2008 · 6 comments
Closed

enc2xs -C scans the current directory #9202

p5pRT opened this issue Jan 22, 2008 · 6 comments

Comments

@p5pRT
Copy link
Collaborator

@p5pRT p5pRT commented Jan 22, 2008

Migrated from rt.perl.org#50116 (status was 'rejected')

Searchable as RT50116$

@p5pRT
Copy link
Collaborator Author

@p5pRT p5pRT commented Jan 22, 2008

From mls@suse.de

Created by mls@suse.de

'enc2xs -C' calls File​::Find​::find for all entries of @​INC, which
also contains '.'. It should filter out '.'.

Suggested patch​:

Inline Patch
--- ./ext/Encode/bin/enc2xs.orig	2007-12-18 10:47:07.000000000 +0000
+++ ./ext/Encode/bin/enc2xs	2008-01-18 14:28:14.000000000 +0000
@@ -1005,13 +1005,13 @@ sub make_configlocal_pm {
 	    $LocalMod{$enc} ||= $mod;
 	}
     };
-    File::Find::find({wanted => $wanted}, @INC);
+    File::Find::find({wanted => $wanted}, grep {$_ ne '.'} @INC);
     $_ModLines = "";
     for my $enc ( sort keys %LocalMod ) {
         $_ModLines .=
           qq(\$Encode::ExtModule{'$enc'} = "$LocalMod{$enc}";\n);
     }
-    warn $_ModLines;
+    warn $_ModLines if $_ModLines ne '';
     $_LocalVer = _mkversion();
     $_E2X      = find_e2x();
     $_Inc      = $INC{"Encode.pm"};
Perl Info

Flags:
    category=core
    severity=low

This perlbug was built using Perl 5.10.0 - Sat Jan 19 16:41:23 UTC 2008
It is being executed now by  Perl 5.10.0 - Sat Jan 19 16:36:48 UTC 2008.

Site configuration information for perl 5.10.0:

Configured by abuild at Sat Jan 19 16:36:48 UTC 2008.

Summary of my perl5 (revision 5 version 10 subversion 0) configuration:
  Platform:
    osname=linux, osvers=2.6.23, archname=x86_64-linux-thread-multi
    uname='linux e75 2.6.23 #1 smp 20071119 15:02:58 utc x86_64 x86_64 x86_64 gnulinux '
    config_args='-ds -e -Dprefix=/usr -Dvendorprefix=/usr -Dinstallusrbinperl -Dusethreads -Di_db -Di_dbm -Di_ndbm -Di_gdbm -Duseshrplib=true -Doptimize=-O2 -fmessage-length=0 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -g -Wall -pipe'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=define, usemultiplicity=define
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=define, use64bitall=define, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING -fno-strict-aliasing -pipe -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-O2 -fmessage-length=0 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -g -Wall -pipe',
    cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING -fno-strict-aliasing -pipe'
    ccversion='', gccversion='4.3.0 20080117 (experimental) [trunk revision 131592]', gccosandvers=''
    intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
    ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -L/usr/local/lib64'
    libpth=/lib64 /usr/lib64 /usr/local/lib64
    libs=-lm -ldl -lcrypt -lpthread
    perllibs=-lm -ldl -lcrypt -lpthread
    libc=/lib64/libc-2.7.so, so=so, useshrplib=true, libperl=libperl.so
    gnulibc_version='2.7'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E -Wl,-rpath,/usr/lib/perl5/5.10.0/x86_64-linux-thread-multi/CORE'
    cccdlflags='-fPIC', lddlflags='-shared -L/usr/local/lib64'

Locally applied patches:
    


@INC for perl 5.10.0:
    /usr/lib/perl5/5.10.0/x86_64-linux-thread-multi
    /usr/lib/perl5/5.10.0
    /usr/lib/perl5/site_perl/5.10.0/x86_64-linux-thread-multi
    /usr/lib/perl5/site_perl/5.10.0
    /usr/lib/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.10.0
    /usr/lib/perl5/vendor_perl
    .


Environment for perl 5.10.0:
    HOME=/suse/mls
    LANG (unset)
    LANGUAGE (unset)
    LC_COLLATE=POSIX
    LC_CTYPE=de_DE@euro
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/suse/mls/bin:/opt/kde3/bin:/usr/local/bin:/usr/bin:/usr/sbin:/sbin:/usr/X11R6/bin:/bin:/usr/lib/java/bin:/usr/games/bin:/usr/games:/opt/gnome/bin:/opt/kde/bin:/usr/openwin/bin:/opt/pilotsdk/bin:/suse/mls/korn
    PERL_BADLANG (unset)
    SHELL=/bin/tcsh

@p5pRT
Copy link
Collaborator Author

@p5pRT p5pRT commented Jan 4, 2012

From @jkeenan

On Tue Jan 22 10​:31​:50 2008, mls@​suse.de wrote​:

'enc2xs -C' calls File​::Find​::find for all entries of @​INC, which
also contains '.'. It should filter out '.'.

Suggested patch​:

--- ./ext/Encode/bin/enc2xs.orig 2007-12-18 10​:47​:07.000000000 +0000
+++ ./ext/Encode/bin/enc2xs 2008-01-18 14​:28​:14.000000000 +0000
@​@​ -1005,13 +1005,13 @​@​ sub make_configlocal_pm {
$LocalMod{$enc} ||= $mod;
}
};
- File​::Find​::find({wanted => $wanted}, @​INC);
+ File​::Find​::find({wanted => $wanted}, grep {$_ ne '.'} @​INC);
$_ModLines = "";
for my $enc ( sort keys %LocalMod ) {
$_ModLines .=
qq(\$Encode​::ExtModule{'$enc'} = "$LocalMod{$enc}";\n);
}
- warn $_ModLines;
+ warn $_ModLines if $_ModLines ne '';
$_LocalVer = _mkversion();
$_E2X = find_e2x();
$_Inc = $INC{"Encode.pm"};

Encode is now maintained on CPAN, and this bug has, since the original
report, been posted to that distribution's bug queue on rt.cpan.org​:

https://rt.cpan.org/Public/Bug/Display.html?id=64585

Can this ticket be closed?

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Collaborator Author

@p5pRT p5pRT commented Jan 4, 2012

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Collaborator Author

@p5pRT p5pRT commented Jan 4, 2012

From @cpansprout

On Tue Jan 03 18​:15​:02 2012, jkeenan wrote​:

On Tue Jan 22 10​:31​:50 2008, mls@​suse.de wrote​:

'enc2xs -C' calls File​::Find​::find for all entries of @​INC, which
also contains '.'. It should filter out '.'.

Suggested patch​:

--- ./ext/Encode/bin/enc2xs.orig 2007-12-18 10​:47​:07.000000000 +0000
+++ ./ext/Encode/bin/enc2xs 2008-01-18 14​:28​:14.000000000 +0000
@​@​ -1005,13 +1005,13 @​@​ sub make_configlocal_pm {
$LocalMod{$enc} ||= $mod;
}
};
- File​::Find​::find({wanted => $wanted}, @​INC);
+ File​::Find​::find({wanted => $wanted}, grep {$_ ne '.'} @​INC);
$_ModLines = "";
for my $enc ( sort keys %LocalMod ) {
$_ModLines .=
qq(\$Encode​::ExtModule{'$enc'} = "$LocalMod{$enc}";\n);
}
- warn $_ModLines;
+ warn $_ModLines if $_ModLines ne '';
$_LocalVer = _mkversion();
$_E2X = find_e2x();
$_Inc = $INC{"Encode.pm"};

Encode is now maintained on CPAN, and this bug has, since the original
report, been posted to that distribution's bug queue on rt.cpan.org​:

https://rt.cpan.org/Public/Bug/Display.html?id=64585

Can this ticket be closed?

Yes.

Thank you very much.
Jim Keenan

--

Father Chrysostomos

@p5pRT
Copy link
Collaborator Author

@p5pRT p5pRT commented Jan 4, 2012

From [Unknown Contact. See original ticket]

On Tue Jan 03 18​:15​:02 2012, jkeenan wrote​:

On Tue Jan 22 10​:31​:50 2008, mls@​suse.de wrote​:

'enc2xs -C' calls File​::Find​::find for all entries of @​INC, which
also contains '.'. It should filter out '.'.

Suggested patch​:

--- ./ext/Encode/bin/enc2xs.orig 2007-12-18 10​:47​:07.000000000 +0000
+++ ./ext/Encode/bin/enc2xs 2008-01-18 14​:28​:14.000000000 +0000
@​@​ -1005,13 +1005,13 @​@​ sub make_configlocal_pm {
$LocalMod{$enc} ||= $mod;
}
};
- File​::Find​::find({wanted => $wanted}, @​INC);
+ File​::Find​::find({wanted => $wanted}, grep {$_ ne '.'} @​INC);
$_ModLines = "";
for my $enc ( sort keys %LocalMod ) {
$_ModLines .=
qq(\$Encode​::ExtModule{'$enc'} = "$LocalMod{$enc}";\n);
}
- warn $_ModLines;
+ warn $_ModLines if $_ModLines ne '';
$_LocalVer = _mkversion();
$_E2X = find_e2x();
$_Inc = $INC{"Encode.pm"};

Encode is now maintained on CPAN, and this bug has, since the original
report, been posted to that distribution's bug queue on rt.cpan.org​:

https://rt.cpan.org/Public/Bug/Display.html?id=64585

Can this ticket be closed?

Yes.

Thank you very much.
Jim Keenan

--

Father Chrysostomos

@p5pRT
Copy link
Collaborator Author

@p5pRT p5pRT commented Jan 4, 2012

@cpansprout - Status changed from 'open' to 'rejected'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.