-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem and "solution" for building 5.10.0 with win32+mingw+dmake #9246
Comments
From k.a.skotheim@usit.uio.noCreated by kjetilsk@usit.uio.noProblem and "solution" for building perl-5.10.0 with Win32+MinGW+dmake ' ' ' ' ' ' ' ' ' ' ' ' Problem: ' ' ' ' ' ' ' ' ' ' ' ' ' ' ' ' ' ' C:\download\perl-5.10.0\win32> dmake -f makefile.mk C:\download\perl-5.10.0\win32> As you can see the problem started in mkppport with: ' ' ' ' ' ' ' ' ' ' ' ' A solution, sort of: ' ' ' ' ' ' ' ' ' ' ' ' ' ' ' The complaint about 'cd"' came from sub _os2_cwd in lib/Cwd.pm What is it doing in _os2_cwd? I changed: *_NT_cwd = defined &Win32::GetCwd ? \&_win32_cwd : \&_os2_cwd; To: *_NT_cwd = \&_win32_cwd; On line 681 in lib/Cwd.pm I understand that this is not a correct solition for the os2-folks, but it dmake -f makefile.mk I did not have the same problem building 5.8.8 on the same computer using Keep up the good work! Perl is fantastic! Perl Info
|
From @janduboisOn Sun, 09 Mar 2008, Kjetil Skotheim (via RT) wrote:
The code should indeed run through _win32_cwd instead of _os2_cwd, The real question is: where does the spurious double-quote come from? Cheers, |
The RT System itself - Status changed from 'new' to 'open' |
From b244145@tyldd.comOn Sun Mar 09 21:30:57 2008, jdb wrote:
the cd" comes from _os2_cwd sub _os2_cwd { i believe perl adds "" quotes when invoking the shell, D:\>cmd "/c cd" Since miniperl doesn't have dynaloader, doesn't have Win32, better patch *_NT_cwd = $^O eq 'os2' ? \&_os2_cwd : \&_win32_cwd ; since $^O eq 'os2' is already used other places in Cwd |
From @kmxHi Jan and Kjetil, I have experienced exactly the same problem with Cwd while building 1) I propose slightly different patch that is IMHO a little bit safer. 2) The question remains why this peace of code ... my $d=`cmd /c cd`; ... works on 5.8.9/Win32 however does not work on 5.10|5.11/Win32 - was -- |
From @kmxcwd_patch.diffdiff -r -u perl-5.11.1.orig/cpan/Cwd/Cwd.pm perl-5.11.1/cpan/Cwd/Cwd.pm
--- perl-5.11.1.orig/cpan/Cwd/Cwd.pm 2009-10-20 15:40:16.000000000 +0200
+++ perl-5.11.1/cpan/Cwd/Cwd.pm 2009-10-22 13:55:26.828948900 +0200
@@ -747,6 +747,13 @@
return $ENV{'PWD'};
}
+sub _win32_cwd_simple {
+ $ENV{'PWD'} = `cd`;
+ chomp $ENV{'PWD'};
+ $ENV{'PWD'} =~ s:\\:/:g ;
+ return $ENV{'PWD'};
+}
+
sub _win32_cwd {
if (eval 'defined &DynaLoader::boot_DynaLoader') {
$ENV{'PWD'} = Win32::GetCwd();
@@ -758,7 +765,7 @@
return $ENV{'PWD'};
}
-*_NT_cwd = defined &Win32::GetCwd ? \&_win32_cwd : \&_os2_cwd;
+*_NT_cwd = defined &Win32::GetCwd ? \&_win32_cwd : \&_win32_cwd_simple;
sub _dos_cwd {
if (!defined &Dos::GetCwd) {
|
From @kmxI have just noticed a post by uservolk(at)mail.ru to p5p list exactly on The important conclusion I have discovered when dealing with this The problem is that the file "c:\MSYS\bin\cmd" (in fact script) is Anyway I still think that a patch I have proposed in my previous post to -- |
From @cpansproutOn Thu Oct 22 05:08:29 2009, kmxx wrote:
Thank you. Applied as 8440aeb. |
@cpansprout - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#51562 (status was 'resolved')
Searchable as RT51562$
The text was updated successfully, but these errors were encountered: