Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/CGI/t/util-58.t skewed to suppress a bug #9702

Closed
p5pRT opened this issue Apr 6, 2009 · 4 comments
Closed

lib/CGI/t/util-58.t skewed to suppress a bug #9702

p5pRT opened this issue Apr 6, 2009 · 4 comments

Comments

@p5pRT
Copy link

@p5pRT p5pRT commented Apr 6, 2009

Migrated from rt.perl.org#64502 (status was 'resolved')

Searchable as RT64502$

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Apr 6, 2009

From skasal@redhat.com

Hello,
as of now, git log lib/CGI/t/util-58.t in blead shows two commits.
The latter one, from 2006, is incorrect.

The right way to escape a Unicode string is to encode it in UTF-8 and
then escape each byte. That test checks that. The output should not
depend on whether the platform is ASCII or EBCDIC.

Please return to the original version of t/util-58.t, as found in
CGI.pm-3.29 or CGI.pm-3.42 tarballs.

If the test fails on EBCDIC platforms, skip it, admitting that "CGI does
not work with Unicode strings on EBCDIC platforms (yet)."

Actually, there is a chance that the test will work on EBCDIC platforms
as soon as the following bug gets fixed
https://rt.cpan.org/Public/Bug/Display.html?id=34528

(If we are lucky, the patch submitted there might get into CGI.pm-3.43.)

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jul 24, 2009

From p5p@spam.wizbit.be

On Mon Apr 06 09​:21​:03 2009, kasal wrote​:

Please return to the original version of t/util-58.t, as found in
CGI.pm-3.29 or CGI.pm-3.42 tarballs

This was reverted when CGI.pm-3.43 was integrated.

http​://perl5.git.perl.org/perl.git/commit/
ad6402b

Upgrade to CGI.pm-3.43
author Steve Peters <steve@​fisharerojo.org>
  Mon, 13 Apr 2009 13​:56​:36 +0000 (08​:56 -0500)
committer Steve Peters <steve@​fisharerojo.org>
  Mon, 13 Apr 2009 13​:56​:36 +0000 (08​:56 -0500)
commit ad6402b
tree ed68a8d978ad55cbc5b60f8f64aa93d2ffba9a2f tree | snapshot
parent c14f59c commit | diff

Best regards,

Bram

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jul 24, 2009

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

@p5pRT p5pRT commented Jul 24, 2009

p5p@spam.wizbit.be - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this Jul 24, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant