Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made string multiplication more clear in perlintro #17335

Closed
wants to merge 1 commit into from

Conversation

Permik
Copy link
Contributor

@Permik Permik commented Dec 1, 2019

Added "repeats strings" in parenthesis to make it more unambiguous.

Added "repeats strings" in parenthesis to make it more unambiguous.
@khwilliamson
Copy link
Contributor

I'll merge this as soon as we figure out how to show @Permik as a Perl5 contributor. We have always used email addresses, but the one that Perlmik is listed as having is not valid. We should have a way to specify github ids. I refer to this problem in:

#17206 (comment)

@tonycoz
Copy link
Contributor

tonycoz commented Jan 6, 2020

but the one that Perlmik is listed as having is not valid

I see an email address of permik@users.noreply.github.com which seems valid to me (though not deliverable). I doubt it would be the only undeliverable address in AUTHORS.

@Permik
Copy link
Contributor Author

Permik commented Jan 7, 2020

I've since added an email to my profile and you can that as the email.
But it's great that this issue has been identified.

jkeenan pushed a commit that referenced this pull request Jan 7, 2020
Added "repeats strings" in parenthesis to make it more unambiguous.

Santtu Ojanperä is now a Perl author.

For: #17335
@jkeenan
Copy link
Contributor

jkeenan commented Jan 7, 2020

Picked up contributor's email address from GH profile; added it to p.r. and AUTHORS. Pushed to blead in commit a3d126f.

Thank you very much.
Jim Keenan

@jkeenan jkeenan closed this Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants