Skip to content

Document postderef_qq support for ->$#* interpolation#20049

Closed
zmughal wants to merge 1 commit intoPerl:bleadfrom
zmughal-contrib:doc-postfix-array-len
Closed

Document postderef_qq support for ->$#* interpolation#20049
zmughal wants to merge 1 commit intoPerl:bleadfrom
zmughal-contrib:doc-postfix-array-len

Conversation

@zmughal
Copy link
Contributor

@zmughal zmughal commented Aug 5, 2022

This was added in commit ff25e5d.

@zmughal zmughal force-pushed the doc-postfix-array-len branch 2 times, most recently from 89ae348 to 58ae666 Compare August 5, 2022 23:38
zmughal added a commit to zmughal/p5-PPR that referenced this pull request Aug 6, 2022
@zmughal zmughal force-pushed the doc-postfix-array-len branch from 58ae666 to 93d6b8f Compare August 6, 2022 20:46
@zmughal zmughal requested a review from jkeenan August 6, 2022 22:38
@jkeenan
Copy link
Contributor

jkeenan commented Aug 6, 2022

The English style of the changes is now good. But I'd like someone else to review the content of the changes, as I myself have never used this Perl syntax. @rjbs perhaps?

zmughal added a commit to zmughal/p5-PPR that referenced this pull request Aug 8, 2022
@zmughal zmughal force-pushed the doc-postfix-array-len branch from 93d6b8f to 74e907e Compare November 2, 2022 02:57
@khwilliamson
Copy link
Contributor

This addition is needed, but it is misleading. The number returned is related to the array length, but it is one off. The number returned is the index of the highest element in the array. So if the array has 10 elements, 0..9, this returns 9. This needs to be clarified

@zmughal zmughal force-pushed the doc-postfix-array-len branch from 74e907e to bf3bb56 Compare November 22, 2022 17:06
@zmughal
Copy link
Contributor Author

zmughal commented Nov 23, 2022

I have updated the text again with @khwilliamson's suggestions. I think I might need to do a rebase again?

@khwilliamson
Copy link
Contributor

Unfortunately, use of the word 'last' is ambiguous. It can mean the previous, or the final. I suggest using 'highest' instead.

I don't think rebasing is required at this point.

@zmughal zmughal force-pushed the doc-postfix-array-len branch from bf3bb56 to 2075123 Compare November 29, 2022 22:41
@khwilliamson
Copy link
Contributor

khwilliamson commented Nov 30, 2022

Thanks

This was merged via 365f3e0

@zmughal zmughal deleted the doc-postfix-array-len branch November 30, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants