perlop: fix and normalize indentation and alignment #22658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This cannot be merged as is. It fails the t/porting/podcheck.t. See end of https://github.com/Perl/perl5/actions/runs/11281442619/job/31376683077?pr=22658 for options on fixing, run |
haarg
force-pushed
the
haarg/perlop-fix-improve-indent-alignment
branch
2 times, most recently
from
997089d to
8684cb8
Compare
jkeenan
approved these changes
Oct 11, 2024
Contributor
jkeenan
left a comment
jkeenan
left a comment
There was a problem hiding this comment.
make test_porting now passing. Recommend squash before merge.
demerphq
approved these changes
Oct 11, 2024
Tabs for alignment don't work well in verbatim sections. The indentation of the code may be stripped when being displayed, resulting in the tab alignment not matching the intention. This can currently be seen on https://metacpan.org/pod/perlop and https://perldoc.perl.org/perlop Since most of the code uses 4 space indents, normalize all of the indentation to use 4 spaces.
haarg
force-pushed
the
haarg/perlop-fix-improve-indent-alignment
branch
from
8684cb8 to
1bfdc64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tabs for alignment don't work well in verbatim sections. The indentation of the code may be stripped when being displayed, resulting in the tab alignment not matching the intention. This can currently be seen on https://metacpan.org/pod/perlop and https://perldoc.perl.org/perlop
Since most of the code uses 4 space indents, normalize all of the indentation to use 4 spaces.