lib/builtin.pm: Document that builtin functions have optimisations #22668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilmari
requested changes
Oct 14, 2024
leonerd
force-pushed
the
document-builtin-optimisations
branch
from
6a48150 to
2716541
Compare
wolfsage
reviewed
Oct 17, 2024
| such as by assignment into glob references. It is suggested not to do this, | ||
| so that the optimiser can correctly work out that intention of code which | ||
| calls these functions. | ||
Contributor
There was a problem hiding this comment.
"would be no longer be" -> "would no longer be".
"work out that intention" -> "work out the intention" (maybe?)
The whole thing feels very passive voice.
Maybe:
There are a number of optimisations that apply to functions in the L<builtin> package. If you
replace or override these functions, the optimisations may not take effect. Do so with caution.
Contributor
Author
There was a problem hiding this comment.
Ahyes, some better words.
…ich may stop working if the functions are replaced
leonerd
force-pushed
the
document-builtin-optimisations
branch
from
2716541 to
c873b68
Compare
Contributor
Author
|
Reworded by @wolfsage 's suggestion |
ilmari
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggests not to try replacing
builtin::functions, because it may break various optimisations.This is an alternative to #22657