Skip to content

t/op/goto.t: Remove superfluous 'exit;' statement #23649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkeenan merged 2 commits into from
Aug 29, 2025
Merged

t/op/goto.t: Remove superfluous 'exit;' statement #23649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f04a5d
t/op/goto.t: Remove superfluous 'exit;' statement
jkeenan Aug 26, 2025
f2ba7be
per @mauke comment in GH 23649
jkeenan Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions t/op/goto.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ sub bar {
}

&bar;
fail('goto bypass');
exit;
Copy link
Contributor

@mauke mauke Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This statement is here to ensure that bar does not return normally. (If it did, the exit would be executed, making the test fail because the rest of the planned tests wouldn't have run.)

It is important that the exit (or equivalent) remain there. For clarity, I would recommend adding an explicit fail:

&bar;
fail('goto bypass');
exit;

Copy link
Contributor Author

@jkeenan jkeenan Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating p.r. per your comments; additional eyeballs welcome.

Copy link
Contributor Author

@jkeenan jkeenan Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; squashed and rebased on blead. Will leave open for 1 day for any other comments, then commit.


FINALE:
Expand Down
Loading