Skip to content

Remove superfluous &utf8::AUTOLOAD #23724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khwilliamson merged 1 commit into from
Sep 18, 2025
Merged

Remove superfluous &utf8::AUTOLOAD #23724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions lib/utf8.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
package utf8;

# This file only defines the import/unimport subs, the rest are implemented by
# always-present functions in the perl interpreter itself.
# See also `universal.c` in the perl source

use strict;
use warnings;

our $utf8_hint_bits = 0x00800000;
our $ascii_hint_bits = 0x00000010; # Turned off when utf8 turned on

our $VERSION = '1.27';
our $AUTOLOAD;
our $VERSION = '1.28';

sub import {
$^H |= $utf8_hint_bits;
Expand All @@ -18,12 +21,6 @@ sub unimport {
$^H &= ~$utf8_hint_bits;
}

sub AUTOLOAD {
goto &$AUTOLOAD if defined &$AUTOLOAD;
require Carp;
Carp::croak("Undefined subroutine $AUTOLOAD called");
}

1;
__END__

Expand Down
4 changes: 2 additions & 2 deletions lib/utf8.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,8 +557,8 @@ SKIP: {

{
fresh_perl_like ('use utf8; utf8::moo()',
qr/Undefined subroutine utf8::moo/, {stderr=>1},
"Check Carp is loaded for AUTOLOADing errors")
qr/Undefined subroutine &utf8::moo/, {stderr=>1},
"Check undefined subroutines error")
}

{
Expand Down
Loading