New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for repository paths that are not relative #31

Merged
merged 2 commits into from Dec 15, 2013

Conversation

Projects
None yet
2 participants
@zmughal
Member

zmughal commented Dec 11, 2013

  • changes behaviour of get_file method for
    Alien::Base::ModuleBuild::Repository
  • checks if the HTTP link passed to get_file in Repository::HTTP is an
    absolute URI

This changes the API for the Repository classes, but I've checked CPAN for possible subclasses and could not find any. There may be a better way to do this.

The specific package I made this change for is libuninum.

fix for repository paths that are not relative
- changes behaviour of get_file method for
  Alien::Base::ModuleBuild::Repository
- checks if the HTTP link passed to get_file in Repository::HTTP is an
  absolute URI
@zmughal

This comment has been minimized.

Show comment
Hide comment
@zmughal

zmughal Dec 11, 2013

Member

The regex here may need to be /https?:/.

Member

zmughal commented Dec 11, 2013

The regex here may need to be /https?:/.

@zmughal

This comment has been minimized.

Show comment
Hide comment
@zmughal

zmughal Dec 12, 2013

Member

Bah, I forgot to add tests!

Member

zmughal commented Dec 12, 2013

Bah, I forgot to add tests!

jberger added a commit that referenced this pull request Dec 15, 2013

Merge pull request #31 from zmughal/fix/http-abs-uri
fix for repository paths that are not relative

@jberger jberger merged commit 4a7f13b into Perl5-Alien:master Dec 15, 2013

@zmughal zmughal referenced this pull request Dec 19, 2013

Closed

get tarball #1

plicease pushed a commit that referenced this pull request Jul 17, 2017

Merge pull request #31 from zmughal/fix/http-abs-uri
fix for repository paths that are not relative

plicease pushed a commit that referenced this pull request Jul 17, 2017

Merge pull request #31 from zmughal/fix/http-abs-uri
fix for repository paths that are not relative

plicease pushed a commit that referenced this pull request Jul 17, 2017

Merge pull request #31 from zmughal/fix/http-abs-uri
fix for repository paths that are not relative

plicease pushed a commit that referenced this pull request Jul 17, 2017

Merge pull request #31 from zmughal/fix/http-abs-uri
fix for repository paths that are not relative

plicease pushed a commit that referenced this pull request Jul 17, 2017

Merge pull request #31 from zmughal/fix/http-abs-uri
fix for repository paths that are not relative

plicease pushed a commit that referenced this pull request Jul 17, 2017

Alien-Base: Merge pull request #31 from zmughal/fix/http-abs-uri
Alien-Base: 
Alien-Base: fix for repository paths that are not relative
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment