Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor config.pl and probe.pl generation. #110

Closed
plicease opened this issue Jan 30, 2019 · 2 comments

Comments

@plicease
Copy link
Member

commented Jan 30, 2019

  • config.pl should have only the things that are useful at FFI-Platypus + FFI module runtime, like type size/sign/alignment.
  • probe.pl should have only the things that are useful during a FFI module probe, like header files, abi, etc. and preferably not stuff that is only useful during the Platypus probe, like eumm

There is some duplication, some stuff is in probe.pl AND config.pl, although in a different form. This duplication should be removed.

Beyond being more correct, the motivation for removing eumm from probe.pl is to avoid including non-reproducible build information into the install files in a Debian install, see #104.

@plicease

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2019

@gregoa this has been implemented as #159 and released as FFI::Platypus 0.95_03. I removed a number of keys that weren't being used and/or moved anything build related into its own store. You may want to check that this version addresses the concern that you originally raised in #104.

@plicease plicease closed this Jul 29, 2019

@gregoa

This comment has been minimized.

Copy link

commented Aug 20, 2019

(Sorry for the delay …)

Indeed, this seems to be fixed in 0.96 - no more diff between the built packages after building them with different paths (and after removing my hack to replace the paths :)). Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.