Skip to content

Commit

Permalink
Revert 344f761 - this was a stupid idea
Browse files Browse the repository at this point in the history
Way too many failures, maked CPANTesters output unusable.
Extracted and submitted as DBI RT#82942 instead
  • Loading branch information
ribasushi committed Jan 25, 2013
1 parent 078ef6b commit 728f32b
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions t/52leaks.t
Original file line number Diff line number Diff line change
Expand Up @@ -410,13 +410,16 @@ for my $moniker ( keys %{DBICTest::Schema->source_registrations || {}} ) {
# half of it is in XS no leaktracer sees it, and Devel::FindRef is equally
# stumped when trying to trace the origin. The problem is:
#
# $cond_object --> result_source --> schema --> storage --> $dbh --> {cached_kids}
# $cond_object --> result_source --> schema --> storage --> $dbh --> {CachedKids}
# ^ /
# \-------- bound value on prepared/cached STH <-----------/
#
if ( my $r = $weak_registry->{'basic leaky_resultset_cond'}{weakref} ) {
ok(! defined $r, 'Self-referential RS conditions no longer leak!')
or $r->result_source(undef);
{
local $TODO = 'This fails intermittently - see RT#82942';
if ( my $r = $weak_registry->{'basic leaky_resultset_cond'}{weakref} ) {
ok(! defined $r, 'Self-referential RS conditions no longer leak!')
or $r->result_source(undef);
}
}

assert_empty_weakregistry ($weak_registry);
Expand Down

0 comments on commit 728f32b

Please sign in to comment.