Skip to content

Commit

Permalink
Better lean startup skip in require override
Browse files Browse the repository at this point in the history
ribasushi-- # didn't think through this kind of thing can happen more widely
  • Loading branch information
ribasushi committed May 26, 2016
1 parent 140bcb6 commit e8452b0
Showing 1 changed file with 4 additions and 11 deletions.
15 changes: 4 additions & 11 deletions xt/extra/lean_startup.t
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,10 @@ BEGIN {

return $res if $req =~ /^DBIx::Class|^DBICTest::/;

# FIXME - work around RT#114641
#
# Because *OF COURSE* when (questionable) unicode tests fail on < 5.8
# the answer is to make the entire module 5.8 only, instead of skipping
# the tests in question
# rjbs-- # thinly veiled passive aggressive bullshit
#
# The actual skip is needed because the use happens before 'package' had
# a chance to switch the namespace, so the shim thinks DBIC::Schema tried
# to require this
return $res if $req eq '5.008';
# Some modules have a bare 'use $perl_version' as the first statement
# Since the use() happens before 'package' had a chance to switch
# the namespace, the shim thinks DBIC* tried to require this
return $res if $req =~ /^v?[0-9.]$/;

# exclude everything where the current namespace does not match the called function
# (this works around very weird XS-induced require callstack corruption)
Expand Down

0 comments on commit e8452b0

Please sign in to comment.