Skip to content

Commit

Permalink
(travis) Work around a bad tradeoff in cperl-5.24-to-be
Browse files Browse the repository at this point in the history
  • Loading branch information
ribasushi committed Jun 8, 2016
1 parent e66f0ee commit ee3a37d
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions maint/travis-ci_scripts/30_before_script.bash
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ if is_cperl ; then
# (cperl 5.22.2 comes with YAML already)
perl -M5.022002 -e1 &>/dev/null || installdeps YAML

# Work around cperl's Test::More being typed, by getting the CPAN one
# https://github.com/perl11/cperl/issues/153#issuecomment-224515895
# ( in the long term this is sadly a nail in cperl's coffin :/ )
installdeps Test::More

fi


Expand Down

2 comments on commit ee3a37d

@rurban
Copy link

@rurban rurban commented on ee3a37d Jun 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will not win. I will bump our Test::More version for our modernized versions, so an upgrade will not help, and only leads to worse code in your codebase.
The types are there for a reason.

@ribasushi
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rurban I can neither win nor lose - I personally have no use-case for cperl.

I am simply using my already existing infrastructure to smoke your work, as it is very little effort on my side, and hence is the right thing to do.

If the effort becomes insurmountable - the testing will cease and things will move on.

Please sign in to comment.