Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Improvements #100

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tomhukins
Copy link
Contributor

No description provided.

ribasushi and others added 3 commits April 11, 2016 23:06
Allow MVDT and BREAK_CC to be separate settings, will make sense in further
commits

Read under -w
DBIx::Class::Manual::Intro doesn't mention joins at all, so stop
pointing people who don't know joins there.
to fetch the tracks, or you can use a join. Compare:
To retrieve information about a particular CD and all its tracks, either
fetch the CD row, then make another query to fetch the tracks, or use a
join. Compare:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be expanded a little - as join on its own won't fetch anything extra. Perhaps L<join and select|DBIx::Class::Resultset/prefetch> the extra data.

Also towards the end of this section there is a link to a reference manual on SQL-side join syntax, not sure if this is the best resource... Thoughts?

Thanks for the contribution!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Mon, Apr 11, 2016 at 03:29:08PM -0700, Peter Rabbitson wrote:

I think this needs to be expanded a little - as join on its own
won't fetch anything extra. Perhaps L<join and select|DBIx::Class::Resultset/prefetch> the extra data.

Good point. I'll work on that.

Also towards the end of this section there is a link to a reference
manual on SQL-side join syntax, not sure if this is the best
resource... Thoughts?

https://en.wikipedia.org/wiki/Join_%28SQL%29 provides a more database
agnostic reference and
https://blog.codinghorror.com/a-visual-explanation-of-sql-joins/
provides a popular visual summary. How about I link to those instead?

Tom

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about I link to those instead?

Excellent! I'd order the visual explainer first. Also since you are in this headspace already: could you possibly work a sentence about this somewhere: https://rt.cpan.org/Ticket/Display.html?id=104289#txn-1494725. I am not trying to create more work for you, this is just tightly related and has been gathering dust for a while...

Cheers!

@ribasushi
Copy link
Collaborator

@tomhukins Have you had a chance to move this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants