RT #113741 #101
Closed
RT #113741 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Please don't merge until the issues above are fixed!) |
|
This is now fixed via e7dcdf69fd#diff-7ec2db724e80c975475473f856913213. Thanks for spotting! |
|
@ribasushi Didn't even think of Thanks for the fix! |
|
The fix is now properly in the CPAN index. Sorry it took so long :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ribasushi I have written a few tests (and also the actual fix, but I haven't committed it yet).
The exception is thrown after the deployment occurs, so the first call to deploy() creates the tables, and the second one dies with "A versioned schema has already been deployed, try upgrade instead.". So these tests are not very useful and I'm not sure how to make them better.
I'm sending the PR anyway to have a space in which to converse (this is rather more comfortable than RT), if you have any ideas.