Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less stringent column name checking in __strip_relcond #107

Closed
wants to merge 1 commit into from
Closed

Less stringent column name checking in __strip_relcond #107

wants to merge 1 commit into from

Conversation

mzealey
Copy link

@mzealey mzealey commented Jul 29, 2016

If (like us) you are using some strange syntax for column names the \w+ regex
breaks returning () which leads to an incorrect hash.

If (like us) you are using some strange syntax for column names the \w+ regex
breaks returning () which leads to an incorrect hash.
@ribasushi
Copy link
Collaborator

@mzealey I am preparing an alternative changeset which addresses the above in a much more substantial way. It is going to be ready by tomorrow, at which point I would like to have you test it.

In the meantime: given your report made me revisit the entire codepath I would like to add you to the AUTHORS list, could you please let me know what line would you prefer given the format?

Thanks!

@mzealey
Copy link
Author

mzealey commented Aug 22, 2016

Thanks. Just Mark Zealey <mark@dns-consultants.com> is fine

@ribasushi
Copy link
Collaborator

Just Mark Zealey <mark@dns-consultants.com> is fine

Would it be ok to add your IRC nick as well? Or was that someone else I spoke to on IRC about this?
jalh: Mark Zealey <mark@dns-consultants.com>

@mzealey
Copy link
Author

mzealey commented Aug 22, 2016

ok

@ribasushi
Copy link
Collaborator

This has now been addressed by 86be9bcb9 (part of a much larger rework, prompted by a different set of problems). Please check out latest master (89d5e36fd) and see if the problem still persists (it is possible that the now-official resolve_relationship_condition() has flaws related to parsing your use-case)

I will keep the PR open for some time as a reminder it still needs input from you.

@mzealey mzealey closed this Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants