use base before namespace::clean #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namespace::clean uses the hints hash to track when it should do its work. Without extra protection, using hints across nested module loads can crash on perl <= 5.8.3. Older versions of base.pm used a string eval, which served to provide the isolation needed to avoid the bug. Moving the use base before the use namespace::clean means the hints aren't used until after the other modules are loaded, which avoids this issue. An alternate workaround would involve localizing the hints, but this involves intercepting the module loads. This would mean using something like Module::Runtime or Lexical::SealRequireHints, although those modules don't currently provide the localization needed to workaround this specific issue.
|
@haarg I believe I fixed this for good via https://metacpan.org/diff/file?source=ETHER/B-Hooks-EndOfScope-0.21&target=ETHER/B-Hooks-EndOfScope-0.24#lib/B/Hooks/EndOfScope/PP/HintHash.pm Double check if I am correct before I close this PR as "no longer needed" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namespace::clean uses the hints hash to track when it should do its
work. Without extra protection, using hints across nested module
loads can crash on perl <= 5.8.3. Older versions of base.pm used a
string eval, which served to provide the isolation needed to avoid the
bug.
Moving the use base before the use namespace::clean means the hints
aren't used until after the other modules are loaded, which avoids this
issue.
An alternate workaround would involve localizing the hints, but this
involves intercepting the module loads. This would mean using something
like Module::Runtime or Lexical::SealRequireHints, although those modules
don't currently provide the localization needed to workaround this
specific issue.