Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT-123495 Fix failing tests in t/72pg.t #119

Closed
wants to merge 1 commit into from

Conversation

mrmuskrat
Copy link

This addresses https://rt.cpan.org/Ticket/Display.html?id=123494 by adding the expected warning in the call to warnings_like on line 512.

@ribasushi
Copy link
Collaborator

Hi @mrmuskrat, sorry for the delay.

As you noted in the corresponding RT, the patch would be problematic on older versions of Postgres ( and DBIC explicitly does not define a lower bound for supported versions ).

The problem you observed in RT-123495 does not affect he maintenance branch ( which is going to see at least one more release before things move onward ). There is a more in-depth fix required on the current codebase in master to completely remove the incorrect use of Scope::Guard, which ( as a side-effect ) will remove this warning as well on all versions of Postgres.

Therefore this PR will be closed as "won't apply", but the corresponding RT will remain open to ensure this doesn't slip.

Thanks for testing this!

@ribasushi ribasushi closed this Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants