Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exception_action's ignorance of exceptions which stringify to empty string #15

Closed
wants to merge 1 commit into from

Conversation

lamoz
Copy link

@lamoz lamoz commented Jan 21, 2013

I'm not sure about how to find out that exception happened the right way. It seems to me that there is no simple way to check that $@ contains exactly empty string but not something which pretends to be. I am used to check that exception happened by writing "if( $@ ) {...}" ie ckecking for true/false. So my fix proposition may be good for me but not for all cases out there.

@dbsrgits-sync
Copy link

On Mon, Jan 21, 2013 at 01:20:35PM -0800, lamoz wrote:

I'm not sure about how to find out that exception happened the right way. It seems to me that there is no simple way to check that $@ contains exactly empty string but not something which pretends to be. I am used to check that exception happened by writing "if( $@ ) {...}" ie ckecking for true/false. So my fix proposition may be good for me but not for all cases out there.

Please see reply in http://lists.scsys.co.uk/pipermail/dbix-class/2013-January/011077.html

@ribasushi
Copy link
Collaborator

Hi @lamoz

Just wanted to point out that your tests were finally included as 84e4e006, based on work previously done in 841efcb3. The entire changeset inspired by this PR can be seen here.

Thank you!

@ribasushi ribasushi closed this Aug 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants