Add deprecation warnings for cols/include_columns

[dariusj]

• Also update docs and include test

[ribasushi]

Excellent - this is exactly what I had in mind. Some notes:

"Resultset specifies..." sounds odd, given that the callsite reported will be the search() containing the attr in question. Also when possible we try to stick to a single sentence for warnings/exceptions. A better wording (which is also more in line with other deprecation notices) is "Resultset attribute 'foo' has been deprecated - use 'bar' instead".

Your first carp_unique has an extra quote mark at the end.

Please also add a line abot these to Changes (user-visible changes)

I noticed the email you used in the author list is different than what you used to make the commit. Intentional or oversight or...?

Cheers and thanks!

[dariusj]

• "Resultset specifies" - I reused the same structure as a carp statement just below it - happy to change it to what you suggest though, it's more succinct and sounds better anyway.
• Oops you're right about the extra quote mark!
• I'll update the Changes file (not quite sure under what heading to put things...)
• Yeah I'm doing this at work, I didn't bother changing my git config... probably should though.

I'll rebase my commits into one with a matching email address too.

Let me know if there's any other changes you'd like me to do.

Cheers!

[ribasushi]

Merged as 11343b34c, only change was the reorganizing of the CHANGES line (it is a user visible change so goes in "New/Changes")

Thank you for your work!

[dariusj]

Glad to hear it!