Add deprecation warning for $rs->new instead of new_result #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delayed response. The warning as implemented becomes rather noisy in legacy cdbi-like codestyles that I am not yet willing to deprecate (despite the general attitude of "let it burn" on #dbic). I have a semi-working class chain prototype which will allow the code you contributed to be less disruptive to such environments. This is why for the time being your PR is "on hold", I just wanted to give you some feedback. |
|
Makes sense and sounds good, thanks for the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion with mst and ribasushi today in #dbix-class about calling new_result instead of new for row objects. The constructor will get hosed when using MooseX::NonMoose, so that is another reason to keep things clear by always calling new_result.