New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for handling Class::DBI::Column in CDBICompat #52

Closed

ungrim97 wants to merge 1 commit into Perl5:current/for_cpan_index from ungrim97:feature/column_object

Contributor

ungrim97 commented Jul 21, 2014

Class::DBI supports adding Class::DBI::Column objects to calls to ->columns. This should enable that and use the accessor/mutator methods.

This only supports setting accessors on the Result class object not in calls to ->create ect.


          Added support for handling Class::DBI::Column in CDBICompat

2dafbe2

Collaborator

ribasushi commented Jul 24, 2014

Looks good, merged at 7ad80222. The only adjustment (and corresponding boilerplate) was:

         my($ro_meth, $wo_meth);
-        if (ref $col && $col->isa('Class::DBI::Column')){
+        if (defined blessed $col and $col->isa('Class::DBI::Column')) {
             $ro_meth = $col->accessor;

Cheers and please keep them coming ;)

ribasushi closed this

ungrim97 deleted the feature/column_object branch

July 24, 2014 07:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment